Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_lb_target_group: Allow a blank health check path, for TCP healtchecks #2980

Merged
merged 1 commit into from
Jan 16, 2018
Merged

resource/aws_lb_target_group: Allow a blank health check path, for TCP healtchecks #2980

merged 1 commit into from
Jan 16, 2018

Commits on Jan 12, 2018

  1. [aws_lb_target_group] Allow a blank health check path, for TCP health… 

    … checks

Fixes hashicorp#2978 "Validation forces invalid path for TCP health check" 

Currently the validation forces the health check path to begin with a slash("/"), even when the protocol is TCP, in which case the health check path must be blank. The validation is preventing valid use cases. 

Since this validation can only check the one field on its own, the check is amended to only validate the path begins with a "/" if the path is not blank. Note that when the path is blank, it is not passed to AWS at all (see lines 226-228), so I think this change does not weaken validation.
    @whereisaaron
    whereisaaron authored Jan 12, 2018
    Configuration menu
    Copy the full SHA
    a9cf3e0 View commit details
    Browse the repository at this point in the history