Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lambda_function: Always set skip_destroy in resource Read #29812

Merged
merged 7 commits into from
Mar 6, 2023
Merged

r/aws_lambda_function: Always set skip_destroy in resource Read #29812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dceff48
r/aws_lambda_function: Add 'TestAccLambdaFunction_skipDestroyInconsis…
ewbankkit Mar 3, 2023
4219262
r/aws_lambda_function: Set 'skip_destroy' in resource Read.
ewbankkit Mar 6, 2023
1295773
Add CHANGELOG entry.
ewbankkit Mar 6, 2023
9f0d8be
Merge branch 'main' into b-aws_lambda_function.skip_destroy-regression
ewbankkit Mar 6, 2023
9537e46
r/aws_lambda_function: Remove 'skip_destroy' from acceptance test 'Im…
ewbankkit Mar 6, 2023
a572a76
Tweak CHANGELOG entry.
ewbankkit Mar 6, 2023
6c88865
Update .changelog/29812.txt
ewbankkit Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/29812.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_lambda_function: Prevent `Provider produced inconsistent final plan` errors produced by null `skip_destroy` attribute value. NOTE: Because the maintainers have been unable to reproduce the reported problem, the fix is best effort and we ask for community support in verifying the fix.
```
2 changes: 2 additions & 0 deletions internal/service/lambda/function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,8 @@ func resourceFunctionRead(ctx context.Context, d *schema.ResourceData, meta inte
d.Set("runtime", function.Runtime)
d.Set("signing_job_arn", function.SigningJobArn)
d.Set("signing_profile_version_arn", function.SigningProfileVersionArn)
// Support in-place update of non-refreshable attribute.
d.Set("skip_destroy", d.Get("skip_destroy"))
if err := d.Set("snap_start", flattenSnapStart(function.SnapStart)); err != nil {
return sdkdiag.AppendErrorf(diags, "setting snap_start: %s", err)
}
Expand Down
Loading