Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for ElastiCache Reserved Cache Nodes #29832

Merged
merged 19 commits into from
Sep 18, 2024

Conversation

mousavian
Copy link
Contributor

@mousavian mousavian commented Mar 7, 2023

Description

Added support for purchasing ElastiCache reserved Cache Nodes via Terraform.

Relations

Closes #28060

References

Output from Acceptance Testing

⚠️ Since reservations can't be deleted without getting help from AWS Support, Unfortunately I am not able to run this test. Unless you don't have the budget allocated for this kind of stuff, we probably should just rely on the community to test — similar to #26025 (comment).
The reservation test will be skipped if RUN_ELASTICACHE_RESERVED_CACHE_NODE_TESTS env variable is not provided to prevent any unwanted cost.

$ make testacc TESTS=TestAccElastiCacheReservedNodeOffering_\|TestAccElastiCacheReservedCacheNode_ PKG=elasticache

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReservedNodeOffering_|TestAccElastiCacheReservedCacheNode_'  -timeout 180m
=== RUN   TestAccElastiCacheReservedNodeOffering_basic
=== PAUSE TestAccElastiCacheReservedNodeOffering_basic
=== RUN   TestAccElastiCacheReservedCacheNode_basic
    reserved_cache_node_test.go:24: Environment variable RUN_ELASTICACHE_RESERVED_CACHE_NODE_TESTS is not set to true
--- SKIP: TestAccElastiCacheReservedCacheNode_basic (0.00s)
=== CONT  TestAccElastiCacheReservedNodeOffering_basic
--- PASS: TestAccElastiCacheReservedNodeOffering_basic (22.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	26.258s

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 7, 2023
@mousavian mousavian force-pushed the f-elasticache-reserved-cache-node branch from 47a1d8d to bb08389 Compare March 7, 2023 15:18
@mousavian mousavian marked this pull request as ready for review March 7, 2023 15:19
@mousavian mousavian force-pushed the f-elasticache-reserved-cache-node branch 2 times, most recently from 4349d49 to 85f15c8 Compare March 7, 2023 16:09
@github-actions github-actions bot added the generators Relates to code generators. label Mar 7, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Mar 8, 2023
@mousavian
Copy link
Contributor Author

Hey @justinretzolk ,
The issue #28060 related to this PR has 50+ thumbs-ups. Does this qualify this PR to be prioritised and reviewed?

Thanks,
R

@sedatsencan
Copy link

Any update?

@gdavison gdavison self-assigned this Sep 16, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 16, 2024
@gdavison gdavison force-pushed the f-elasticache-reserved-cache-node branch from 86e9886 to ce0fe83 Compare September 16, 2024 21:00
@gdavison gdavison requested a review from a team as a code owner September 16, 2024 21:00
@gdavison gdavison enabled auto-merge September 18, 2024 20:35
@gdavison gdavison disabled auto-merge September 18, 2024 20:37
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @mousavian. I've converted the implementations from Terraform Plugin SDK to Framework and made a few adjustments

--- PASS: TestAccElastiCacheReservedNodeOffering_basic (11.19s)

@gdavison gdavison merged commit 10f8b4c into hashicorp:main Sep 18, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 18, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Support for ElastiCache Reserved Nodes
4 participants