Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elastic_beanstalk_configuration_template: Map InvalidParameterValue: No Platform named ... to NotFoundError #29863

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 8, 2023

Description

Maps errors like InvalidParameterValue: No Platform named '...' found. to resource.NotFoundError so terraform refesh correctly removes the resource.

Relations

Closes #29856.
Relates #1222.
Relates #27991.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccElasticBeanstalkConfigurationTemplate_' PKG=elasticbeanstalk ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticbeanstalk/... -v -count 1 -parallel 3  -run=TestAccElasticBeanstalkConfigurationTemplate_ -timeout 180m
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_basic
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_basic
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_disappears
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_disappears
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_Disappears_application
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_Disappears_application
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_vpc
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_vpc
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_settings
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_settings
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_basic
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_vpc
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_Disappears_application
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_Disappears_application (19.69s)
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_disappears
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_basic (21.55s)
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_settings
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_vpc (28.34s)
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_disappears (21.62s)
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_settings (22.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	49.141s

…anstalkConfigurationTemplate_Disappears_application'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccElasticBeanstalkConfigurationTemplate_Disappears_application' PKG=elasticbeanstalk ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticbeanstalk/... -v -count 1 -parallel 3  -run=TestAccElasticBeanstalkConfigurationTemplate_Disappears_application -timeout 180m
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_Disappears_application
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_Disappears_application
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_Disappears_application
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_Disappears_application (17.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	23.407s
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 8, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Mar 8, 2023
@ewbankkit ewbankkit merged commit c4c4141 into main Mar 8, 2023
@ewbankkit ewbankkit deleted the b-aws_elastic_beanstalk_configuration_template.InvalidParameterValue branch March 8, 2023 14:16
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 8, 2023
github-actions bot pushed a commit that referenced this pull request Mar 8, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: InvalidParameterValue: No Platform named ... found.
1 participant