terraform import aws_dx_lag and aws_dx_connection

[ewbankkit]

Fixes #2991

Acceptance tests at present:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxLag_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxLag_import -timeout 120m
=== RUN   TestAccAwsDxLag_importBasic
--- FAIL: TestAccAwsDxLag_importBasic (27.22s)
	testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
		
		(map[string]string) {
		}
		
		
		(map[string]string) (len=5) {
		 (string) (len=21) "connections_bandwidth": (string) (len=5) "1Gbps",
		 (string) (len=13) "force_destroy": (string) (len=4) "true",
		 (string) (len=8) "location": (string) (len=5) "EqSe2",
		 (string) (len=4) "name": (string) (len=15) "tf-dx-lag-9ke1v",
		 (string) (len=21) "number_of_connections": (string) (len=1) "2"
		}
		
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	27.228s
GNUmakefile:18: recipe for target 'testacc' failed
make: *** [testacc] Error 1

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxConnection_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxConnection_import -timeout 120m
=== RUN   TestAccAwsDxConnection_importBasic
--- FAIL: TestAccAwsDxConnection_importBasic (26.03s)
	testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
		
		(map[string]string) {
		}
		
		
		(map[string]string) (len=3) {
		 (string) (len=9) "bandwidth": (string) (len=5) "1Gbps",
		 (string) (len=8) "location": (string) (len=5) "EqSe2",
		 (string) (len=4) "name": (string) (len=11) "tf-dx-en2vq"
		}
		
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	26.037s
GNUmakefile:18: recipe for target 'testacc' failed
make: *** [testacc] Error 1

I do NOT expect these to pass until #2989 is merged.

[ewbankkit]

After merging with #2989:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxLag_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxLag_import -timeout 120m
=== RUN   TestAccAwsDxLag_importBasic
--- PASS: TestAccAwsDxLag_importBasic (29.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.506s

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxConnection_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxConnection_import -timeout 120m
=== RUN   TestAccAwsDxConnection_importBasic
--- PASS: TestAccAwsDxConnection_importBasic (37.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.617s

[radeksimko]

@ewbankkit do you mind rebasing your branch? Then I'm happy to review this. 😉

[ewbankkit]

Rebased.
Re-ran acceptance tests:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxLag_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxLag_import -timeout 120m
=== RUN   TestAccAwsDxLag_importBasic
--- PASS: TestAccAwsDxLag_importBasic (34.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.578s

make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxConnection_import'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxConnection_import -timeout 120m
=== RUN   TestAccAwsDxConnection_importBasic
--- PASS: TestAccAwsDxConnection_importBasic (31.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.903s

[radeksimko]

LGTM, thanks. 👍

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!