Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WebACL associations make timeout configurable. #30002

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

grahamhar
Copy link
Contributor

Description

The time taken for a WebACl to get in a state
where it can be associated varies and in recent
times has become larger than the hardcoded timeout.

Making this configurable to allow for this.

Relations

Closes #29080

References

Output from Acceptance Testing

Sorry unable to run tests in my own AWS account.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Mar 14, 2023
The time taken for a WebACl to get in a state
where it can be associated varies and in recent
times has become larger than the hardcoded timeout.

Making this configurable to allow for this.
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@grahamhar Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 55177e6 into hashicorp:main Mar 14, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 14, 2023
@Maansi13
Copy link

@grahamhar @ewbankkit
I've got the same error with Terraform 1.3.2
Unfortunately, we use the CloudShare platform and they only have until Terraform 1.3.2.
is it possible for me to add timeouts to "wafv2_webacl_association" in that version?

NOTE: We have an upcoming lab which depends on this.

@Maansi13
Copy link

is it possible to push the change to Terraform v1.3.2?

@grahamhar
Copy link
Contributor Author

grahamhar commented Mar 16, 2023

It is nothing to do with the terraform version it is in the AWS provider version. This isn't released yet but when it is you will need to configure your provider to use at least that version, something like:

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 4.59.0"
    }
  }
}

@Maansi13
Copy link

Oh no, yeah my bad the provider version. But when do we expect this to release though?

@Maansi13
Copy link

@grahamhar - Could you suggest a workaround or alternative meanwhile, if any?

@grahamhar
Copy link
Contributor Author

Not a simple one

@Maansi13
Copy link

We currently have a 4.35.0 "aws" provider version.
@grahamhar - Do you mind sharing the alternative? I am not sure if I can make the change but would give it a try at least.

@grahamhar
Copy link
Contributor Author

As per my example above wait for the new version to be released with this PR in it and then take a note of the new version number and use this version in your configure

@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants