-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WebACL associations make timeout configurable. #30002
Conversation
Community NoteVoting for Prioritization
For Submitters
|
The time taken for a WebACl to get in a state where it can be associated varies and in recent times has become larger than the hardcoded timeout. Making this configurable to allow for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@grahamhar Thanks for the contribution 🎉 👏. |
@grahamhar @ewbankkit NOTE: We have an upcoming lab which depends on this. |
is it possible to push the change to Terraform v1.3.2? |
It is nothing to do with the terraform version it is in the AWS provider version. This isn't released yet but when it is you will need to configure your provider to use at least that version, something like: terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4.59.0"
}
}
} |
Oh no, yeah my bad the provider version. But when do we expect this to release though? |
@grahamhar - Could you suggest a workaround or alternative meanwhile, if any? |
Not a simple one |
We currently have a 4.35.0 "aws" provider version. |
As per my example above wait for the new version to be released with this PR in it and then take a note of the new version number and use this version in your configure |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The time taken for a WebACl to get in a state
where it can be associated varies and in recent
times has become larger than the hardcoded timeout.
Making this configurable to allow for this.
Relations
Closes #29080
References
Output from Acceptance Testing
Sorry unable to run tests in my own AWS account.