Changed video_description from typeSet to typeList

[jonasdkhansen]

Description

Changed video_description to a typeList, instead of typeSet, to get precise actions from plan output.

Example plan output, with video_description as typeList:

          ~ video_descriptions {
                name             = "720p5400"
                # (5 unchanged attributes hidden)

              ~ codec_settings {

                  ~ h264_settings {
                      ~ buf_fill_pct            = 90 -> 91
                        # (35 unchanged attributes hidden)
                    }
                }
            }

Example plan output, with video_description as typeSet:

          - video_descriptions {
              - height           = 720 -> null
              - name             = "720p5400" -> null
              - respond_to_afd   = "NONE" -> null
              - scaling_behavior = "DEFAULT" -> null
              - sharpness        = 100 -> null
              - width            = 1280 -> null

              - codec_settings {

                  - h264_settings {
                      - adaptive_quantization   = "LOW" -> null
                      - afd_signaling           = "NONE" -> null
                      - bitrate                 = 5400000 -> null
                      - buf_fill_pct            = 90 -> null
                      - buf_size                = 10800000 -> null
                      - color_metadata          = "IGNORE" -> null
                      - entropy_encoding        = "CABAC" -> null
                      - flicker_aq              = "ENABLED" -> null
                      - force_field_pictures    = "DISABLED" -> null
                      - framerate_control       = "SPECIFIED" -> null
                      - framerate_denominator   = 1 -> null
                      - framerate_numerator     = 50 -> null
                      - gop_b_reference         = "DISABLED" -> null
                      - gop_closed_cadence      = 1 -> null
                      - gop_num_b_frames        = 1 -> null
                      - gop_size                = 0 -> null
                      - gop_size_units          = "SECONDS" -> null
                      - level                   = "H264_LEVEL_AUTO" -> null
                      - look_ahead_rate_control = "HIGH" -> null
                      - max_bitrate             = 0 -> null
                      - min_i_interval          = 0 -> null
                      - num_ref_frames          = 3 -> null
                      - par_control             = "INITIALIZE_FROM_SOURCE" -> null
                      - par_denominator         = 0 -> null
                      - par_numerator           = 0 -> null
                      - profile                 = "HIGH" -> null
                      - qvbr_quality_level      = 0 -> null
                      - rate_control_mode       = "CBR" -> null
                      - scan_type               = "PROGRESSIVE" -> null
                      - scene_change_detect     = "DISABLED" -> null
                      - slices                  = 1 -> null
                      - softness                = 0 -> null
                      - spatial_aq              = "ENABLED" -> null
                      - subgop_length           = "FIXED" -> null
                      - syntax                  = "DEFAULT" -> null
                      - temporal_aq             = "ENABLED" -> null
                      - timecode_insertion      = "PIC_TIMING_SEI" -> null
                    }
                }
            }
          + video_descriptions {
              + height           = 720
              + name             = "720p5400"
              + respond_to_afd   = "NONE"
              + scaling_behavior = "DEFAULT"
              + sharpness        = 100
              + width            = 1280

              + codec_settings {

                  + h264_settings {
                      + adaptive_quantization   = "LOW"
                      + afd_signaling           = "NONE"
                      + bitrate                 = 5400000
                      + buf_fill_pct            = 91
                      + buf_size                = 10800000
                      + color_metadata          = "IGNORE"
                      + entropy_encoding        = "CABAC"
                      + fixed_afd               = (known after apply)
                      + flicker_aq              = "ENABLED"
                      + force_field_pictures    = "DISABLED"
                      + framerate_control       = "SPECIFIED"
                      + framerate_denominator   = 1
                      + framerate_numerator     = 50
                      + gop_b_reference         = "DISABLED"
                      + gop_closed_cadence      = 1
                      + gop_num_b_frames        = 1
                      + gop_size                = 1.92
                      + gop_size_units          = "SECONDS"
                      + level                   = "H264_LEVEL_AUTO"
                      + look_ahead_rate_control = "HIGH"
                      + max_bitrate             = (known after apply)
                      + min_i_interval          = (known after apply)
                      + num_ref_frames          = 3
                      + par_control             = "INITIALIZE_FROM_SOURCE"
                      + par_denominator         = (known after apply)
                      + par_numerator           = (known after apply)
                      + profile                 = "HIGH"
                      + quality_level           = (known after apply)
                      + qvbr_quality_level      = (known after apply)
                      + rate_control_mode       = "CBR"
                      + scan_type               = "PROGRESSIVE"
                      + scene_change_detect     = "DISABLED"
                      + slices                  = 1
                      + softness                = (known after apply)
                      + spatial_aq              = "ENABLED"
                      + subgop_length           = "FIXED"
                      + syntax                  = "DEFAULT"
                      + temporal_aq             = "ENABLED"
                      + timecode_insertion      = "PIC_TIMING_SEI"
                    }
                }
            }

Relations

Relates #27824

References

Output from Acceptance Testing

Test has been run against TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings, submitted in the following pull request: https://github.com/hashicorp/terraform-provider-aws/pull/30063/files#diff-a00c39405a6da384e7a7073be9b7d1802267b9d813d1416a9a0134ff2b3eddc4

make testacc TESTS=TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings'  -timeout 180m
=== RUN   TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings
=== PAUSE TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings
=== CONT  TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings
--- PASS: TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings (85.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	107.071s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @jonasdkhansen 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[jonasdkhansen]

Hey @jonasdkhansen 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

We are aware of this, we are unable to change this at the current moment.

[johnsonaj]

@jonasdkhansen overall the PR looks good. Made a few comments below.

Also, can you rebase/merge main into this PR?

[johnsonaj]

LGTM 🚀

$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_'  -timeout 180m
--- PASS: TestAccMediaLiveChannel_videoDescriptions_codecSettings_h264Settings (71.49s)
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (86.27s)
--- PASS: TestAccMediaLiveChannel_disappears (98.34s)
--- PASS: TestAccMediaLiveChannel_m2ts_settings (100.39s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (110.62s)
--- PASS: TestAccMediaLiveChannel_updateTags (158.98s)
--- PASS: TestAccMediaLiveChannel_update (161.87s)
--- PASS: TestAccMediaLiveChannel_basic (165.66s)
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (174.36s)
--- PASS: TestAccMediaLiveChannel_hls (238.50s)
--- PASS: TestAccMediaLiveChannel_status (294.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	297.335s

[johnsonaj]

@jonasdkhansen thanks for the contribution! 🎉

[github-actions]

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.