Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cognito_user_pool_domain: Allow update of certificate_arn in place #30066

Merged
merged 63 commits into from
Mar 16, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Removes ForceNew from certificate_arn.

Relations

Closes #25275.
Closes #14733.

Output from Acceptance Testing

% AWS_DEFAULT_REGION=us-east-1 ACM_CERTIFICATE_ROOT_DOMAIN=example.com make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolDomain_custom' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPUserPoolDomain_custom -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolDomain_custom
=== PAUSE TestAccCognitoIDPUserPoolDomain_custom
=== RUN   TestAccCognitoIDPUserPoolDomain_customCertUpdate
=== PAUSE TestAccCognitoIDPUserPoolDomain_customCertUpdate
=== CONT  TestAccCognitoIDPUserPoolDomain_custom
=== CONT  TestAccCognitoIDPUserPoolDomain_customCertUpdate
--- PASS: TestAccCognitoIDPUserPoolDomain_customCertUpdate (1041.87s)
--- PASS: TestAccCognitoIDPUserPoolDomain_custom (1044.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	1049.620s

austinvalle and others added 30 commits June 10, 2022 14:40
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cognitoidp Issues and PRs that pertain to the cognitoidp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Mar 16, 2023
@ewbankkit ewbankkit merged commit 9c90a19 into main Mar 16, 2023
@ewbankkit ewbankkit deleted the b-aws_cognito_user_pool_domain.certificate_arn.update branch March 16, 2023 17:22
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 16, 2023
github-actions bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow updating Cognito User Pool Domain Certificate ARN
3 participants