Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2_contact_list: new resource #30094

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Mar 17, 2023

Description

This PR adds the aws_sesv2_contact_list resource.

Relations

Relates #26796.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccSESV2ContactList_" PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2ContactList_ -timeout 180m
=== RUN   TestAccSESV2ContactList_basic
--- PASS: TestAccSESV2ContactList_basic (21.31s)
=== RUN   TestAccSESV2ContactList_description
--- PASS: TestAccSESV2ContactList_description (33.66s)
=== RUN   TestAccSESV2ContactList_topic
--- PASS: TestAccSESV2ContactList_topic (33.77s)
=== RUN   TestAccSESV2ContactList_tags
--- PASS: TestAccSESV2ContactList_tags (33.31s)
=== RUN   TestAccSESV2ContactList_disappears
--- PASS: TestAccSESV2ContactList_disappears (13.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      159.646s
$ SWEEPARGS=-sweep-run=aws_sesv2_contact_list make sweep             
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_sesv2_contact_list -timeout 60m
2023/03/17 18:16:43 [DEBUG] Running Sweepers for region (us-west-2):
2023/03/17 18:16:43 [DEBUG] Running Sweeper (aws_sesv2_contact_list) in region (us-west-2)
2023/03/17 18:16:45 [DEBUG] Completed Sweeper (aws_sesv2_contact_list) in region (us-west-2) in 1.789669125s
2023/03/17 18:16:45 Completed Sweepers for region (us-west-2) in 1.790234208s
2023/03/17 18:16:45 Sweeper Tests for region (us-west-2) ran successfully:
        - aws_sesv2_contact_list
2023/03/17 18:16:45 [DEBUG] Running Sweepers for region (us-east-1):
2023/03/17 18:16:45 [DEBUG] Running Sweeper (aws_sesv2_contact_list) in region (us-east-1)
2023/03/17 18:16:46 [DEBUG] Completed Sweeper (aws_sesv2_contact_list) in region (us-east-1) in 1.171899875s
2023/03/17 18:16:46 Completed Sweepers for region (us-east-1) in 1.171958875s
2023/03/17 18:16:46 Sweeper Tests for region (us-east-1) ran successfully:
        - aws_sesv2_contact_list
2023/03/17 18:16:46 [DEBUG] Running Sweepers for region (us-east-2):
2023/03/17 18:16:46 [DEBUG] Running Sweeper (aws_sesv2_contact_list) in region (us-east-2)
2023/03/17 18:16:47 [DEBUG] Completed Sweeper (aws_sesv2_contact_list) in region (us-east-2) in 1.295978834s
2023/03/17 18:16:47 Completed Sweepers for region (us-east-2) in 1.296028042s
2023/03/17 18:16:47 Sweeper Tests for region (us-east-2) ran successfully:
        - aws_sesv2_contact_list
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      27.642s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/sesv2 Issues and PRs that pertain to the sesv2 service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 17, 2023
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2023
@kamilturek kamilturek marked this pull request as ready for review March 17, 2023 17:48
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ContactList_' PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2ContactList_ -timeout 180m
=== RUN   TestAccSESV2ContactList_basic
--- PASS: TestAccSESV2ContactList_basic (23.23s)
=== RUN   TestAccSESV2ContactList_description
--- PASS: TestAccSESV2ContactList_description (34.70s)
=== RUN   TestAccSESV2ContactList_topic
--- PASS: TestAccSESV2ContactList_topic (37.61s)
=== RUN   TestAccSESV2ContactList_tags
--- PASS: TestAccSESV2ContactList_tags (34.42s)
=== RUN   TestAccSESV2ContactList_disappears
--- PASS: TestAccSESV2ContactList_disappears (14.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	154.276s

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Mar 17, 2023
@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c432930 into hashicorp:main Mar 17, 2023
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 17, 2023
@kamilturek kamilturek deleted the f-aws-sesv2-contact-list branch March 17, 2023 19:04
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants