Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/r/appautoscaling_policy: minor fix #3023

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Conversation

sjauld
Copy link
Contributor

@sjauld sjauld commented Jan 17, 2018

Metric aggregation type is optional, but displayed in the docs as required.

Metric aggregation type is optional, but displayed in the docs as required.
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, the other two (cooldown & adjustment_type) seem to be optional too. Do you mind send a PR for those?

Thanks.

@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Jan 17, 2018
@radeksimko radeksimko merged commit d0b1d7f into hashicorp:master Jan 17, 2018
@sjauld
Copy link
Contributor Author

sjauld commented Jan 17, 2018

The defaults for the other two aren't specified and I'm not sure what they are...

@sjauld sjauld deleted the patch-1 branch November 1, 2018 22:15
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants