r/aws_fsx_openzfs_file_system: add validation for disk_iops_configuration

[johnsonaj]

Description

Relations

Relates #30058

References

https://docs.aws.amazon.com/fsx/latest/OpenZFSGuide/performance.html

Output from Acceptance Testing

Test failure unrelated to change and is failing in CI. Looks like returned default values

$ make testacc PKG=fsx TESTS="TestAccFSxOpenzfsFileSystem_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenzfsFileSystem_'  -timeout 180m
=== NAME  TestAccFSxOpenzfsFileSystem_rootVolume
    openzfs_file_system_test.go:158: Step 1/5 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_fsx_openzfs_file_system.test will be updated in-place
          ~ resource "aws_fsx_openzfs_file_system" "test" {
                id                              = "fs-04bb6f5eef1347cb0"
                tags                            = {
                    "Name" = "tf-acc-test-7501247709983357905"
                }
                # (17 unchanged attributes hidden)

              ~ root_volume_configuration {
                    # (4 unchanged attributes hidden)

                  - user_and_group_quotas {
                      - id                         = 0 -> null
                      - storage_capacity_quota_gib = 0 -> null
                      - type                       = "GROUP" -> null
                    }
                  - user_and_group_quotas {
                      - id                         = 0 -> null
                      - storage_capacity_quota_gib = 0 -> null
                      - type                       = "USER" -> null
                    }

                    # (2 unchanged blocks hidden)
                }

                # (1 unchanged block hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccFSxOpenzfsFileSystem_kmsKeyID (789.62s)
--- FAIL: TestAccFSxOpenzfsFileSystem_rootVolume (807.35s)
--- PASS: TestAccFSxOpenzfsFileSystem_tags (828.18s)
--- PASS: TestAccFSxOpenzfsFileSystem_storageType (851.35s)
--- PASS: TestAccFSxOpenzfsFileSystem_copyTags (854.03s)
--- PASS: TestAccFSxOpenzfsFileSystem_disappears (859.60s)
--- PASS: TestAccFSxOpenzfsFileSystem_basic (872.99s)
--- PASS: TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime (894.69s)
--- PASS: TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime (907.20s)
--- PASS: TestAccFSxOpenzfsFileSystem_diskIops (916.09s)
--- PASS: TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays (993.66s)
--- PASS: TestAccFSxOpenzfsFileSystem_storageCapacity (995.48s)
--- PASS: TestAccFSxOpenzfsFileSystem_throughput (1395.39s)
--- PASS: TestAccFSxOpenzfsFileSystem_throughputCapacity (1431.99s)
--- PASS: TestAccFSxOpenzfsFileSystem_securityGroupIDs (1641.91s)
--- PASS: TestAccFSxOpenzfsFileSystem_deploymentType (1707.85s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1710.937s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

$ make testacc PKG=fsx TESTS="TestAccFSxOpenzfsFileSystem_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOpenzfsFileSystem_'  -timeout 180m

=== NAME  TestAccFSxOpenzfsFileSystem_rootVolume
    openzfs_file_system_test.go:158: Step 1/5 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_fsx_openzfs_file_system.test will be updated in-place
          ~ resource "aws_fsx_openzfs_file_system" "test" {
                id                              = "fs-0d8901615adbfec9f"
                tags                            = {
                    "Name" = "tf-acc-test-2232193390143736802"
                }
                # (17 unchanged attributes hidden)

              ~ root_volume_configuration {
                    # (4 unchanged attributes hidden)

                  - user_and_group_quotas {
                      - id                         = 0 -> null
                      - storage_capacity_quota_gib = 0 -> null
                      - type                       = "GROUP" -> null
                    }
                  - user_and_group_quotas {
                      - id                         = 0 -> null
                      - storage_capacity_quota_gib = 0 -> null
                      - type                       = "USER" -> null
                    }

                    # (2 unchanged blocks hidden)
                }

                # (1 unchanged block hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccFSxOpenzfsFileSystem_disappears (849.45s)
--- PASS: TestAccFSxOpenzfsFileSystem_basic (855.28s)
--- FAIL: TestAccFSxOpenzfsFileSystem_rootVolume (860.69s)
--- PASS: TestAccFSxOpenzfsFileSystem_storageType (864.13s)
--- PASS: TestAccFSxOpenzfsFileSystem_diskIops (880.09s)
--- PASS: TestAccFSxOpenzfsFileSystem_kmsKeyID (881.18s)
--- PASS: TestAccFSxOpenzfsFileSystem_tags (902.93s)
--- PASS: TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime (928.50s)
--- PASS: TestAccFSxOpenzfsFileSystem_copyTags (948.36s)
--- PASS: TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime (948.94s)
--- PASS: TestAccFSxOpenzfsFileSystem_storageCapacity (985.77s)
--- PASS: TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays (1007.29s)
--- PASS: TestAccFSxOpenzfsFileSystem_throughput (1465.07s)
--- PASS: TestAccFSxOpenzfsFileSystem_throughputCapacity (1506.10s)
--- PASS: TestAccFSxOpenzfsFileSystem_securityGroupIDs (1626.25s)
--- PASS: TestAccFSxOpenzfsFileSystem_deploymentType (1794.73s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/fsx        1798.154s
FAIL
make: *** [testacc] Error 1

[jar-b]

This might be worth a changelog entry to call out the changed validation (and note the bug).

[github-actions]

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.