resource/aws_instance: Retry IAM instance profile (re)association for eventual consistency on update #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… eventual consistency on update
bflad
added
bug
radeksimko
approved these changes
Jan 18, 2018
…2 minutes to 1 minute initially Generally we would prefer to surface actual IAM issues (bad profile, etc.) sooner rather than later.
|
Lowered the timeouts to 1 minute to follow our normal practice of preferring to bubble up actual issues sooner rather than later (since EC2 doesn't differentiate between missing vs actually bad here). Can always adjust later if eventual consistency here is really bad (its currently only 30 seconds on instance creation, so we're probably okay). 👍 |
|
This has been released in terraform-provider-aws version 1.7.1. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
drewsonne
pushed a commit
to drewsonne/terraform-provider-aws
that referenced
this pull request
Mar 3, 2018
amenonsen
added a commit
to 2ndQuadrant/ansible
that referenced
this pull request
Jul 15, 2018
Instance creation could fail with an error like this if the IAM instance
profile for the instance was created a short time before run_instances,
and had not yet propagated (which happened nearly every time on fast
networks):
"Instance creation failed => InvalidParameterValue: Value
(xxx_profile) for parameter iamInstanceProfile.name is invalid.
Invalid IAM Instance Profile name"
We modify ec2.py to use an "EC2Retry" wrapper that inherits from
CloudRetry and wraps run_instances, detects the InvalidParameterValue
exception with the 'iamInstanceProfile.name is invalid' message, and
retries that request a few times.
Incidentally, terraform has the same problem and used the same fix,
right up to using string matching on the error message to figure out
whether it's the right error or not:
hashicorp/terraform-provider-aws#3055
amenonsen
added a commit
to 2ndQuadrant/ansible
that referenced
this pull request
Jan 30, 2020
Instance creation could fail with an error like this if the IAM instance
profile for the instance was created a short time before run_instances,
and had not yet propagated (which happened nearly every time on fast
networks):
"Instance creation failed => InvalidParameterValue: Value
(xxx_profile) for parameter iamInstanceProfile.name is invalid.
Invalid IAM Instance Profile name"
We modify ec2.py to use an "EC2Retry" wrapper that inherits from
CloudRetry and wraps run_instances, detects the InvalidParameterValue
exception with the 'iamInstanceProfile.name is invalid' message, and
retries that request a few times.
Incidentally, terraform has the same problem and used the same fix,
right up to using string matching on the error message to figure out
whether it's the right error or not:
hashicorp/terraform-provider-aws#3055
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #838
Adjusting the existing test for adding
aws_instance.iam_instance_profileafter instance creation by simultaneously creating theaws_iam_instance_profileinstead generates the error reported:After code update (I'll replace with full results shortly):