Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource and Data source: aws_ssmincidents_response_plan #30665

Merged
merged 6 commits into from
Apr 24, 2023
Merged

New Resource and Data source: aws_ssmincidents_response_plan #30665

merged 6 commits into from
Apr 24, 2023

Conversation

pschun
Copy link
Contributor

@pschun pschun commented Apr 12, 2023 •
edited
Loading

Description

Support AWS Incident Manager Response Plan Resource and Data source.

References

https://docs.aws.amazon.com/incident-manager/latest/APIReference/API_CreateResponsePlan.html

Output from Acceptance Testing

make testacc TESTS=TestAccSSMIncidentsResponsePlan_serial PKG=ssmincidents
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmincidents/... -v -count 1 -parallel 20 -run='TestAccSSMIncidentsResponsePlan_serial'  -timeout 180m
=== RUN   TestAccSSMIncidentsResponsePlan_serial
=== PAUSE TestAccSSMIncidentsResponsePlan_serial
=== CONT  TestAccSSMIncidentsResponsePlan_serial
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateTags
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/incidentTemplateFields
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/engagement
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/action
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/basic
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateEmptyTags
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/disappears
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/displayName
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/chatChannel
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/update
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests/basic
=== PAUSE TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests/basic
=== CONT  TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests/basic
--- PASS: TestAccSSMIncidentsResponsePlan_serial (3988.78s)
    --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests (3656.48s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateTags (359.30s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/incidentTemplateFields (357.17s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/engagement (397.30s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/action (323.79s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/basic (348.14s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateEmptyTags (377.75s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/disappears (329.58s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/displayName (388.52s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/chatChannel (399.51s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/update (375.42s)
    --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests (0.00s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests/basic (332.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssmincidents       3993.618s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Apr 12, 2023
@pschun pschun force-pushed the f-ssmincidents-responseplan branch from dcd07fd to 13f8752 Compare April 12, 2023 02:16
@breathingdust breathingdust added new-resource Introduces a new resource. new-data-source Introduces a new data source. partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 12, 2023
@pschun pschun force-pushed the f-ssmincidents-responseplan branch from 74756b0 to 9b5a27b Compare April 12, 2023 23:32
@ewbankkit ewbankkit self-assigned this Apr 24, 2023
ewbankkit
ewbankkit approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccSSMIncidentsResponsePlan_serial' PKG=ssmincidents
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmincidents/... -v -count 1 -parallel 20  -run=TestAccSSMIncidentsResponsePlan_serial -timeout 360m
=== RUN   TestAccSSMIncidentsResponsePlan_serial
=== PAUSE TestAccSSMIncidentsResponsePlan_serial
=== CONT  TestAccSSMIncidentsResponsePlan_serial
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/update
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/disappears
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/incidentTemplateFields
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/engagement
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/basic
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateTags
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateEmptyTags
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/displayName
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/chatChannel
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/action
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests
=== RUN   TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests/basic
--- PASS: TestAccSSMIncidentsResponsePlan_serial (4065.24s)
    --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests (3677.97s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/update (358.87s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/disappears (501.64s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/incidentTemplateFields (342.17s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/engagement (371.26s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/basic (333.65s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateTags (346.80s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/updateEmptyTags (355.45s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/displayName (340.42s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/chatChannel (373.47s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Resource_Tests/action (354.24s)
    --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests (387.27s)
        --- PASS: TestAccSSMIncidentsResponsePlan_serial/Response_Plan_Data_Source_Tests/basic (387.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmincidents	4070.792s

@ewbankkit
Copy link
Contributor

@pschun Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3b2298e into hashicorp:main Apr 24, 2023
@github-actions github-actions bot added this to the v4.65.0 milestone Apr 24, 2023
@pschun pschun deleted the f-ssmincidents-responseplan branch April 25, 2023 23:13
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. new-resource Introduces a new resource. partner Contribution from a partner. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.65.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pschun @ewbankkit @breathingdust