Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_quicksight_namespace #30681

Merged
merged 6 commits into from
Apr 12, 2023
Merged

New Resource: aws_quicksight_namespace #30681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b58b3c0
r/aws_quicksight_namespace: resource implementation
jar-b Apr 12, 2023
3137b7a
internal/provider: switch read after tags interceptor to response state
jar-b Apr 12, 2023
1d883f0
r/aws_quicksight_namespace: tests
jar-b Apr 12, 2023
6edb601
r/aws_quicksight_namespace: docs
jar-b Apr 12, 2023
bb89ff2
[r|d]/quicksight: add missing name annotations
jar-b Apr 12, 2023
e7fcead
chore: changelog
jar-b Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/30681.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_quicksight_namespace
```
2 changes: 1 addition & 1 deletion internal/provider/fwprovider/intercept.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ func (r tagsInterceptor) read(ctx context.Context, request resource.ReadRequest,
if identifierAttribute := r.tags.IdentifierAttribute; identifierAttribute != "" {
var identifier string

diags.Append(request.State.GetAttribute(ctx, path.Root(identifierAttribute), &identifier)...)
diags.Append(response.State.GetAttribute(ctx, path.Root(identifierAttribute), &identifier)...)

if diags.HasError() {
return ctx, diags
Expand Down
2 changes: 1 addition & 1 deletion internal/service/quicksight/account_subscription.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
)

// Function annotations are used for resource registration to the Provider. DO NOT EDIT.
// @SDKResource("aws_quicksight_account_subscription")
// @SDKResource("aws_quicksight_account_subscription", name="Account Subscription")
func ResourceAccountSubscription() *schema.Resource {
return &schema.Resource{
CreateWithoutTimeout: resourceAccountSubscriptionCreate,
Expand Down
2 changes: 1 addition & 1 deletion internal/service/quicksight/data_set_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/names"
)

// @SDKDataSource("aws_quicksight_data_set")
// @SDKDataSource("aws_quicksight_data_set", name="Data Set")
func DataSourceDataSet() *schema.Resource {
return &schema.Resource{
ReadWithoutTimeout: dataSourceDataSetRead,
Expand Down
3 changes: 2 additions & 1 deletion internal/service/quicksight/exports_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package quicksight

// Exports for use in tests only.
var (
ResourceIngestion = newResourceIngestion
ResourceIAMPolicyAssignment = newResourceIAMPolicyAssignment
ResourceIngestion = newResourceIngestion
ResourceNamespace = newResourceNamespace
)
2 changes: 1 addition & 1 deletion internal/service/quicksight/group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
)

// @SDKResource("aws_quicksight_group")
// @SDKResource("aws_quicksight_group", name="Group")
func ResourceGroup() *schema.Resource {
return &schema.Resource{
CreateWithoutTimeout: resourceGroupCreate,
Expand Down
2 changes: 1 addition & 1 deletion internal/service/quicksight/group_membership.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/internal/conns"
)

// @SDKResource("aws_quicksight_group_membership")
// @SDKResource("aws_quicksight_group_membership", name="Group Membership")
func ResourceGroupMembership() *schema.Resource {
return &schema.Resource{
CreateWithoutTimeout: resourceGroupMembershipCreate,
Expand Down
4 changes: 2 additions & 2 deletions internal/service/quicksight/iam_policy_assignment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ import (
"github.com/hashicorp/terraform-provider-aws/names"
)

// @FrameworkResource
// @FrameworkResource(name="IAM Policy Assignment")
func newResourceIAMPolicyAssignment(_ context.Context) (resource.ResourceWithConfigure, error) {
return &resourceIAMPolicyAssignment{}, nil
}

const (
ResNameIAMPolicyAssignment = "IAMPolicyAssignment"
ResNameIAMPolicyAssignment = "IAM Policy Assignment"

DefaultIAMPolicyAssignmentNamespace = "default"
iamPropagationTimeout = 2 * time.Minute
Expand Down
2 changes: 1 addition & 1 deletion internal/service/quicksight/ingestion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
"github.com/hashicorp/terraform-provider-aws/names"
)

// @FrameworkResource
// @FrameworkResource(name="Ingestion")
func newResourceIngestion(_ context.Context) (resource.ResourceWithConfigure, error) {
return &resourceIngestion{}, nil
}
Expand Down
Loading