Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dx_gateway: Remove name argument validation #30739

Merged
merged 2 commits into from
Apr 14, 2023
Merged

r/aws_dx_gateway: Remove name argument validation #30739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6c7c85
r/aws_dx_gateway: Remove 'name' argument validation.
ewbankkit Apr 14, 2023
c13b109
Add CHANGELOG entry.
ewbankkit Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/30739.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_dx_gateway: Remove plan time validation from `name` argument
```
7 changes: 2 additions & 5 deletions internal/service/directconnect/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package directconnect
import (
"context"
"log"
"regexp"
"strconv"
"time"

Expand All @@ -12,7 +11,6 @@ import (
"github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
"github.com/hashicorp/terraform-provider-aws/internal/conns"
"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
"github.com/hashicorp/terraform-provider-aws/internal/tfresource"
Expand All @@ -39,9 +37,8 @@ func ResourceGateway() *schema.Resource {
ValidateFunc: verify.ValidAmazonSideASN,
},
"name": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringMatch(regexp.MustCompile(`^[a-z0-9-]{1,100}$`), "Name must contain no more than 100 characters. Valid characters are a-z, 0-9, and hyphens (–)."),
Type: schema.TypeString,
Required: true,
},
"owner_account_id": {
Type: schema.TypeString,
Expand Down