Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trail arn instead of name to get organization trails from a delegated account #30758

Merged
merged 18 commits into from
Nov 6, 2023
Merged

Use trail arn instead of name to get organization trails from a delegated account #30758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
36ad1ac
fix: use trail arn instead of name to get organization trails from a …
sbldevnet Apr 16, 2023
c791d08
add changelog
sbldevnet Apr 16, 2023
2f074b7
fix: restrict S3 policy in tests to avoid error if the account has e…
sbldevnet Apr 18, 2023
be71d06
docs: update basic example iam policy to avoid confused deputy securi…
sbldevnet Apr 18, 2023
e115718
docs: adding in basic example to avoid race condition
sbldevnet Apr 18, 2023
1aecf9d
Merge branch 'main' into b-aws_cloudtrail-fix-delegated-trail
sbldevnet Jun 9, 2023
dd00eea
Merge branch 'main' into b-aws_cloudtrail-fix-delegated-trail
sbldevnet Jul 19, 2023
58530ec
Merge branch 'main' into b-aws_cloudtrail-fix-delegated-trail
sbldevnet Jul 24, 2023
228b91c
Merge branch 'main' into HEAD
ewbankkit Nov 3, 2023
3dca691
r/aws_cloudtrail: Tidy up Create.
ewbankkit Nov 5, 2023
beaa29d
r/aws_cloudtrail: Tidy up Delete.
ewbankkit Nov 5, 2023
da4032a
r/aws_cloudtrail: Tidy up Update.
ewbankkit Nov 5, 2023
813b75b
r/aws_cloudtrail: Tidy up Read.
ewbankkit Nov 5, 2023
76f279a
r/aws_cloudtrail: Simplify findTrail(s).
ewbankkit Nov 6, 2023
7c0347b
r/aws_cloudtrail: Document that 'id changes from trail name to its ARN.
ewbankkit Nov 6, 2023
f8a24a0
r/aws_cloudtrail: Add StateUpgrader for 'id'.
ewbankkit Nov 6, 2023
f268cf1
r/aws_cloudtrail: Tidy up acceptance tests.
ewbankkit Nov 6, 2023
61d3bb6
Fix semgrep 'ci.cloudtrail-in-func-name '.
ewbankkit Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/30758.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:bug
resource/aws_cloudtrail: Change the `id` attribute from the trail's name to its ARN to support [organization trails](https://docs.aws.amazon.com/awscloudtrail/latest/userguide/creating-trail-organization.html)
```

```release-note:note
resource/aws_cloudtrail: The resource's [import ID](https://developer.hashicorp.com/terraform/language/import#import-id) has changed from `name` to `arn`
```
Loading
Loading