vpc/route/route_table: Remove instance_id #30804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/M
jar-b
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
LGTM 🎉
$ make testacc PKG=ec2 TESTS=TestAccVPCRoute_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRoute_' -timeout 180m
--- PASS: TestAccVPCRoute_localRoute (25.43s)
=== CONT TestAccVPCRoute_prefixListToInstance
--- PASS: TestAccVPCRoute_basic (27.27s)
=== CONT TestAccVPCRoute_ipv4ToVPCPeeringConnection
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_unattached (30.91s)
=== CONT TestAccVPCRoute_ipv4ToNatGateway
--- PASS: TestAccVPCRoute_prefixListToInternetGateway (33.71s)
=== CONT TestAccVPCRoute_IPv4ToNetworkInterface_twoAttachments
--- PASS: TestAccVPCRoute_prefixListToVPCPeeringConnection (32.89s)
=== CONT TestAccVPCRoute_ipv6ToLocalGateway
acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_ipv6ToLocalGateway (0.20s)
=== CONT TestAccVPCRoute_IPv6ToNetworkInterface_unattached
--- PASS: TestAccVPCRoute_PrefixListToNetworkInterface_unattached (36.79s)
=== CONT TestAccVPCRoute_ipv4ToInstance
=== CONT TestAccVPCRoute_ipv4ToVPNGateway
--- PASS: TestAccVPCRoute_prefixListToEgressOnlyInternetGateway (43.77s)
--- PASS: TestAccVPCRoute_ipv4ToVPCPeeringConnection (20.09s)
=== CONT TestAccVPCRoute_ipv6ToVPNGateway
--- PASS: TestAccVPCRoute_conditionalCIDRBlock (49.67s)
=== CONT TestAccVPCRoute_ipv6ToVPCPeeringConnection
--- PASS: TestAccVPCRoute_localRouteUpdate (54.00s)
=== CONT TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccVPCRoute_IPv6ToNetworkInterface_unattached (34.50s)
=== CONT TestAccVPCRoute_ipv6ToInstance
--- PASS: TestAccVPCRoute_PrefixListToNetworkInterface_attached (75.65s)
=== CONT TestAccVPCRoute_ipv6ToInternetGateway
--- PASS: TestAccVPCRoute_ipv6ToVPCPeeringConnection (30.59s)
=== CONT TestAccVPCRoute_IPv4ToNetworkInterface_attached
--- PASS: TestAccVPCRoute_prefixListToVPNGateway (86.58s)
=== CONT TestAccVPCRoute_Disappears_routeTable
--- PASS: TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway (38.50s)
=== CONT TestAccVPCRoute_disappears
--- PASS: TestAccVPCRoute_Disappears_routeTable (18.46s)
=== CONT TestAccVPCRoute_doesNotCrashWithVPCEndpoint
--- PASS: TestAccVPCRoute_ipv6ToInternetGateway (30.96s)
--- PASS: TestAccVPCRoute_disappears (18.21s)
--- PASS: TestAccVPCRoute_doesNotCrashWithVPCEndpoint (31.81s)
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_twoAttachments (109.98s)
--- PASS: TestAccVPCRoute_ipv6ToVPNGateway (99.02s)
=== NAME TestAccVPCRoute_ipv6ToVPCEndpoint
vpc_route_test.go:1532: Step 1/2 error: Error running apply: exit status 1
Error: modifying EC2 VPC Endpoint Service (vpce-svc-0f2c959cea26aee94) permissions: InvalidPrincipal: Invalid Principal: '<redacted>'
status code: 400, request id: 01cb1657-1bcb-48ef-8c8c-45c25caae71e
with aws_vpc_endpoint_service.test,
on terraform_plugin_test.tf line 40, in resource "aws_vpc_endpoint_service" "test":
40: resource "aws_vpc_endpoint_service" "test" {
--- PASS: TestAccVPCRoute_ipv4ToVPNGateway (110.06s)
=== NAME TestAccVPCRoute_ipv4ToVPCEndpoint
vpc_route_test.go:1481: Step 1/2 error: Error running apply: exit status 1
Error: modifying EC2 VPC Endpoint Service (vpce-svc-03933621d62ee7634) permissions: InvalidPrincipal: Invalid Principal: '<redacted>'
status code: 400, request id: 4a154cb5-f11a-402c-9805-f3de8d3d3294
with aws_vpc_endpoint_service.test,
on terraform_plugin_test.tf line 40, in resource "aws_vpc_endpoint_service" "test":
40: resource "aws_vpc_endpoint_service" "test" {
=== NAME TestAccVPCRoute_IPv4Update_target
vpc_route_test.go:1144: Step 1/8 error: Error running apply: exit status 1
Error: modifying EC2 VPC Endpoint Service (vpce-svc-0e587b6cdfa575b83) permissions: InvalidPrincipal: Invalid Principal: '<redacted>'
status code: 400, request id: 12a6d952-6162-4fc7-a839-058651c918c8
with aws_vpc_endpoint_service.test,
on terraform_plugin_test.tf line 165, in resource "aws_vpc_endpoint_service" "test":
165: resource "aws_vpc_endpoint_service" "test" {
--- FAIL: TestAccVPCRoute_ipv6ToVPCEndpoint (178.55s)
--- PASS: TestAccVPCRoute_IPv6Update_target (182.65s)
--- PASS: TestAccVPCRoute_prefixListToNatGateway (185.21s)
--- FAIL: TestAccVPCRoute_ipv4ToVPCEndpoint (189.88s)
--- PASS: TestAccVPCRoute_ipv6ToNatGateway (194.33s)
--- PASS: TestAccVPCRoute_ipv4ToNatGateway (207.47s)
--- PASS: TestAccVPCRoute_ipv4ToTransitGateway (313.25s)
--- FAIL: TestAccVPCRoute_IPv4Update_target (314.33s)
--- PASS: TestAccVPCRoute_ipv6ToTransitGateway (314.43s)
--- PASS: TestAccVPCRoute_prefixListToTransitGateway (314.82s)
--- PASS: TestAccVPCRoute_prefixListToInstance (301.81s)
--- PASS: TestAccVPCRoute_ipv4ToInstance (300.99s)
--- PASS: TestAccVPCRoute_ipv6ToInstance (313.41s)
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_attached (302.96s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 387.649s
FAIL
make: *** [testacc] Error 1Failures appear unrelated to this change.
github-actions
bot
added
size/L
YakDriver
added
the
breaking-change
Closed
YakDriver
pushed a commit
that referenced
this pull request
Apr 20, 2023
Merged
YakDriver
pushed a commit
that referenced
this pull request
Apr 20, 2023
|
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
YakDriver
pushed a commit
that referenced
this pull request
Apr 21, 2023
YakDriver
pushed a commit
that referenced
this pull request
Apr 21, 2023
This was referenced Apr 21, 2023
This was referenced May 23, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Closes #14197.
Closes #1426.
Relates #22664.
References
Output from Acceptance Testing
(Failures unrelated to current changes.)