Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_redshift_service_account: Deprecate #31006

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Deprecates the aws_redshift_service_account data source.

Relations

Closes #29346.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRedshiftCluster_loggingEnabled$$\|TestAccRedshiftClusterDataSource_logging$$' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftCluster_loggingEnabled$\|TestAccRedshiftClusterDataSource_logging$ -timeout 180m
=== RUN   TestAccRedshiftClusterDataSource_logging
=== PAUSE TestAccRedshiftClusterDataSource_logging
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== CONT  TestAccRedshiftClusterDataSource_logging
=== CONT  TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftClusterDataSource_logging (328.87s)
--- PASS: TestAccRedshiftCluster_loggingEnabled (661.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	666.631s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 26, 2023
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Apr 26, 2023
@ewbankkit ewbankkit added this to the v5.0.0 milestone Apr 26, 2023
@ewbankkit ewbankkit merged commit 74a2a07 into prerelease/5.x Apr 26, 2023
@ewbankkit ewbankkit deleted the f-deprecate-aws_redshift_service_account branch April 26, 2023 21:31
@github-actions github-actions bot modified the milestones: v5.0.0, v4.65.0 Apr 26, 2023
github-actions bot pushed a commit that referenced this pull request Apr 26, 2023
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/redshift Issues and PRs that pertain to the redshift service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant