Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_rds_cluster_instance: PerformanceInsightsKMSKeyId is not necessarily an ARN #3102

Closed
wants to merge 4 commits into from
Closed

resource/aws_rds_cluster_instance: PerformanceInsightsKMSKeyId is not necessarily an ARN #3102

wants to merge 4 commits into from

Commits on Jan 23, 2018

  1. According to the CreateDBInstance documentation, the parameter Perfor… 

    …manceInsightsKMSKeyId can be either a KMS key ARN, a KMS alias ARN or simply a KMS key ID.

In most cases, I would expect people to rely on either the KMS alias ARN or the key ARN, but because of the way data.aws_kms_key works, some users might end up with a raw key ID (not the ARN).

In this case the cluster instance creation will fail as the validation ensures that the performance_insights_kms_key_id is an ARN.

As a side note, the terraform documentation also mentions that we expect "The ARN for the KMS key to encrypt Performance Insights data.", it is probably worth specifying that an ARN to an alias is perfectly fine as well.

Fixing #3014
    Quentin Rousseau committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    adf39d1 View commit details
    Browse the repository at this point in the history

  2. Improve documentation

    Quentin Rousseau committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    eb52037 View commit details
    Browse the repository at this point in the history

  3. Lint

    @kwent
    kwent committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    bdf9653 View commit details
    Browse the repository at this point in the history

  4. make fmt

    @kwent
    kwent committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    ed8cd2d View commit details
    Browse the repository at this point in the history