Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/aws_mq_broker: Add dependency on IGW #3106

Merged
merged 1 commit into from
Jan 23, 2018
Merged

test/aws_mq_broker: Add dependency on IGW #3106

merged 1 commit into from
Jan 23, 2018

Conversation

radeksimko
Copy link
Member

This is to address the following test failure:

=== RUN   TestAccAwsMqBroker_allFieldsCustomVpc
--- FAIL: TestAccAwsMqBroker_allFieldsCustomVpc (177.28s)
    testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_mq_broker.test: 1 error(s) occurred:
        
        * aws_mq_broker.test: BadRequestException: The VPC associated with the provided subnets must have an available internet gateway attachment.
            status code: 400, request id: e53c0111-0018-11e8-ad33-07f096e8eb22

Test results

=== RUN   TestAccAwsMqBroker_allFieldsCustomVpc
--- PASS: TestAccAwsMqBroker_allFieldsCustomVpc (2339.20s)

@radeksimko radeksimko added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mq Issues and PRs that pertain to the mq service. labels Jan 23, 2018
@bflad bflad self-requested a review January 23, 2018 14:52
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I assume we just need the IGW to exist in the VPC and not associated with the subnets or anything via the route table association.

make testacc TEST=./aws TESTARGS='-run=TestAccAwsMqBroker_allFieldsCustomVpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAwsMqBroker_allFieldsCustomVpc -timeout 120m
=== RUN   TestAccAwsMqBroker_allFieldsCustomVpc
--- PASS: TestAccAwsMqBroker_allFieldsCustomVpc (1894.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1894.747s

@bflad bflad merged commit 3284077 into master Jan 23, 2018
@bflad bflad deleted the t-mq-igw-dep branch January 23, 2018 15:36
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/mq Issues and PRs that pertain to the mq service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants