Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ServiceCatalog Provisioned Product product_name update test until v5 #31115

Merged
merged 1 commit into from
May 2, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented May 2, 2023

Description

#31094 fixed a bug and introduced a new test for updating the product_name of provisioned products. As part of reviewing #26371 (a similar bug fix for the provisioned_artifact_name attribute), it was uncovered that the test added for product name updates was only passing due to the (now fixed) provisioned artifact name bug.

The underlying cause is that updating a products provisioning_artifact_parameters isn't correctly triggering a destroy and replace, causing data source used for the path_id attribute to provide outdated values on update. This will be fixed in v5.0.0 (via #31061), but in the short term this test will be disabled to allow the provisioned product test suite to pass. After v5.0.0 is released, this can be re-enabled.

Relations

Relates #31094
Relates #26371
Relates #31061

Output from Acceptance Testing

$ make testacc PKG=servicecatalog TESTS=TestAccServiceCatalogProvisionedProduct_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct_'  -timeout 180m

--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnCreate (52.76s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (131.05s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (133.72s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (221.51s)
--- PASS: TestAccServiceCatalogProvisionedProduct_ProvisioningArtifactName_update (222.18s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (224.19s)
--- PASS: TestAccServiceCatalogProvisionedProduct_computedOutputs (240.81s)
--- PASS: TestAccServiceCatalogProvisionedProduct_errorOnUpdate (261.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     264.966s

@github-actions
Copy link

github-actions bot commented May 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels May 2, 2023
@jar-b jar-b added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels May 2, 2023
@jar-b jar-b merged commit 5b95152 into main May 2, 2023
@jar-b jar-b deleted the td-disable-v5-dep-test branch May 2, 2023 19:40
@github-actions github-actions bot added this to the v4.66.0 milestone May 2, 2023
github-actions bot pushed a commit that referenced this pull request May 2, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this pull request May 31, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant