resource/aws_sqs_queue: Retry queue creation on QueueDeletedRecently error

[bflad]

Closes #831

Failing test before implementation:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_queueDeletedRecently'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSQSQueue_queueDeletedRecently -timeout 120m
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
--- FAIL: TestAccAWSSQSQueue_queueDeletedRecently (14.98s)
	testing.go:513: Step 2 error: Error applying: 1 error(s) occurred:

		* aws_sqs_queue.queue: 1 error(s) occurred:

		* aws_sqs_queue.queue: Error creating SQS queue: AWS.SimpleQueueService.QueueDeletedRecently: You must wait 60 seconds after deleting a queue before you can create another with the same name.
			status code: 400, request id: 8f81b2fe-c49a-5819-abb2-e01f98ce0b03
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	15.024s
make: *** [testacc] Error 1

Passing test after implementation:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_queueDeletedRecently'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSQSQueue_queueDeletedRecently -timeout 120m
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (83.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	83.572s

[radeksimko]

Nitpick, but I'd perhaps loosen the match here a little bit, just in case they raise the limit from 60 secs, i.e.

after deleting a queue before you can create another with the same name.

or maybe even

You must wait

[bflad]

If they change the limit, then we should adjust our retry threshold to match it. Our daily acceptance testing will start failing since this conditional will always return a NonRetryableError

[radeksimko]

Ah, very good point 👌 - ignore me then! 😅

[bflad]

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!