New Resource: aws_quicksight_vpc_connection

[g-dx]

Description

This PR adds a new aws_quicksight_vpc_connection resource, allowing practitioners to manage QuickSight VPC connections via Terraform.

Relations

Closes #31281
Relates To #10990

References

Announcement: https://aws.amazon.com/about-aws/whats-new/2023/05/amazon-quicksight-vpc-public-apis-multi-az-support/

• https://docs.aws.amazon.com/quicksight/latest/APIReference/API_CreateVPCConnection.html
• https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DeleteVPCConnection.html
• https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeVPCConnection.html
• https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateVPCConnection.html
• https://docs.aws.amazon.com/quicksight/latest/APIReference/API_ListVPCConnections.html

Output from Acceptance Testing

$ make testacc PKG=quicksight TESTS=TestAccQuickSightVPCConnection_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightVPCConnection_'  -timeout 180m
?   	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema	[no test files]
=== RUN   TestAccQuickSightVPCConnection_basic
=== PAUSE TestAccQuickSightVPCConnection_basic
=== RUN   TestAccQuickSightVPCConnection_disappears
=== PAUSE TestAccQuickSightVPCConnection_disappears
=== RUN   TestAccQuickSightVPCConnection_tags
=== PAUSE TestAccQuickSightVPCConnection_tags
=== CONT  TestAccQuickSightVPCConnection_basic
=== CONT  TestAccQuickSightVPCConnection_tags
=== CONT  TestAccQuickSightVPCConnection_disappears
--- PASS: TestAccQuickSightVPCConnection_disappears (158.50s)
--- PASS: TestAccQuickSightVPCConnection_basic (162.16s)
--- PASS: TestAccQuickSightVPCConnection_tags (216.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	216.134s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[g-dx]

Hey @jar-b 👋

This PR is ready to review. All checks & tests do actually pass, just not every time due to the Github actions failing without any error message for some reason.

[g-dx]

Ah, now I understand why. There's an ongoing incident:

https://www.githubstatus.com/incidents/pr3498h3qkfy

[jar-b]

LGTM 👍

$ make testacc PKG=quicksight TESTS=TestAccQuickSightVPCConnection_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightVPCConnection_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightVPCConnection_disappears (140.89s)
--- PASS: TestAccQuickSightVPCConnection_basic (159.18s)
--- PASS: TestAccQuickSightVPCConnection_tags (203.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 206.665s

[jar-b]

Thanks for your contribution, @g-dx! 🎸

[github-actions]

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.