-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added managed execution config to stacksets #31400
Added managed execution config to stacksets #31400
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudFormationStackSet_' PKG=cloudformation ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 3 -run=TestAccCloudFormationStackSet_ -timeout 180m
=== RUN TestAccCloudFormationStackSet_basic
=== PAUSE TestAccCloudFormationStackSet_basic
=== RUN TestAccCloudFormationStackSet_disappears
=== PAUSE TestAccCloudFormationStackSet_disappears
=== RUN TestAccCloudFormationStackSet_administrationRoleARN
=== PAUSE TestAccCloudFormationStackSet_administrationRoleARN
=== RUN TestAccCloudFormationStackSet_description
=== PAUSE TestAccCloudFormationStackSet_description
=== RUN TestAccCloudFormationStackSet_executionRoleName
=== PAUSE TestAccCloudFormationStackSet_executionRoleName
=== RUN TestAccCloudFormationStackSet_managedExecution
=== PAUSE TestAccCloudFormationStackSet_managedExecution
=== RUN TestAccCloudFormationStackSet_name
=== PAUSE TestAccCloudFormationStackSet_name
=== RUN TestAccCloudFormationStackSet_operationPreferences
=== PAUSE TestAccCloudFormationStackSet_operationPreferences
=== RUN TestAccCloudFormationStackSet_parameters
=== PAUSE TestAccCloudFormationStackSet_parameters
=== RUN TestAccCloudFormationStackSet_Parameters_default
acctest.go:78: this resource does not currently ignore unconfigured CloudFormation template parameters with the Default property
--- SKIP: TestAccCloudFormationStackSet_Parameters_default (0.00s)
=== RUN TestAccCloudFormationStackSet_Parameters_noEcho
acctest.go:78: this resource does not currently ignore CloudFormation template parameters with the NoEcho property
--- SKIP: TestAccCloudFormationStackSet_Parameters_noEcho (0.00s)
=== RUN TestAccCloudFormationStackSet_PermissionModel_serviceManaged
acctest.go:78: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccCloudFormationStackSet_PermissionModel_serviceManaged (0.00s)
=== RUN TestAccCloudFormationStackSet_tags
=== PAUSE TestAccCloudFormationStackSet_tags
=== RUN TestAccCloudFormationStackSet_templateBody
=== PAUSE TestAccCloudFormationStackSet_templateBody
=== RUN TestAccCloudFormationStackSet_templateURL
=== PAUSE TestAccCloudFormationStackSet_templateURL
=== CONT TestAccCloudFormationStackSet_basic
=== CONT TestAccCloudFormationStackSet_name
=== CONT TestAccCloudFormationStackSet_description
--- PASS: TestAccCloudFormationStackSet_basic (24.83s)
=== CONT TestAccCloudFormationStackSet_tags
--- PASS: TestAccCloudFormationStackSet_name (44.68s)
=== CONT TestAccCloudFormationStackSet_templateURL
--- PASS: TestAccCloudFormationStackSet_description (46.46s)
=== CONT TestAccCloudFormationStackSet_templateBody
--- PASS: TestAccCloudFormationStackSet_templateBody (46.16s)
=== CONT TestAccCloudFormationStackSet_parameters
--- PASS: TestAccCloudFormationStackSet_tags (68.48s)
=== CONT TestAccCloudFormationStackSet_managedExecution
--- PASS: TestAccCloudFormationStackSet_templateURL (58.14s)
=== CONT TestAccCloudFormationStackSet_operationPreferences
--- PASS: TestAccCloudFormationStackSet_managedExecution (23.49s)
=== CONT TestAccCloudFormationStackSet_executionRoleName
--- PASS: TestAccCloudFormationStackSet_executionRoleName (44.15s)
=== CONT TestAccCloudFormationStackSet_administrationRoleARN
--- PASS: TestAccCloudFormationStackSet_parameters (87.27s)
=== CONT TestAccCloudFormationStackSet_disappears
--- PASS: TestAccCloudFormationStackSet_disappears (18.28s)
--- PASS: TestAccCloudFormationStackSet_administrationRoleARN (42.71s)
--- PASS: TestAccCloudFormationStackSet_operationPreferences (127.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 235.275s
@meetreks Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Added managed execution to resource aws_cloudformation_stack_set.
Relations
Closes #25210
References
Output from Acceptance Testing