Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_autoscaling_policy: Support ec2 autoscaling TargetTrackingScaling policy #3160

Closed

Conversation

krrrr38
Copy link

@krrrr38 krrrr38 commented Jan 27, 2018

close #1156

> TF_ACC=1 go test ./aws -v -run=TestAccAWSAutoscalingPolicy -timeout 120m
=== RUN   TestAccAWSAutoscalingPolicy_basic
--- PASS: TestAccAWSAutoscalingPolicy_basic (205.29s)
=== RUN   TestAccAWSAutoscalingPolicy_disappears
--- PASS: TestAccAWSAutoscalingPolicy_disappears (211.57s)
=== RUN   TestAccAWSAutoscalingPolicy_upgrade
--- PASS: TestAccAWSAutoscalingPolicy_upgrade (243.48s)
=== RUN   TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment
--- PASS: TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment (89.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       749.468s
  • Acceptance test coverage of new behavior
  • Documentation updates
  • Well-formed Code
  • Vendor additions

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Jan 27, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Jan 28, 2018
@krrrr38
Copy link
Author

krrrr38 commented Jan 28, 2018

oops, this pr duplicate #2611. sorry close this one.

@krrrr38 krrrr38 closed this Jan 28, 2018
@krrrr38 krrrr38 deleted the ec2-target-tracking-scaling branch January 28, 2018 06:05
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Target Tracking Policies in EC2 Auto Scaling
2 participants