Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure endpoint group weight 0 is taken into account #31767

Merged
merged 3 commits into from
Jun 5, 2023
Merged

fix: ensure endpoint group weight 0 is taken into account #31767

merged 3 commits into from
Jun 5, 2023

Commits on Jun 5, 2023

  1. fix: ensure endpoint group weight 0 is taken into account 

    Zero is a valid value for an endpoint group configuration and
it shouldn't be ignored and not sent to the API.

The current behaviour causes a endpoint weight of 128 to be used
instead as it is AWS default value if no weight is set.
This causes traffic to be sent despite the expectations that
a zero value will cause no traffic on the endpoint.
    @yannrouillard
    yannrouillard committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3e53b80 View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry file.

    @ewbankkit
    ewbankkit committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    1816993 View commit details
    Browse the repository at this point in the history

  3. TestAccGlobalAcceleratorEndpointGroup_ALBEndpoint_clientIP: Test upda… 

    …ting 'endpoint_configuration.weight' to '0'.
    @ewbankkit
    ewbankkit committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    0e70f6c View commit details
    Browse the repository at this point in the history