Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_finspace_kx_environment #31802

Merged
merged 23 commits into from
Jun 8, 2023

Conversation

kavan-aws
Copy link
Contributor

Description

This pull request introduces the finspace_kx_environment resource, along with its associated tests and documentation. This is one component of four new resources being introduced to enable terraform support for FinSpace Managed kdb.

Relations

Relates #22658

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKxEnvironment PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxEnvironment'  -timeout 180m
=== RUN   TestAccFinSpaceKxEnvironment_basic
=== PAUSE TestAccFinSpaceKxEnvironment_basic
=== RUN   TestAccFinSpaceKxEnvironment_updateName
=== PAUSE TestAccFinSpaceKxEnvironment_updateName
=== RUN   TestAccFinSpaceKxEnvironment_description
=== PAUSE TestAccFinSpaceKxEnvironment_description
=== RUN   TestAccFinSpaceKxEnvironment_customDNS
=== PAUSE TestAccFinSpaceKxEnvironment_customDNS
=== RUN   TestAccFinSpaceKxEnvironment_transitGateway
=== PAUSE TestAccFinSpaceKxEnvironment_transitGateway
=== CONT  TestAccFinSpaceKxEnvironment_basic
=== CONT  TestAccFinSpaceKxEnvironment_updateName
=== CONT  TestAccFinSpaceKxEnvironment_transitGateway
=== CONT  TestAccFinSpaceKxEnvironment_customDNS
=== CONT  TestAccFinSpaceKxEnvironment_description
--- PASS: TestAccFinSpaceKxEnvironment_basic (1286.07s)
--- PASS: TestAccFinSpaceKxEnvironment_updateName (1333.31s)
--- PASS: TestAccFinSpaceKxEnvironment_description (1383.02s)
--- PASS: TestAccFinSpaceKxEnvironment_customDNS (1919.63s)
--- PASS: TestAccFinSpaceKxEnvironment_transitGateway (2042.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	2066.832s
...

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2023
@kavan-aws
Copy link
Contributor Author

_disappears and _tags acceptance test output not shown above since still working through some test issues for those two brought about by switch to transparent tagging, as discussed with @jar-b.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @kavan-aws 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@jar-b jar-b added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2023
@jar-b jar-b self-assigned this Jun 6, 2023
@github-actions github-actions bot added the tags Pertains to resource tagging. label Jun 7, 2023
kavan-aws and others added 3 commits June 7, 2023 16:26
this workaround avoids a confirmed bug in the CreateKxEnvironment API
which does not properly apply tags when sent in the create request
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=finspace TESTS=TestAccFinSpaceKxEnvironment_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxEnvironment_'  -timeout 180m

--- PASS: TestAccFinSpaceKxEnvironment_disappears (1063.94s)
--- PASS: TestAccFinSpaceKxEnvironment_basic (1083.38s)
--- PASS: TestAccFinSpaceKxEnvironment_tags (1098.44s)
--- PASS: TestAccFinSpaceKxEnvironment_updateName (1110.38s)
--- PASS: TestAccFinSpaceKxEnvironment_description (1124.45s)
--- PASS: TestAccFinSpaceKxEnvironment_customDNS (1678.70s)
--- PASS: TestAccFinSpaceKxEnvironment_transitGateway (1762.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1765.527s

@jar-b jar-b changed the title F finspace kx environment [New Resource]: aws_finspace_kx_environment Jun 8, 2023
@jar-b jar-b merged commit a805be5 into hashicorp:main Jun 8, 2023
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 8, 2023
@jar-b
Copy link
Member

jar-b commented Jun 8, 2023

Thanks for your contribution, @kavan-aws! 👏

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants