Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_finspace_kx_user #31804

Merged
merged 31 commits into from
Jun 8, 2023
Merged

Conversation

kavan-aws
Copy link
Contributor

@kavan-aws kavan-aws commented Jun 6, 2023

Description

This pull request introduces the finspace_kx_user resource, along with its associated tests and documentation. This is one component of four new resources being introduced to enable terraform support for FinSpace Managed kdb.

Relations

Relates #22658

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKxUser PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxUser_basic'  -timeout 180m
=== RUN   TestAccFinSpaceKxUser_basic
=== PAUSE TestAccFinSpaceKxUser_basic
=== CONT  TestAccFinSpaceKxUser_basic
--- PASS: TestAccFinSpaceKxUser_basic (976.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	1001.324s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxUser'  -timeout 180m
=== RUN   TestAccFinSpaceKxUser_disappears
=== PAUSE TestAccFinSpaceKxUser_disappears
=== RUN   TestAccFinSpaceKxUser_updateRole
=== PAUSE TestAccFinSpaceKxUser_updateRole
=== CONT  TestAccFinSpaceKxUser_disappears
=== CONT  TestAccFinSpaceKxUser_updateRole
--- PASS: TestAccFinSpaceKxUser_updateRole (929.32s)
--- PASS: TestAccFinSpaceKxUser_disappears (937.25s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	961.485s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxUser_tags'  -timeout 180m
=== RUN   TestAccFinSpaceKxUser_tags
=== PAUSE TestAccFinSpaceKxUser_tags
=== CONT  TestAccFinSpaceKxUser_tags
--- PASS: TestAccFinSpaceKxUser_tags (845.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	870.416s
...

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2023
@kavan-aws
Copy link
Contributor Author

kavan-aws commented Jun 6, 2023

_tags acceptance test output not shown above since still working through some test issues brought about by switch to transparent tagging, as discussed with @jar-b. Tags count is showing one less than it should (0 instead of 1 or 1 instead of 2). Edit: Resolved

@jar-b jar-b added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 7, 2023
@jar-b jar-b changed the title F finspace kx user [New Resource]: aws_finspace_kx_user Jun 8, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=finspace TESTS=TestAccFinSpaceKxUser_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxUser_'  -timeout 180m

--- PASS: TestAccFinSpaceKxUser_updateRole (1217.63s)
--- PASS: TestAccFinSpaceKxUser_tags (1258.14s)
--- PASS: TestAccFinSpaceKxUser_disappears (1359.83s)
--- PASS: TestAccFinSpaceKxUser_basic (1564.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1567.513s

@jar-b jar-b merged commit e37e301 into hashicorp:main Jun 8, 2023
@jar-b
Copy link
Member

jar-b commented Jun 8, 2023

Thanks for your contribution, @kavan-aws! 🎸

@github-actions github-actions bot added this to the v5.2.0 milestone Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants