Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_finspace_kx_cluster #31806

Merged
merged 36 commits into from
Jun 9, 2023

Conversation

kavan-aws
Copy link
Contributor

Description

This pull request introduces the finspace_kx_cluster resource, along with its associated tests and documentation. This is one component of four new resources being introduced to enable terraform support for FinSpace Managed kdb.

Relations

Relates #22658

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKxCluster PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_basic'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_basic
=== PAUSE TestAccFinSpaceKxCluster_basic
=== CONT  TestAccFinSpaceKxCluster_basic
--- PASS: TestAccFinSpaceKxCluster_basic (3641.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3665.680s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_disappears
=== PAUSE TestAccFinSpaceKxCluster_disappears
=== RUN   TestAccFinSpaceKxCluster_description
=== PAUSE TestAccFinSpaceKxCluster_description
=== RUN   TestAccFinSpaceKxCluster_database
=== PAUSE TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_description
=== CONT  TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_disappears
--- PASS: TestAccFinSpaceKxCluster_description (4034.09s)
--- PASS: TestAccFinSpaceKxCluster_disappears (4056.67s)
--- PASS: TestAccFinSpaceKxCluster_database (4122.80s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4147.613s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_code
=== PAUSE TestAccFinSpaceKxCluster_code
=== RUN   TestAccFinSpaceKxCluster_rdb
=== PAUSE TestAccFinSpaceKxCluster_rdb
=== RUN   TestAccFinSpaceKxCluster_executionRole
=== PAUSE TestAccFinSpaceKxCluster_executionRole
=== RUN   TestAccFinSpaceKxCluster_initializationScript
=== PAUSE TestAccFinSpaceKxCluster_initializationScript
=== CONT  TestAccFinSpaceKxCluster_code
=== CONT  TestAccFinSpaceKxCluster_executionRole
=== CONT  TestAccFinSpaceKxCluster_rdb
=== CONT  TestAccFinSpaceKxCluster_initializationScript
--- PASS: TestAccFinSpaceKxCluster_initializationScript (3815.94s)
--- PASS: TestAccFinSpaceKxCluster_rdb (3928.16s)
--- PASS: TestAccFinSpaceKxCluster_executionRole (3938.15s)
--- PASS: TestAccFinSpaceKxCluster_code (4386.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4410.964s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_commandLineArgs
=== PAUSE TestAccFinSpaceKxCluster_commandLineArgs
=== RUN   TestAccFinSpaceKxCluster_tags
=== PAUSE TestAccFinSpaceKxCluster_tags
=== CONT  TestAccFinSpaceKxCluster_tags
=== CONT  TestAccFinSpaceKxCluster_commandLineArgs
--- PASS: TestAccFinSpaceKxCluster_commandLineArgs (3771.05s)
--- PASS: TestAccFinSpaceKxCluster_tags (4107.18s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4131.432s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_multiAZ'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_multiAZ
=== PAUSE TestAccFinSpaceKxCluster_multiAZ
=== CONT  TestAccFinSpaceKxCluster_multiAZ
--- PASS: TestAccFinSpaceKxCluster_multiAZ (3987.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4011.738s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_autoScaling'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_autoScaling
=== PAUSE TestAccFinSpaceKxCluster_autoScaling
=== CONT  TestAccFinSpaceKxCluster_autoScaling
--- PASS: TestAccFinSpaceKxCluster_autoScaling (3645.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3670.399s
...

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/finspace Issues and PRs that pertain to the finspace service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2023
@jar-b jar-b added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 7, 2023
@jar-b jar-b changed the title F finspace kx cluster [New Resource]: aws_finspace_kx_cluster Jun 8, 2023
@github-actions github-actions bot added the tags Pertains to resource tagging. label Jun 8, 2023
@github-actions github-actions bot removed generators Relates to code generators. tags Pertains to resource tagging. labels Jun 8, 2023
@github-actions github-actions bot added the generators Relates to code generators. label Jun 8, 2023
@kavan-aws
Copy link
Contributor Author

Updated acceptance test output:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_basic'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_basic
=== PAUSE TestAccFinSpaceKxCluster_basic
=== CONT  TestAccFinSpaceKxCluster_basic
--- PASS: TestAccFinSpaceKxCluster_basic (3709.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3736.373s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_disappears
=== PAUSE TestAccFinSpaceKxCluster_disappears
=== RUN   TestAccFinSpaceKxCluster_description
=== PAUSE TestAccFinSpaceKxCluster_description
=== RUN   TestAccFinSpaceKxCluster_database
=== PAUSE TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_description
=== CONT  TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_disappears
--- PASS: TestAccFinSpaceKxCluster_database (3593.13s)
--- PASS: TestAccFinSpaceKxCluster_disappears (3615.51s)
--- PASS: TestAccFinSpaceKxCluster_description (3818.25s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3847.217s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_commandLineArgs'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_commandLineArgs
=== PAUSE TestAccFinSpaceKxCluster_commandLineArgs
=== CONT  TestAccFinSpaceKxCluster_commandLineArgs
--- PASS: TestAccFinSpaceKxCluster_commandLineArgs (3632.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3661.612s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_tags'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_tags
=== PAUSE TestAccFinSpaceKxCluster_tags
=== CONT  TestAccFinSpaceKxCluster_tags
--- PASS: TestAccFinSpaceKxCluster_tags (3735.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3763.310s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_executionRole'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_executionRole
=== PAUSE TestAccFinSpaceKxCluster_executionRole
=== CONT  TestAccFinSpaceKxCluster_executionRole
--- PASS: TestAccFinSpaceKxCluster_executionRole (3725.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3755.084s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_autoScaling'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_autoScaling
=== PAUSE TestAccFinSpaceKxCluster_autoScaling
=== CONT  TestAccFinSpaceKxCluster_autoScaling
--- PASS: TestAccFinSpaceKxCluster_autoScaling (3544.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3572.281s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_code
=== PAUSE TestAccFinSpaceKxCluster_code
=== RUN   TestAccFinSpaceKxCluster_multiAZ
=== PAUSE TestAccFinSpaceKxCluster_multiAZ
=== RUN   TestAccFinSpaceKxCluster_rdb
=== PAUSE TestAccFinSpaceKxCluster_rdb
=== RUN   TestAccFinSpaceKxCluster_initializationScript
=== PAUSE TestAccFinSpaceKxCluster_initializationScript
=== CONT  TestAccFinSpaceKxCluster_code
=== CONT  TestAccFinSpaceKxCluster_rdb
=== CONT  TestAccFinSpaceKxCluster_initializationScript
=== CONT  TestAccFinSpaceKxCluster_multiAZ
--- PASS: TestAccFinSpaceKxCluster_rdb (3667.63s)
--- PASS: TestAccFinSpaceKxCluster_multiAZ (3672.52s)
--- PASS: TestAccFinSpaceKxCluster_code (3815.89s)
--- PASS: TestAccFinSpaceKxCluster_initializationScript (3858.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3888.621s

@jar-b jar-b self-assigned this Jun 9, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b jar-b merged commit 23e4215 into hashicorp:main Jun 9, 2023
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 9, 2023
@jar-b
Copy link
Member

jar-b commented Jun 9, 2023

Thanks for your contribution, @kavan-aws! 🥇

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants