-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: Initial generic Plugin Framework flattener/expander functions #31858
Conversation
Community NoteVoting for Prioritization
For Submitters
|
# Conflicts: # internal/service/resourceexplorer2/view.go
…s-sdk-go-base/v2/awsv1shim/v2/tfawserr'.
Acceptance test output: % make testacc TESTARGS='-run=TestAccResourceExplorer2_serial/Index/basic' PKG=resourceexplorer2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20 -run=TestAccResourceExplorer2_serial/Index/basic -timeout 180m === RUN TestAccResourceExplorer2_serial === PAUSE TestAccResourceExplorer2_serial === CONT TestAccResourceExplorer2_serial === RUN TestAccResourceExplorer2_serial/Index === RUN TestAccResourceExplorer2_serial/Index/basic --- PASS: TestAccResourceExplorer2_serial (26.46s) --- PASS: TestAccResourceExplorer2_serial/Index (26.46s) --- PASS: TestAccResourceExplorer2_serial/Index/basic (26.46s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2 32.079s
…hub.com/hashicorp/aws-sdk-go-base/v2@1c3bdec608c2d79d34f43ad2f4bfd618002ffaca && go mod tidy'.
…e/v2=github.com/hashicorp/aws-sdk-go-base/v2@1c3bdec608c2d79d34f43ad2f4bfd618002ffaca && go mod tidy'." This reverts commit 162f688.
Any chance we can release 5.6.0 to utilize |
@virgofx The release is scheduled for Thursday. |
This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Very preliminary thoughts around generic Terraform Plugin Framework "flattener/expander"s.
The new functions in
internal/framework/flex
are a PoC and should be considered experimental.Introduces the concept of "auto-flex", run-time reflection powered flatteners and expanders between Terraform Plugin Framework-compatible Go structures and AWS SDK for Go (v1 and v2) Go structures.
Currently only working for primitive types.
Relations
Closes #32105.
Closes #32011.
Requires hashicorp/aws-sdk-go-base#524.
Output from Acceptance Testing