Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ChimeSDKVoice Sip Rule #32070

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

Prateeksharma13
Copy link
Contributor

Description

Adding support for ChimeSDKVoice Sip Rule

Relations

Closes #32069

References

https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_voice-chime_CreateSipRule.html

Output from Acceptance Testing

$  export AWS_DEFAULT_REGION="us-east-1" && make testacc TESTS=TestAccChimeSDKVoiceSip PKG=chimesdkvoice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20 -run='TestAccChimeSDKVoiceSip'  -timeout 180m
=== RUN   TestAccChimeSDKVoiceSipMediaApplication_basic
=== PAUSE TestAccChimeSDKVoiceSipMediaApplication_basic
=== RUN   TestAccChimeSDKVoiceSipMediaApplication_disappears
=== PAUSE TestAccChimeSDKVoiceSipMediaApplication_disappears
=== RUN   TestAccChimeSDKVoiceSipMediaApplication_update
=== PAUSE TestAccChimeSDKVoiceSipMediaApplication_update
=== RUN   TestAccChimeSDKVoiceSipMediaApplication_tags
=== PAUSE TestAccChimeSDKVoiceSipMediaApplication_tags
=== RUN   TestAccChimeSDKVoiceSipRule_basic
=== PAUSE TestAccChimeSDKVoiceSipRule_basic
=== RUN   TestAccChimeSDKVoiceSipRule_disappears
=== PAUSE TestAccChimeSDKVoiceSipRule_disappears
=== RUN   TestAccChimeSDKVoiceSipRule_update
=== PAUSE TestAccChimeSDKVoiceSipRule_update
=== CONT  TestAccChimeSDKVoiceSipMediaApplication_basic
=== CONT  TestAccChimeSDKVoiceSipRule_basic
=== CONT  TestAccChimeSDKVoiceSipRule_disappears
=== CONT  TestAccChimeSDKVoiceSipMediaApplication_update
=== CONT  TestAccChimeSDKVoiceSipMediaApplication_disappears
=== CONT  TestAccChimeSDKVoiceSipMediaApplication_tags
=== CONT  TestAccChimeSDKVoiceSipRule_update
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_disappears (53.79s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_basic (63.77s)
--- PASS: TestAccChimeSDKVoiceSipRule_disappears (78.28s)
--- PASS: TestAccChimeSDKVoiceSipRule_basic (103.95s)
--- PASS: TestAccChimeSDKVoiceSipRule_update (120.53s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_tags (128.13s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_update (133.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice	139.763s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Jun 16, 2023
@jar-b jar-b self-assigned this Jun 20, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=chimesdkvoice TESTS=TestAccChimeSDKVoiceSipRule_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20 -run='TestAccChimeSDKVoiceSipRule_'  -timeout 180m

--- PASS: TestAccChimeSDKVoiceSipRule_disappears (39.38s)
--- PASS: TestAccChimeSDKVoiceSipRule_basic (46.62s)
--- PASS: TestAccChimeSDKVoiceSipRule_update (67.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice      71.024s
$ make testacc PKG=chimesdkvoice TESTS=TestAccChimeSDKVoiceSipMediaApplication_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20 -run='TestAccChimeSDKVoiceSipMediaApplication_'  -timeout 180m

--- PASS: TestAccChimeSDKVoiceSipMediaApplication_basic (42.84s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_disappears (46.19s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_tags (55.95s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_update (84.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice      87.716s

@jar-b jar-b merged commit a19337d into hashicorp:main Jun 20, 2023
@jar-b
Copy link
Member

jar-b commented Jun 20, 2023

Thanks for your contribution, @Prateeksharma13 ! 👍

@github-actions github-actions bot added this to the v5.5.0 milestone Jun 20, 2023
@github-actions
Copy link

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Add support for ChimeSDKVoice Sip Rule
2 participants