Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate timestreamwrite resources to AWS SDK for Go v2 #32354

Merged
merged 15 commits into from
Jul 3, 2023
Merged

Tech debt: Migrate timestreamwrite resources to AWS SDK for Go v2 #32354

merged 15 commits into from
Jul 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 3, 2023 •
edited
Loading

Description

Also adds theschema configuration block.

Relations

Closes #32098.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccTimestream' PKG=timestreamwrite ACCTEST_PARALLELISM=2      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/timestreamwrite/... -v -count 1 -parallel 2  -run=TestAccTimestream -timeout 180m
=== RUN   TestAccTimestreamWriteDatabase_basic
=== PAUSE TestAccTimestreamWriteDatabase_basic
=== RUN   TestAccTimestreamWriteDatabase_disappears
=== PAUSE TestAccTimestreamWriteDatabase_disappears
=== RUN   TestAccTimestreamWriteDatabase_kmsKey
=== PAUSE TestAccTimestreamWriteDatabase_kmsKey
=== RUN   TestAccTimestreamWriteDatabase_updateKMSKey
=== PAUSE TestAccTimestreamWriteDatabase_updateKMSKey
=== RUN   TestAccTimestreamWriteDatabase_tags
=== PAUSE TestAccTimestreamWriteDatabase_tags
=== RUN   TestAccTimestreamWriteTable_basic
=== PAUSE TestAccTimestreamWriteTable_basic
=== RUN   TestAccTimestreamWriteTable_magneticStoreWriteProperties
=== PAUSE TestAccTimestreamWriteTable_magneticStoreWriteProperties
=== RUN   TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3Config
=== PAUSE TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3Config
=== RUN   TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3KMSConfig
=== PAUSE TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3KMSConfig
=== RUN   TestAccTimestreamWriteTable_disappears
=== PAUSE TestAccTimestreamWriteTable_disappears
=== RUN   TestAccTimestreamWriteTable_retentionProperties
=== PAUSE TestAccTimestreamWriteTable_retentionProperties
=== RUN   TestAccTimestreamWriteTable_tags
=== PAUSE TestAccTimestreamWriteTable_tags
=== RUN   TestAccTimestreamWriteTable_schema
=== PAUSE TestAccTimestreamWriteTable_schema
=== CONT  TestAccTimestreamWriteDatabase_basic
=== CONT  TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3Config
--- PASS: TestAccTimestreamWriteDatabase_basic (29.86s)
=== CONT  TestAccTimestreamWriteTable_retentionProperties
--- PASS: TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3Config (55.12s)
=== CONT  TestAccTimestreamWriteTable_schema
--- PASS: TestAccTimestreamWriteTable_retentionProperties (69.49s)
=== CONT  TestAccTimestreamWriteTable_tags
--- PASS: TestAccTimestreamWriteTable_schema (48.17s)
=== CONT  TestAccTimestreamWriteDatabase_tags
--- PASS: TestAccTimestreamWriteTable_tags (77.55s)
=== CONT  TestAccTimestreamWriteTable_magneticStoreWriteProperties
--- PASS: TestAccTimestreamWriteDatabase_tags (74.64s)
=== CONT  TestAccTimestreamWriteTable_basic
--- PASS: TestAccTimestreamWriteTable_basic (28.29s)
=== CONT  TestAccTimestreamWriteDatabase_kmsKey
--- PASS: TestAccTimestreamWriteDatabase_kmsKey (34.46s)
=== CONT  TestAccTimestreamWriteDatabase_updateKMSKey
--- PASS: TestAccTimestreamWriteTable_magneticStoreWriteProperties (67.14s)
=== CONT  TestAccTimestreamWriteDatabase_disappears
--- PASS: TestAccTimestreamWriteDatabase_disappears (21.75s)
=== CONT  TestAccTimestreamWriteTable_disappears
--- PASS: TestAccTimestreamWriteTable_disappears (29.04s)
=== CONT  TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3KMSConfig
--- PASS: TestAccTimestreamWriteDatabase_updateKMSKey (84.32s)
--- PASS: TestAccTimestreamWriteTable_magneticStoreWriteProperties_s3KMSConfig (40.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	340.493s
% make sweep SWEEPARGS=-sweep-run=aws_timestreamwrite_database
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_timestreamwrite_database -timeout 60m
2023/07/03 12:12:52 [DEBUG] Running Sweepers for region (us-west-2):
2023/07/03 12:12:52 [DEBUG] Sweeper (aws_timestreamwrite_database) has dependency (aws_timestreamwrite_table), running..
2023/07/03 12:12:52 [DEBUG] Running Sweeper (aws_timestreamwrite_table) in region (us-west-2)
2023/07/03 12:12:54 [DEBUG] Completed Sweeper (aws_timestreamwrite_table) in region (us-west-2) in 1.26893095s
2023/07/03 12:12:54 [DEBUG] Running Sweeper (aws_timestreamwrite_database) in region (us-west-2)
2023/07/03 12:12:54 [DEBUG] Completed Sweeper (aws_timestreamwrite_database) in region (us-west-2) in 91.894287ms
2023/07/03 12:12:54 [DEBUG] Sweeper (aws_timestreamwrite_table) already ran in region (us-west-2)
2023/07/03 12:12:54 Completed Sweepers for region (us-west-2) in 1.361130889s
2023/07/03 12:12:54 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_timestreamwrite_table
	- aws_timestreamwrite_database
2023/07/03 12:12:54 [DEBUG] Running Sweepers for region (us-east-1):
2023/07/03 12:12:54 [DEBUG] Sweeper (aws_timestreamwrite_database) has dependency (aws_timestreamwrite_table), running..
2023/07/03 12:12:54 [DEBUG] Running Sweeper (aws_timestreamwrite_table) in region (us-east-1)
2023/07/03 12:12:54 [DEBUG] Completed Sweeper (aws_timestreamwrite_table) in region (us-east-1) in 591.68602ms
2023/07/03 12:12:54 [DEBUG] Running Sweeper (aws_timestreamwrite_database) in region (us-east-1)
2023/07/03 12:12:54 [DEBUG] Completed Sweeper (aws_timestreamwrite_database) in region (us-east-1) in 25.835645ms
2023/07/03 12:12:54 [DEBUG] Sweeper (aws_timestreamwrite_table) already ran in region (us-east-1)
2023/07/03 12:12:54 Completed Sweepers for region (us-east-1) in 617.668949ms
2023/07/03 12:12:54 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_timestreamwrite_table
	- aws_timestreamwrite_database
2023/07/03 12:12:54 [DEBUG] Running Sweepers for region (us-east-2):
2023/07/03 12:12:54 [DEBUG] Sweeper (aws_timestreamwrite_database) has dependency (aws_timestreamwrite_table), running..
2023/07/03 12:12:54 [DEBUG] Running Sweeper (aws_timestreamwrite_table) in region (us-east-2)
2023/07/03 12:12:55 [DEBUG] Completed Sweeper (aws_timestreamwrite_table) in region (us-east-2) in 707.331421ms
2023/07/03 12:12:55 [DEBUG] Running Sweeper (aws_timestreamwrite_database) in region (us-east-2)
2023/07/03 12:12:55 [DEBUG] Completed Sweeper (aws_timestreamwrite_database) in region (us-east-2) in 28.278381ms
2023/07/03 12:12:55 [DEBUG] Sweeper (aws_timestreamwrite_table) already ran in region (us-east-2)
2023/07/03 12:12:55 Completed Sweepers for region (us-east-2) in 735.749289ms
2023/07/03 12:12:55 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_timestreamwrite_table
	- aws_timestreamwrite_database
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	7.847s

@ewbankkit
Use AWS SDK for Go v2 for timestreamwrite service.
29c4d5f
@ewbankkit
Add 'names.TimestreamWriteEndpointID'.
dd8d834
@ewbankkit
timestreamwrite: Generate AWS SDK for Go v2 tagging code.
b2a7fc8
@ewbankkit
Run 'make gen'.
fab0a73
@ewbankkit
Run 'go get github.com/aws/aws-sdk-go-v2/service/timestreamwrite@v1.1…
10e6598 
…7.2 && go mod tidy'.
@ewbankkit
r/aws_timestreamwrite_database: Migrate to AWS SDK for Go v2.
d766e50
@ewbankkit
r/aws_timestreamwrite_table: Migrate to AWS SDK for Go v2.
08905d7
@ewbankkit
timestreamwrite: Migrate acceptance tests to AWS SDK for Go v2.
6f765fa
@ewbankkit
keyspaces: Resource ID parsing functions are not exported.
4f8e7fe
@ewbankkit
timestreamwrite: Migrate sweepers to AWS SDK for Go v2.
fa732e0
@ewbankkit
r/aws_timestreamwrite_table: Add 'schema' configuration block.
d27eab6
@ewbankkit
r/aws_timestreamwrite_table: Add 'TestAccTimestreamWriteTable_schema'.
a91a46b 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccTimestreamWriteTable_schema' PKG=timestreamwrite
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/timestreamwrite/... -v -count 1 -parallel 20  -run=TestAccTimestreamWriteTable_schema -timeout 180m
=== RUN   TestAccTimestreamWriteTable_schema
=== PAUSE TestAccTimestreamWriteTable_schema
=== CONT  TestAccTimestreamWriteTable_schema
--- PASS: TestAccTimestreamWriteTable_schema (44.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	49.754s
@ewbankkit
Add customer-defined partition key example.
110e504
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/keyspaces Issues and PRs that pertain to the keyspaces service. size/XL Managed by automation to categorize the size of a PR. labels Jul 3, 2023
@ewbankkit ewbankkit merged commit a16984b into main Jul 3, 2023
@ewbankkit ewbankkit deleted the td-migrate-timestreamwrite-to-aws-sdk-v2 branch July 3, 2023 19:27
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
Update CHANGELOG.md for #32354
f79d778
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DanielMSchmidt DanielMSchmidt mentioned this pull request Jul 11, 2023
Open
@saratnulu saratnulu mentioned this pull request Jul 18, 2023
Closed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/keyspaces Issues and PRs that pertain to the keyspaces service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.7.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for Timestream customer-defined partition keys
2 participants
@ewbankkit @justinretzolk