-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: Update aws-sdk-go-base
and handle returned diags
#32572
Conversation
Community NoteVoting for Prioritization
For Submitters
|
ad9ae10
to
da0da0d
Compare
5.9.0 was released. is this ready for merging as well? |
We typically release the provider weekly, and expect to release it tomorrow |
da0da0d
to
f80f4c1
Compare
# Conflicts: # go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccProvider_' PKG_NAME=./internal/provider ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/provider/... -v -count 1 -parallel 2 -run=TestAccProvider_ -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider [no test files]
=== RUN TestAccProvider_DefaultTags_emptyBlock
=== PAUSE TestAccProvider_DefaultTags_emptyBlock
=== RUN TestAccProvider_DefaultTagsTags_none
=== PAUSE TestAccProvider_DefaultTagsTags_none
=== RUN TestAccProvider_DefaultTagsTags_one
=== PAUSE TestAccProvider_DefaultTagsTags_one
=== RUN TestAccProvider_DefaultTagsTags_multiple
=== PAUSE TestAccProvider_DefaultTagsTags_multiple
=== RUN TestAccProvider_DefaultAndIgnoreTags_emptyBlocks
=== PAUSE TestAccProvider_DefaultAndIgnoreTags_emptyBlocks
=== RUN TestAccProvider_endpoints
=== PAUSE TestAccProvider_endpoints
=== RUN TestAccProvider_fipsEndpoint
=== PAUSE TestAccProvider_fipsEndpoint
=== RUN TestAccProvider_unusualEndpoints
=== PAUSE TestAccProvider_unusualEndpoints
=== RUN TestAccProvider_IgnoreTags_emptyBlock
=== PAUSE TestAccProvider_IgnoreTags_emptyBlock
=== RUN TestAccProvider_IgnoreTagsKeyPrefixes_none
=== PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_none
=== RUN TestAccProvider_IgnoreTagsKeyPrefixes_one
=== PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_one
=== RUN TestAccProvider_IgnoreTagsKeyPrefixes_multiple
=== PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_multiple
=== RUN TestAccProvider_IgnoreTagsKeys_none
=== PAUSE TestAccProvider_IgnoreTagsKeys_none
=== RUN TestAccProvider_IgnoreTagsKeys_one
=== PAUSE TestAccProvider_IgnoreTagsKeys_one
=== RUN TestAccProvider_IgnoreTagsKeys_multiple
=== PAUSE TestAccProvider_IgnoreTagsKeys_multiple
=== RUN TestAccProvider_Region_c2s
=== PAUSE TestAccProvider_Region_c2s
=== RUN TestAccProvider_Region_china
=== PAUSE TestAccProvider_Region_china
=== RUN TestAccProvider_Region_commercial
=== PAUSE TestAccProvider_Region_commercial
=== RUN TestAccProvider_Region_govCloud
=== PAUSE TestAccProvider_Region_govCloud
=== RUN TestAccProvider_Region_sc2s
=== PAUSE TestAccProvider_Region_sc2s
=== RUN TestAccProvider_Region_stsRegion
=== PAUSE TestAccProvider_Region_stsRegion
=== RUN TestAccProvider_AssumeRole_empty
=== PAUSE TestAccProvider_AssumeRole_empty
=== CONT TestAccProvider_DefaultTags_emptyBlock
=== CONT TestAccProvider_IgnoreTagsKeyPrefixes_multiple
--- PASS: TestAccProvider_DefaultTags_emptyBlock (17.05s)
=== CONT TestAccProvider_fipsEndpoint
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_multiple (17.21s)
=== CONT TestAccProvider_IgnoreTagsKeyPrefixes_one
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_one (16.43s)
=== CONT TestAccProvider_IgnoreTagsKeyPrefixes_none
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_none (14.98s)
=== CONT TestAccProvider_IgnoreTags_emptyBlock
--- PASS: TestAccProvider_IgnoreTags_emptyBlock (15.33s)
=== CONT TestAccProvider_unusualEndpoints
--- PASS: TestAccProvider_fipsEndpoint (48.25s)
=== CONT TestAccProvider_DefaultTagsTags_multiple
--- PASS: TestAccProvider_DefaultTagsTags_multiple (16.01s)
=== CONT TestAccProvider_endpoints
--- PASS: TestAccProvider_unusualEndpoints (33.13s)
=== CONT TestAccProvider_DefaultAndIgnoreTags_emptyBlocks
--- PASS: TestAccProvider_DefaultAndIgnoreTags_emptyBlocks (15.34s)
=== CONT TestAccProvider_Region_commercial
--- PASS: TestAccProvider_endpoints (32.89s)
=== CONT TestAccProvider_AssumeRole_empty
--- PASS: TestAccProvider_Region_commercial (11.02s)
=== CONT TestAccProvider_Region_stsRegion
--- PASS: TestAccProvider_AssumeRole_empty (19.94s)
=== CONT TestAccProvider_Region_sc2s
--- PASS: TestAccProvider_Region_stsRegion (12.16s)
=== CONT TestAccProvider_Region_govCloud
--- PASS: TestAccProvider_Region_sc2s (11.62s)
=== CONT TestAccProvider_DefaultTagsTags_one
--- PASS: TestAccProvider_Region_govCloud (11.37s)
=== CONT TestAccProvider_IgnoreTagsKeys_multiple
--- PASS: TestAccProvider_DefaultTagsTags_one (15.98s)
=== CONT TestAccProvider_Region_china
--- PASS: TestAccProvider_IgnoreTagsKeys_multiple (15.87s)
=== CONT TestAccProvider_Region_c2s
--- PASS: TestAccProvider_Region_china (11.56s)
=== CONT TestAccProvider_IgnoreTagsKeys_one
--- PASS: TestAccProvider_Region_c2s (11.53s)
=== CONT TestAccProvider_DefaultTagsTags_none
--- PASS: TestAccProvider_IgnoreTagsKeys_one (15.45s)
=== CONT TestAccProvider_IgnoreTagsKeys_none
--- PASS: TestAccProvider_DefaultTagsTags_none (15.22s)
--- PASS: TestAccProvider_IgnoreTagsKeys_none (12.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/provider 207.612s
This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
hashicorp/aws-sdk-go-base#553 updates
aws-sdk-go-base
to returndiags
instead of `errors. Update the provider to handle this.Depends on release of
aws-sdk-go-base