Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Update aws-sdk-go-base and handle returned diags #32572

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 18, 2023

Description

hashicorp/aws-sdk-go-base#553 updates aws-sdk-go-base to return diags instead of `errors. Update the provider to handle this.

Depends on release of aws-sdk-go-base

@gdavison gdavison added this to the v5.10.0 milestone Jul 18, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/configservice Issues and PRs that pertain to the configservice service. provider Pertains to the provider itself, rather than any interaction with AWS. linter Pertains to changes to or issues with the various linters. client-connections Pertains to the AWS Client and service connections. labels Jul 18, 2023
@nam054 nam054 modified the milestones: v5.10.0, v5.11.0 Jul 27, 2023
@grumpper
Copy link

grumpper commented Aug 2, 2023

5.9.0 was released.
hashicorp/aws-sdk-go-base#553 was merged

is this ready for merging as well?
is this the only show stopper for releasing 5.11?

@gdavison gdavison modified the milestones: v5.11.0, v5.12.0 Aug 2, 2023
@gdavison
Copy link
Contributor Author

gdavison commented Aug 2, 2023

We typically release the provider weekly, and expect to release it tomorrow

@gdavison gdavison marked this pull request as ready for review August 2, 2023 19:44
@gdavison gdavison marked this pull request as draft August 2, 2023 19:45
@gdavison gdavison marked this pull request as ready for review August 4, 2023 23:25
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccProvider_' PKG_NAME=./internal/provider ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/provider/... -v -count 1 -parallel 2  -run=TestAccProvider_ -timeout 180m
?   	github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider	[no test files]
=== RUN   TestAccProvider_DefaultTags_emptyBlock
=== PAUSE TestAccProvider_DefaultTags_emptyBlock
=== RUN   TestAccProvider_DefaultTagsTags_none
=== PAUSE TestAccProvider_DefaultTagsTags_none
=== RUN   TestAccProvider_DefaultTagsTags_one
=== PAUSE TestAccProvider_DefaultTagsTags_one
=== RUN   TestAccProvider_DefaultTagsTags_multiple
=== PAUSE TestAccProvider_DefaultTagsTags_multiple
=== RUN   TestAccProvider_DefaultAndIgnoreTags_emptyBlocks
=== PAUSE TestAccProvider_DefaultAndIgnoreTags_emptyBlocks
=== RUN   TestAccProvider_endpoints
=== PAUSE TestAccProvider_endpoints
=== RUN   TestAccProvider_fipsEndpoint
=== PAUSE TestAccProvider_fipsEndpoint
=== RUN   TestAccProvider_unusualEndpoints
=== PAUSE TestAccProvider_unusualEndpoints
=== RUN   TestAccProvider_IgnoreTags_emptyBlock
=== PAUSE TestAccProvider_IgnoreTags_emptyBlock
=== RUN   TestAccProvider_IgnoreTagsKeyPrefixes_none
=== PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_none
=== RUN   TestAccProvider_IgnoreTagsKeyPrefixes_one
=== PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_one
=== RUN   TestAccProvider_IgnoreTagsKeyPrefixes_multiple
=== PAUSE TestAccProvider_IgnoreTagsKeyPrefixes_multiple
=== RUN   TestAccProvider_IgnoreTagsKeys_none
=== PAUSE TestAccProvider_IgnoreTagsKeys_none
=== RUN   TestAccProvider_IgnoreTagsKeys_one
=== PAUSE TestAccProvider_IgnoreTagsKeys_one
=== RUN   TestAccProvider_IgnoreTagsKeys_multiple
=== PAUSE TestAccProvider_IgnoreTagsKeys_multiple
=== RUN   TestAccProvider_Region_c2s
=== PAUSE TestAccProvider_Region_c2s
=== RUN   TestAccProvider_Region_china
=== PAUSE TestAccProvider_Region_china
=== RUN   TestAccProvider_Region_commercial
=== PAUSE TestAccProvider_Region_commercial
=== RUN   TestAccProvider_Region_govCloud
=== PAUSE TestAccProvider_Region_govCloud
=== RUN   TestAccProvider_Region_sc2s
=== PAUSE TestAccProvider_Region_sc2s
=== RUN   TestAccProvider_Region_stsRegion
=== PAUSE TestAccProvider_Region_stsRegion
=== RUN   TestAccProvider_AssumeRole_empty
=== PAUSE TestAccProvider_AssumeRole_empty
=== CONT  TestAccProvider_DefaultTags_emptyBlock
=== CONT  TestAccProvider_IgnoreTagsKeyPrefixes_multiple
--- PASS: TestAccProvider_DefaultTags_emptyBlock (17.05s)
=== CONT  TestAccProvider_fipsEndpoint
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_multiple (17.21s)
=== CONT  TestAccProvider_IgnoreTagsKeyPrefixes_one
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_one (16.43s)
=== CONT  TestAccProvider_IgnoreTagsKeyPrefixes_none
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_none (14.98s)
=== CONT  TestAccProvider_IgnoreTags_emptyBlock
--- PASS: TestAccProvider_IgnoreTags_emptyBlock (15.33s)
=== CONT  TestAccProvider_unusualEndpoints
--- PASS: TestAccProvider_fipsEndpoint (48.25s)
=== CONT  TestAccProvider_DefaultTagsTags_multiple
--- PASS: TestAccProvider_DefaultTagsTags_multiple (16.01s)
=== CONT  TestAccProvider_endpoints
--- PASS: TestAccProvider_unusualEndpoints (33.13s)
=== CONT  TestAccProvider_DefaultAndIgnoreTags_emptyBlocks
--- PASS: TestAccProvider_DefaultAndIgnoreTags_emptyBlocks (15.34s)
=== CONT  TestAccProvider_Region_commercial
--- PASS: TestAccProvider_endpoints (32.89s)
=== CONT  TestAccProvider_AssumeRole_empty
--- PASS: TestAccProvider_Region_commercial (11.02s)
=== CONT  TestAccProvider_Region_stsRegion
--- PASS: TestAccProvider_AssumeRole_empty (19.94s)
=== CONT  TestAccProvider_Region_sc2s
--- PASS: TestAccProvider_Region_stsRegion (12.16s)
=== CONT  TestAccProvider_Region_govCloud
--- PASS: TestAccProvider_Region_sc2s (11.62s)
=== CONT  TestAccProvider_DefaultTagsTags_one
--- PASS: TestAccProvider_Region_govCloud (11.37s)
=== CONT  TestAccProvider_IgnoreTagsKeys_multiple
--- PASS: TestAccProvider_DefaultTagsTags_one (15.98s)
=== CONT  TestAccProvider_Region_china
--- PASS: TestAccProvider_IgnoreTagsKeys_multiple (15.87s)
=== CONT  TestAccProvider_Region_c2s
--- PASS: TestAccProvider_Region_china (11.56s)
=== CONT  TestAccProvider_IgnoreTagsKeys_one
--- PASS: TestAccProvider_Region_c2s (11.53s)
=== CONT  TestAccProvider_DefaultTagsTags_none
--- PASS: TestAccProvider_IgnoreTagsKeys_one (15.45s)
=== CONT  TestAccProvider_IgnoreTagsKeys_none
--- PASS: TestAccProvider_DefaultTagsTags_none (15.22s)
--- PASS: TestAccProvider_IgnoreTagsKeys_none (12.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	207.612s

@gdavison gdavison merged commit ceed980 into main Aug 8, 2023
34 checks passed
@gdavison gdavison deleted the f-aws-sdk-go-base-diags branch August 8, 2023 16:57
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
@github-actions
Copy link

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. service/configservice Issues and PRs that pertain to the configservice service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants