Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudformation_stack: Test outputs update #32748

Merged
merged 16 commits into from
Jul 31, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 28, 2023

Description

Test update of outputs when parameters changes.

Relations

Relates #32744.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloudFormationStack_' PKG=cloudformation ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 2  -run=TestAccCloudFormationStack_ -timeout 180m
=== RUN   TestAccCloudFormationStack_basic
=== PAUSE TestAccCloudFormationStack_basic
=== RUN   TestAccCloudFormationStack_CreationFailure_doNothing
=== PAUSE TestAccCloudFormationStack_CreationFailure_doNothing
=== RUN   TestAccCloudFormationStack_CreationFailure_delete
=== PAUSE TestAccCloudFormationStack_CreationFailure_delete
=== RUN   TestAccCloudFormationStack_CreationFailure_rollback
=== PAUSE TestAccCloudFormationStack_CreationFailure_rollback
=== RUN   TestAccCloudFormationStack_updateFailure
=== PAUSE TestAccCloudFormationStack_updateFailure
=== RUN   TestAccCloudFormationStack_disappears
=== PAUSE TestAccCloudFormationStack_disappears
=== RUN   TestAccCloudFormationStack_yaml
=== PAUSE TestAccCloudFormationStack_yaml
=== RUN   TestAccCloudFormationStack_defaultParams
=== PAUSE TestAccCloudFormationStack_defaultParams
=== RUN   TestAccCloudFormationStack_allAttributes
=== PAUSE TestAccCloudFormationStack_allAttributes
=== RUN   TestAccCloudFormationStack_withParams
=== PAUSE TestAccCloudFormationStack_withParams
=== RUN   TestAccCloudFormationStack_WithURL_withParams
=== PAUSE TestAccCloudFormationStack_WithURL_withParams
=== RUN   TestAccCloudFormationStack_WithURLWithParams_withYAML
=== PAUSE TestAccCloudFormationStack_WithURLWithParams_withYAML
=== RUN   TestAccCloudFormationStack_WithURLWithParams_noUpdate
=== PAUSE TestAccCloudFormationStack_WithURLWithParams_noUpdate
=== RUN   TestAccCloudFormationStack_withTransform
=== PAUSE TestAccCloudFormationStack_withTransform
=== RUN   TestAccCloudFormationStack_onFailure
=== PAUSE TestAccCloudFormationStack_onFailure
=== RUN   TestAccCloudFormationStack_outputsUpdated
=== PAUSE TestAccCloudFormationStack_outputsUpdated
=== CONT  TestAccCloudFormationStack_basic
=== CONT  TestAccCloudFormationStack_allAttributes
--- PASS: TestAccCloudFormationStack_basic (55.40s)
=== CONT  TestAccCloudFormationStack_WithURLWithParams_noUpdate
--- PASS: TestAccCloudFormationStack_allAttributes (83.19s)
=== CONT  TestAccCloudFormationStack_outputsUpdated
--- PASS: TestAccCloudFormationStack_WithURLWithParams_noUpdate (93.68s)
=== CONT  TestAccCloudFormationStack_onFailure
--- PASS: TestAccCloudFormationStack_outputsUpdated (76.03s)
=== CONT  TestAccCloudFormationStack_withTransform
--- PASS: TestAccCloudFormationStack_onFailure (60.14s)
=== CONT  TestAccCloudFormationStack_WithURL_withParams
--- PASS: TestAccCloudFormationStack_withTransform (58.13s)
=== CONT  TestAccCloudFormationStack_WithURLWithParams_withYAML
--- PASS: TestAccCloudFormationStack_WithURLWithParams_withYAML (62.65s)
=== CONT  TestAccCloudFormationStack_withParams
--- PASS: TestAccCloudFormationStack_WithURL_withParams (110.81s)
=== CONT  TestAccCloudFormationStack_updateFailure
--- PASS: TestAccCloudFormationStack_withParams (96.11s)
=== CONT  TestAccCloudFormationStack_defaultParams
--- PASS: TestAccCloudFormationStack_updateFailure (69.35s)
=== CONT  TestAccCloudFormationStack_yaml
--- PASS: TestAccCloudFormationStack_yaml (52.54s)
=== CONT  TestAccCloudFormationStack_disappears
--- PASS: TestAccCloudFormationStack_defaultParams (99.40s)
=== CONT  TestAccCloudFormationStack_CreationFailure_delete
--- PASS: TestAccCloudFormationStack_disappears (46.70s)
=== CONT  TestAccCloudFormationStack_CreationFailure_rollback
--- PASS: TestAccCloudFormationStack_CreationFailure_delete (152.70s)
=== CONT  TestAccCloudFormationStack_CreationFailure_doNothing
--- PASS: TestAccCloudFormationStack_CreationFailure_rollback (162.61s)
--- PASS: TestAccCloudFormationStack_CreationFailure_doNothing (183.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	816.628s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 28, 2023
@ewbankkit ewbankkit changed the title r/aws_cloudformation_stack: outputs is newly computed if parameters or template updated r/aws_cloudformation_stack: Test outputs update Jul 29, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 29, 2023
@ewbankkit ewbankkit merged commit 5a8e565 into main Jul 31, 2023
42 checks passed
@ewbankkit ewbankkit deleted the b-aws_cloudformation_stack.outputs-stale branch July 31, 2023 11:32
@github-actions github-actions bot added this to the v5.11.0 milestone Jul 31, 2023
github-actions bot pushed a commit that referenced this pull request Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant