-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudWatch composite alarm actions suppressor attributes #32751
Add CloudWatch composite alarm actions suppressor attributes #32751
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @DanielRieske 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few drive-by comments - I've asked @ewbankkit to review this as we're direct colleagues.
Nice work @DanielRieske 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudWatchCompositeAlarm_' PKG=cloudwatch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 2 -run=TestAccCloudWatchCompositeAlarm_ -timeout 180m
=== RUN TestAccCloudWatchCompositeAlarm_basic
=== PAUSE TestAccCloudWatchCompositeAlarm_basic
=== RUN TestAccCloudWatchCompositeAlarm_disappears
=== PAUSE TestAccCloudWatchCompositeAlarm_disappears
=== RUN TestAccCloudWatchCompositeAlarm_tags
=== PAUSE TestAccCloudWatchCompositeAlarm_tags
=== RUN TestAccCloudWatchCompositeAlarm_actionsEnabled
=== PAUSE TestAccCloudWatchCompositeAlarm_actionsEnabled
=== RUN TestAccCloudWatchCompositeAlarm_alarmActions
=== PAUSE TestAccCloudWatchCompositeAlarm_alarmActions
=== RUN TestAccCloudWatchCompositeAlarm_description
=== PAUSE TestAccCloudWatchCompositeAlarm_description
=== RUN TestAccCloudWatchCompositeAlarm_updateAlarmRule
=== PAUSE TestAccCloudWatchCompositeAlarm_updateAlarmRule
=== RUN TestAccCloudWatchCompositeAlarm_insufficientDataActions
=== PAUSE TestAccCloudWatchCompositeAlarm_insufficientDataActions
=== RUN TestAccCloudWatchCompositeAlarm_okActions
=== PAUSE TestAccCloudWatchCompositeAlarm_okActions
=== RUN TestAccCloudWatchCompositeAlarm_allActions
=== PAUSE TestAccCloudWatchCompositeAlarm_allActions
=== RUN TestAccCloudWatchCompositeAlarm_actionsSuppressor
=== PAUSE TestAccCloudWatchCompositeAlarm_actionsSuppressor
=== CONT TestAccCloudWatchCompositeAlarm_basic
=== CONT TestAccCloudWatchCompositeAlarm_updateAlarmRule
--- PASS: TestAccCloudWatchCompositeAlarm_basic (32.83s)
=== CONT TestAccCloudWatchCompositeAlarm_actionsEnabled
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (55.08s)
=== CONT TestAccCloudWatchCompositeAlarm_description
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (52.59s)
=== CONT TestAccCloudWatchCompositeAlarm_alarmActions
--- PASS: TestAccCloudWatchCompositeAlarm_description (51.29s)
=== CONT TestAccCloudWatchCompositeAlarm_tags
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (70.44s)
=== CONT TestAccCloudWatchCompositeAlarm_allActions
--- PASS: TestAccCloudWatchCompositeAlarm_tags (68.87s)
=== CONT TestAccCloudWatchCompositeAlarm_actionsSuppressor
--- PASS: TestAccCloudWatchCompositeAlarm_actionsSuppressor (30.92s)
=== CONT TestAccCloudWatchCompositeAlarm_okActions
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (50.41s)
=== CONT TestAccCloudWatchCompositeAlarm_insufficientDataActions
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (70.31s)
=== CONT TestAccCloudWatchCompositeAlarm_disappears
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (74.03s)
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (21.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 304.382s
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
ActionsSuppressor
options, which hasalarm
,extension_period
andwait_period
attributes to configure actions suppressor.https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_PutCompositeAlarm.html
Relations
Closes #32251
References
Output from Acceptance Testing