-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F msk-vpc-connection #32775
F msk-vpc-connection #32775
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…nInput.SecurityGroups'.
# Conflicts: # go.mod # go.sum
@markoskandylis Thanks for the contribution 👏. It looks like we'll have to add % make testacc TESTARGS='-run=TestAccKafkaVPCConnection_' PKG=kafka ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 2 -run=TestAccKafkaVPCConnection_ -timeout 180m
=== RUN TestAccKafkaVPCConnection_basic
=== PAUSE TestAccKafkaVPCConnection_basic
=== RUN TestAccKafkaVPCConnection_disappears
=== PAUSE TestAccKafkaVPCConnection_disappears
=== CONT TestAccKafkaVPCConnection_basic
=== CONT TestAccKafkaVPCConnection_disappears
vpc_connection_test.go:59: Step 1/1 error: Error running apply: exit status 1
Error: creating Amazon Managed Streaming for Kafka VPC Connection (): operation error Kafka: CreateVpcConnection, https response error StatusCode: 400, RequestID: 7ec182fa-505a-422c-b1e3-2bc9e207b467, BadRequestException: SASL/IAM client authentication must be enabled for the cluster.
with aws_msk_vpc_connection.test,
on terraform_plugin_test.tf line 137, in resource "aws_msk_vpc_connection" "test":
137: resource "aws_msk_vpc_connection" "test" {
=== NAME TestAccKafkaVPCConnection_basic
vpc_connection_test.go:28: Step 1/2 error: Error running apply: exit status 1
Error: creating Amazon Managed Streaming for Kafka VPC Connection (): operation error Kafka: CreateVpcConnection, https response error StatusCode: 400, RequestID: 7e52bb5b-0039-4484-854f-365076a32429, BadRequestException: SASL/IAM client authentication must be enabled for the cluster.
with aws_msk_vpc_connection.test,
on terraform_plugin_test.tf line 137, in resource "aws_msk_vpc_connection" "test":
137: resource "aws_msk_vpc_connection" "test" {
--- FAIL: TestAccKafkaVPCConnection_basic (2026.07s)
--- FAIL: TestAccKafkaVPCConnection_disappears (2033.02s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/kafka 2038.193s
FAIL
make: *** [testacc] Error 1 TODO
|
Hi @ewbankkit i will check this, i thought it was the policy resource that had to add to make this work :) |
I think policy is only required for cross-account connections. |
Hmm ye probably you are right i will check and fix it tomorrow :) |
# Conflicts: # go.mod # go.sum # names/names_data.csv
…cified broker type.'.
# Conflicts: # go.mod # go.sum
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaCluster_' PKG=kafka ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 3 -run=TestAccKafkaCluster_ -timeout 720m
=== RUN TestAccKafkaCluster_basic
=== PAUSE TestAccKafkaCluster_basic
=== RUN TestAccKafkaCluster_disappears
=== PAUSE TestAccKafkaCluster_disappears
=== RUN TestAccKafkaCluster_tags
=== PAUSE TestAccKafkaCluster_tags
=== RUN TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo
=== RUN TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType
=== RUN TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM
=== RUN TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity
=== PAUSE TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity
=== RUN TestAccKafkaCluster_ClientAuthenticationSASL_scram
=== PAUSE TestAccKafkaCluster_ClientAuthenticationSASL_scram
=== RUN TestAccKafkaCluster_ClientAuthenticationSASL_iam
=== PAUSE TestAccKafkaCluster_ClientAuthenticationSASL_iam
=== RUN TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs
=== PAUSE TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs
=== RUN TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication
=== PAUSE TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication
=== RUN TestAccKafkaCluster_Info_revision
=== PAUSE TestAccKafkaCluster_Info_revision
=== RUN TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN
=== PAUSE TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN
=== RUN TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker
=== PAUSE TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker
=== RUN TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster
=== PAUSE TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster
=== RUN TestAccKafkaCluster_enhancedMonitoring
=== PAUSE TestAccKafkaCluster_enhancedMonitoring
=== RUN TestAccKafkaCluster_numberOfBrokerNodes
=== PAUSE TestAccKafkaCluster_numberOfBrokerNodes
=== RUN TestAccKafkaCluster_openMonitoring
=== PAUSE TestAccKafkaCluster_openMonitoring
=== RUN TestAccKafkaCluster_storageMode
=== PAUSE TestAccKafkaCluster_storageMode
=== RUN TestAccKafkaCluster_loggingInfo
=== PAUSE TestAccKafkaCluster_loggingInfo
=== RUN TestAccKafkaCluster_kafkaVersionUpgrade
=== PAUSE TestAccKafkaCluster_kafkaVersionUpgrade
=== RUN TestAccKafkaCluster_kafkaVersionDowngrade
=== PAUSE TestAccKafkaCluster_kafkaVersionDowngrade
=== RUN TestAccKafkaCluster_kafkaVersionUpgradeWithInfo
=== PAUSE TestAccKafkaCluster_kafkaVersionUpgradeWithInfo
=== CONT TestAccKafkaCluster_basic
=== CONT TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN
=== CONT TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity
--- PASS: TestAccKafkaCluster_basic (2070.60s)
=== CONT TestAccKafkaCluster_storageMode
--- PASS: TestAccKafkaCluster_EncryptionInfo_encryptionAtRestKMSKeyARN (2072.89s)
=== CONT TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo
--- PASS: TestAccKafkaCluster_storageMode (3035.92s)
=== CONT TestAccKafkaCluster_kafkaVersionUpgradeWithInfo
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_storageInfo (2247.99s)
=== CONT TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_vpcConnectivity (6260.84s)
=== CONT TestAccKafkaCluster_kafkaVersionDowngrade
--- PASS: TestAccKafkaCluster_kafkaVersionUpgradeWithInfo (6874.66s)
=== CONT TestAccKafkaCluster_kafkaVersionUpgrade
--- PASS: TestAccKafkaCluster_kafkaVersionDowngrade (4318.38s)
=== CONT TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_publicAccessSASLIAM (6293.44s)
=== CONT TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType
--- PASS: TestAccKafkaCluster_ClientAuthenticationTLS_certificateAuthorityARNs (2231.34s)
=== CONT TestAccKafkaCluster_loggingInfo
--- PASS: TestAccKafkaCluster_loggingInfo (2770.44s)
=== CONT TestAccKafkaCluster_Info_revision
--- PASS: TestAccKafkaCluster_kafkaVersionUpgrade (6817.77s)
=== CONT TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication
--- PASS: TestAccKafkaCluster_BrokerNodeGroupInfo_instanceType (6869.62s)
=== CONT TestAccKafkaCluster_enhancedMonitoring
--- PASS: TestAccKafkaCluster_Info_revision (3254.13s)
=== CONT TestAccKafkaCluster_openMonitoring
--- PASS: TestAccKafkaCluster_enhancedMonitoring (2407.59s)
=== CONT TestAccKafkaCluster_numberOfBrokerNodes
--- PASS: TestAccKafkaCluster_ClientAuthenticationTLS_initiallyNoAuthentication (4826.71s)
=== CONT TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster
--- PASS: TestAccKafkaCluster_openMonitoring (3031.32s)
=== CONT TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker
--- PASS: TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_inCluster (2075.66s)
=== CONT TestAccKafkaCluster_ClientAuthenticationSASL_iam
--- PASS: TestAccKafkaCluster_numberOfBrokerNodes (3280.01s)
=== CONT TestAccKafkaCluster_ClientAuthenticationSASL_scram
--- PASS: TestAccKafkaCluster_EncryptionInfoEncryptionInTransit_clientBroker (2429.11s)
=== CONT TestAccKafkaCluster_disappears
--- PASS: TestAccKafkaCluster_disappears (1913.35s)
=== CONT TestAccKafkaCluster_tags
--- PASS: TestAccKafkaCluster_ClientAuthenticationSASL_scram (3742.33s)
--- PASS: TestAccKafkaCluster_ClientAuthenticationSASL_iam (4224.93s)
--- PASS: TestAccKafkaCluster_tags (2230.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 28445.227s % ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaVPCConnectionDataSource_\|TestAccKafkaVPCConnection_' PKG=kafka ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 1 -run=TestAccKafkaVPCConnectionDataSource_\|TestAccKafkaVPCConnection_ -timeout 720m
=== RUN TestAccKafkaVPCConnectionDataSource_basic
=== PAUSE TestAccKafkaVPCConnectionDataSource_basic
=== RUN TestAccKafkaVPCConnection_basic
=== PAUSE TestAccKafkaVPCConnection_basic
=== RUN TestAccKafkaVPCConnection_disappears
=== PAUSE TestAccKafkaVPCConnection_disappears
=== CONT TestAccKafkaVPCConnectionDataSource_basic
=== CONT TestAccKafkaVPCConnection_disappears
--- PASS: TestAccKafkaVPCConnectionDataSource_basic (6975.36s)
--- PASS: TestAccKafkaVPCConnection_disappears (6379.56s)
=== CONT TestAccKafkaVPCConnection_basic
--- PASS: TestAccKafkaVPCConnection_basic (7065.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 20426.234s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaVPCConnection_tags' PKG=kafka ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 1 -run=TestAccKafkaVPCConnection_tags -timeout 720m
=== RUN TestAccKafkaVPCConnection_tags
=== PAUSE TestAccKafkaVPCConnection_tags
=== CONT TestAccKafkaVPCConnection_tags
--- PASS: TestAccKafkaVPCConnection_tags (7365.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 7366.695s
@markoskandylis Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for MSK VPC-Connection
Relations
Relates #31062
References
go reference: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/kafka
api reference: https://docs.aws.amazon.com/msk/1.0/apireference/vpc-connection.html
Output from Acceptance Testing