-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Enabling IPv6 apply error #32896
Fix: Enabling IPv6 apply error #32896
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @watarukura 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
enabling dns64 and resource_name_dns_aaaa_record_on_launch, do that after modifying the IPv6 CIDR block.
539b007
to
4fbdd02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T=TestAccVPCSubnet K=vpc P=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCSubnet' -timeout 180m
=== RUN TestAccVPCSubnetCIDRReservation_basic
=== PAUSE TestAccVPCSubnetCIDRReservation_basic
=== RUN TestAccVPCSubnetCIDRReservation_ipv6
=== PAUSE TestAccVPCSubnetCIDRReservation_ipv6
=== RUN TestAccVPCSubnetCIDRReservation_disappears
=== PAUSE TestAccVPCSubnetCIDRReservation_disappears
=== RUN TestAccVPCSubnetDataSource_basic
=== PAUSE TestAccVPCSubnetDataSource_basic
=== RUN TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== RUN TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== PAUSE TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== RUN TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN TestAccVPCSubnet_DefaultTags_providerOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_providerOnly
=== RUN TestAccVPCSubnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_updateToProviderOnly
=== RUN TestAccVPCSubnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_updateToResourceOnly
=== RUN TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN TestAccVPCSubnet_defaultAndIgnoreTags
=== PAUSE TestAccVPCSubnet_defaultAndIgnoreTags
=== RUN TestAccVPCSubnet_updateTagsKnownAtApply
=== PAUSE TestAccVPCSubnet_updateTagsKnownAtApply
=== RUN TestAccVPCSubnet_ignoreTags
=== PAUSE TestAccVPCSubnet_ignoreTags
=== RUN TestAccVPCSubnet_ipv6
=== PAUSE TestAccVPCSubnet_ipv6
=== RUN TestAccVPCSubnet_enableIPv6
=== PAUSE TestAccVPCSubnet_enableIPv6
=== RUN TestAccVPCSubnet_availabilityZoneID
=== PAUSE TestAccVPCSubnet_availabilityZoneID
=== RUN TestAccVPCSubnet_disappears
=== PAUSE TestAccVPCSubnet_disappears
=== RUN TestAccVPCSubnet_customerOwnedIPv4Pool
=== PAUSE TestAccVPCSubnet_customerOwnedIPv4Pool
=== RUN TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== RUN TestAccVPCSubnet_mapPublicIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapPublicIPOnLaunch
=== RUN TestAccVPCSubnet_outpost
=== PAUSE TestAccVPCSubnet_outpost
=== RUN TestAccVPCSubnet_enableDNS64
=== PAUSE TestAccVPCSubnet_enableDNS64
=== RUN TestAccVPCSubnet_ipv4ToIPv6
=== PAUSE TestAccVPCSubnet_ipv4ToIPv6
=== RUN TestAccVPCSubnet_enableLNIAtDeviceIndex
=== PAUSE TestAccVPCSubnet_enableLNIAtDeviceIndex
=== RUN TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== PAUSE TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== RUN TestAccVPCSubnet_ipv6Native
=== PAUSE TestAccVPCSubnet_ipv6Native
=== RUN TestAccVPCSubnetsDataSource_basic
=== PAUSE TestAccVPCSubnetsDataSource_basic
=== RUN TestAccVPCSubnetsDataSource_filter
=== PAUSE TestAccVPCSubnetsDataSource_filter
=== CONT TestAccVPCSubnetCIDRReservation_basic
=== CONT TestAccVPCSubnet_outpost
=== CONT TestAccVPCSubnet_ignoreTags
=== NAME TestAccVPCSubnet_outpost
acctest.go:1105: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_outpost (0.92s)
=== CONT TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
--- PASS: TestAccVPCSubnetCIDRReservation_basic (40.87s)
=== CONT TestAccVPCSubnetsDataSource_filter
--- PASS: TestAccVPCSubnet_ignoreTags (76.60s)
=== CONT TestAccVPCSubnetsDataSource_basic
--- PASS: TestAccVPCSubnetsDataSource_filter (40.02s)
=== CONT TestAccVPCSubnet_ipv6Native
--- PASS: TestAccVPCSubnet_ipv6Native (52.69s)
=== CONT TestAccVPCSubnet_ipv4ToIPv6
--- PASS: TestAccVPCSubnetsDataSource_basic (65.60s)
=== CONT TestAccVPCSubnet_enableLNIAtDeviceIndex
acctest.go:1105: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_enableLNIAtDeviceIndex (0.39s)
=== CONT TestAccVPCSubnet_disappears
--- PASS: TestAccVPCSubnet_disappears (36.73s)
=== CONT TestAccVPCSubnet_mapPublicIPOnLaunch
--- PASS: TestAccVPCSubnet_privateDNSNameOptionsOnLaunch (203.59s)
=== CONT TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
acctest.go:1105: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch (0.18s)
=== CONT TestAccVPCSubnet_customerOwnedIPv4Pool
acctest.go:1105: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_customerOwnedIPv4Pool (0.17s)
=== CONT TestAccVPCSubnet_enableDNS64
--- PASS: TestAccVPCSubnet_ipv4ToIPv6 (108.12s)
=== CONT TestAccVPCSubnet_enableIPv6
--- PASS: TestAccVPCSubnet_mapPublicIPOnLaunch (122.62s)
=== CONT TestAccVPCSubnet_availabilityZoneID
--- PASS: TestAccVPCSubnet_availabilityZoneID (42.53s)
=== CONT TestAccVPCSubnet_tags
--- PASS: TestAccVPCSubnet_enableDNS64 (148.80s)
=== CONT TestAccVPCSubnet_updateTagsKnownAtApply
--- PASS: TestAccVPCSubnet_enableIPv6 (130.79s)
=== CONT TestAccVPCSubnet_defaultAndIgnoreTags
--- PASS: TestAccVPCSubnet_updateTagsKnownAtApply (85.10s)
=== CONT TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSubnet_tags (109.62s)
=== CONT TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCSubnet_defaultAndIgnoreTags (83.64s)
=== CONT TestAccVPCSubnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSubnet_DefaultTags_updateToResourceOnly (71.30s)
=== CONT TestAccVPCSubnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag (99.52s)
=== CONT TestAccVPCSubnet_DefaultTags_providerOnly
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag (95.56s)
=== CONT TestAccVPCSubnet_ipv6
--- PASS: TestAccVPCSubnet_DefaultTags_updateToProviderOnly (68.06s)
=== CONT TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
--- PASS: TestAccVPCSubnet_DefaultTags_providerOnly (95.32s)
=== CONT TestAccVPCSubnet_basic
--- PASS: TestAccVPCSubnetDataSource_ipv6ByIPv6Filter (77.84s)
=== CONT TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
acctest.go:1105: skipping since no Outposts found
--- SKIP: TestAccVPCSubnetDataSource_enableLniAtDeviceIndex (0.42s)
=== CONT TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
--- PASS: TestAccVPCSubnet_basic (43.91s)
=== CONT TestAccVPCSubnetCIDRReservation_disappears
--- PASS: TestAccVPCSubnet_ipv6 (133.54s)
=== CONT TestAccVPCSubnetDataSource_basic
--- PASS: TestAccVPCSubnetCIDRReservation_disappears (42.48s)
=== CONT TestAccVPCSubnetCIDRReservation_ipv6
--- PASS: TestAccVPCSubnetDataSource_basic (43.64s)
--- PASS: TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock (78.47s)
--- PASS: TestAccVPCSubnetCIDRReservation_ipv6 (52.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 774.628s
This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
enabling dns64 and resource_name_dns_aaaa_record_on_launch, need IPv6 CIDR block.
Relations
Closes #32897
References
Output from Acceptance Testing