Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation update for ttl usage in dynamodb_table #32957

Closed

Conversation

kennethjmyers
Copy link

Description

This PR provides clarification on the use of ttl (time to live) in dynamodb_table. Many people seem to encounter an error due to a commonly copied documentation example.

Relations

Closes #10304

References

AWS docs on time to live (ttl). When ttl is disabled there is no need for an attribute name. Thus any passed value is ignored leading to subsequent applies having issues.

I further explained how I diagnosed this here.

Output from Acceptance Testing

N/A, documentation

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Aug 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @kennethjmyers 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 17, 2023
@justinretzolk
Copy link
Member

While I'm tempted to approve/merge this in, I'd like to wait for someone on the team to take a look and determine if this is the correct route, or if we'd prefer to modify the resource's underlying code to make this a bit more intuitive.

@kennethjmyers
Copy link
Author

I understand and agree that would be a better direction. I'm new to terraform and I would have tried that but I don't have the time to learn everything to do that. Hopefully it's an easy fix for the team.

@justinretzolk
Copy link
Member

No worries at all @kennethjmyers! If it ends up being something that we're not able to address quickly, updating the docs with the information is definitely a good idea. Thank you for your contribution either way! 🚀

@gdavison gdavison self-assigned this Jun 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
@gdavison
Copy link
Contributor

Thanks for submitting this, @kennethjmyers. I've created #37991 which addresses the underlying bug, so I'll close this PR

@gdavison gdavison closed this Jun 15, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dynamodb_table - with ttl disabled, can't "terraform apply" twice
3 participants