-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation update for ttl usage in dynamodb_table #32957
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @kennethjmyers 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
While I'm tempted to approve/merge this in, I'd like to wait for someone on the team to take a look and determine if this is the correct route, or if we'd prefer to modify the resource's underlying code to make this a bit more intuitive. |
I understand and agree that would be a better direction. I'm new to terraform and I would have tried that but I don't have the time to learn everything to do that. Hopefully it's an easy fix for the team. |
No worries at all @kennethjmyers! If it ends up being something that we're not able to address quickly, updating the docs with the information is definitely a good idea. Thank you for your contribution either way! 🚀 |
Thanks for submitting this, @kennethjmyers. I've created #37991 which addresses the underlying bug, so I'll close this PR |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR provides clarification on the use of
ttl
(time to live) indynamodb_table
. Many people seem to encounter an error due to a commonly copied documentation example.Relations
Closes #10304
References
AWS docs on time to live (ttl). When ttl is disabled there is no need for an attribute name. Thus any passed value is ignored leading to subsequent applies having issues.
I further explained how I diagnosed this here.
Output from Acceptance Testing
N/A, documentation