Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_quicksight: convert permissions to type set #33023

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 15, 2023

Description

Converts the permissions block to a set type for the QuickSight Analysis, Dashboard, and Template resources.

Relations

Closes #32991
Relates #32984

References

Output from Acceptance Testing

% make testacc PKG=quicksight TESTARGS="-run TestAccQuickSightAnalysis_\|TestAccQuickSightDashboard_\|TestAccQuickSightTemplate_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20  -run TestAccQuickSightAnalysis_\|TestAccQuickSightDashboard_\|TestAccQuickSightTemplate_ -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightTemplate_disappears (76.88s)
--- PASS: TestAccQuickSightTemplate_barChart (83.67s)
--- PASS: TestAccQuickSightTemplate_basic (88.05s)
--- PASS: TestAccQuickSightDashboard_disappears (89.54s)
--- PASS: TestAccQuickSightAnalysis_forceDelete (90.34s)
--- PASS: TestAccQuickSightAnalysis_disappears (91.84s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (95.67s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (96.51s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (100.00s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (102.13s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (103.77s)
--- PASS: TestAccQuickSightDashboard_basic (105.08s)
--- PASS: TestAccQuickSightAnalysis_basic (105.81s)
--- PASS: TestAccQuickSightTemplate_table (120.10s)
--- PASS: TestAccQuickSightTemplate_update (132.67s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (148.41s)
--- PASS: TestAccQuickSightAnalysis_update (148.46s)
--- PASS: TestAccQuickSightTemplate_tags (154.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 157.245s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/quicksight Issues and PRs that pertain to the quicksight service. labels Aug 15, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 43c2495 into main Aug 15, 2023
@jar-b jar-b deleted the b-aws_quicksight-permissions-set branch August 15, 2023 20:22
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 15, 2023
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/quicksight Issues and PRs that pertain to the quicksight service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants