Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_securityhub_account: Remove default value for control_finding_generator #33095

Merged
merged 7 commits into from
Aug 21, 2023
Merged

r/aws_securityhub_account: Remove default value for control_finding_generator #33095

merged 7 commits into from
Aug 21, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Relations

Closes #33039.
Closes #31822.
Closes #30980.

Output from Acceptance Testing

AWS Commercial
% make testacc TESTARGS='-run=TestAccSecurityHub_serial/^Account$$' PKG=securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20  -run=TestAccSecurityHub_serial/^Account$ -timeout 180m
=== RUN   TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT  TestAccSecurityHub_serial
=== RUN   TestAccSecurityHub_serial/Account
=== RUN   TestAccSecurityHub_serial/Account/disappears
=== RUN   TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse
=== RUN   TestAccSecurityHub_serial/Account/MigrateV0
=== RUN   TestAccSecurityHub_serial/Account/Full
=== RUN   TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue
=== RUN   TestAccSecurityHub_serial/Account/basic
--- PASS: TestAccSecurityHub_serial (242.74s)
    --- PASS: TestAccSecurityHub_serial/Account (242.74s)
        --- PASS: TestAccSecurityHub_serial/Account/disappears (19.53s)
        --- PASS: TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse (19.65s)
        --- PASS: TestAccSecurityHub_serial/Account/MigrateV0 (64.80s)
        --- PASS: TestAccSecurityHub_serial/Account/Full (39.73s)
        --- PASS: TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue (74.02s)
        --- PASS: TestAccSecurityHub_serial/Account/basic (25.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	247.959s
AWS GovCloud
% make testacc TESTARGS='-run=TestAccSecurityHub_serial/^Account$$' PKG=securityhub      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20  -run=TestAccSecurityHub_serial/^Account$ -timeout 180m
=== RUN   TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT  TestAccSecurityHub_serial
=== RUN   TestAccSecurityHub_serial/Account
=== RUN   TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue
=== RUN   TestAccSecurityHub_serial/Account/basic
=== RUN   TestAccSecurityHub_serial/Account/disappears
=== RUN   TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse
=== RUN   TestAccSecurityHub_serial/Account/MigrateV0
=== RUN   TestAccSecurityHub_serial/Account/Full
    acctest.go:908: skipping tests; current partition (aws-us-gov) not supported
--- PASS: TestAccSecurityHub_serial (177.50s)
    --- PASS: TestAccSecurityHub_serial/Account (177.50s)
        --- PASS: TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue (72.78s)
        --- PASS: TestAccSecurityHub_serial/Account/basic (23.75s)
        --- PASS: TestAccSecurityHub_serial/Account/disappears (20.51s)
        --- PASS: TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse (20.51s)
        --- PASS: TestAccSecurityHub_serial/Account/MigrateV0 (64.57s)
        --- SKIP: TestAccSecurityHub_serial/Account/Full (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	182.803s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/securityhub Issues and PRs that pertain to the securityhub service. labels Aug 18, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 18, 2023
jar-b
jar-b approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccSecurityHub_serial/^Account$$' PKG=securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20  -run=TestAccSecurityHub_serial/^Account$ -timeout 180m
=== RUN   TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT  TestAccSecurityHub_serial
=== RUN   TestAccSecurityHub_serial/Account
=== RUN   TestAccSecurityHub_serial/Account/basic
=== RUN   TestAccSecurityHub_serial/Account/disappears
=== RUN   TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse
=== RUN   TestAccSecurityHub_serial/Account/MigrateV0
=== RUN   TestAccSecurityHub_serial/Account/Full
=== RUN   TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue
--- PASS: TestAccSecurityHub_serial (149.42s)
    --- PASS: TestAccSecurityHub_serial/Account (149.42s)
        --- PASS: TestAccSecurityHub_serial/Account/basic (21.17s)
        --- PASS: TestAccSecurityHub_serial/Account/disappears (13.50s)
        --- PASS: TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse (18.30s)
        --- PASS: TestAccSecurityHub_serial/Account/MigrateV0 (31.71s)
        --- PASS: TestAccSecurityHub_serial/Account/Full (29.56s)
        --- PASS: TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue (35.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/securityhub        152.465s

@ewbankkit ewbankkit merged commit 0182db7 into main Aug 21, 2023
@ewbankkit ewbankkit deleted the b-aws_securityhub_account-4.64.0-regression branch August 21, 2023 21:05
@github-actions github-actions bot added this to the v5.14.0 milestone Aug 21, 2023
github-actions bot pushed a commit that referenced this pull request Aug 21, 2023
Update CHANGELOG.md for #33095
d1fa920
@github-actions
Copy link

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/securityhub Issues and PRs that pertain to the securityhub service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.14.0
3 participants
@ewbankkit @jar-b @justinretzolk