Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_medialive_channel: implement some missing MediaLive channel encoder settings. #33366

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

r/aws_medialive_channel: implement some missing MediaLive channel encoder settings. #33366

wants to merge 2 commits into from
+627 −164

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Sep 8, 2023

Description

Fixes some missing attributes for various schemas in MediaLive channel encoder settings.

Relations

Relates #27824.

References

MediaLive types documentation

Output from Acceptance Testing

I lack privileges to test this.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/medialive Issues and PRs that pertain to the medialive service. labels Sep 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 8, 2023
@gbw gbw force-pushed the f-add_more_medialive_channel_encoder_settings branch from 88756f2 to c0f4fb2 Compare September 8, 2023 07:32
@gbw gbw marked this pull request as ready for review September 8, 2023 07:56
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 11, 2023
@gbw gbw force-pushed the f-add_more_medialive_channel_encoder_settings branch from c0f4fb2 to b7c45a7 Compare October 21, 2023 21:04
@gbw gbw mentioned this pull request Oct 23, 2023
Closed
@gbw gbw force-pushed the f-add_more_medialive_channel_encoder_settings branch from b7c45a7 to 57399d0 Compare October 28, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/medialive Issues and PRs that pertain to the medialive service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbw @justinretzolk