Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_servicequotas: update to aws sdk v2 #33656

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 27, 2023

Description

Updates all servicequotas resources and data sources to AWS Go SDK V2.

Relations

Relates #32976

References

Output from Acceptance Testing

% make testacc PKG=servicequotas
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicequotas/... -v -count 1 -parallel 20   -timeout 360m

=== RUN   TestAccServiceQuotasServiceQuota_Value_increaseOnCreate
    service_quota_test.go:146: Environment variable SERVICEQUOTAS_INCREASE_ON_CREATE_QUOTA_CODE is not set. WARNING: This test will submit a real service quota increase!
--- SKIP: TestAccServiceQuotasServiceQuota_Value_increaseOnCreate (0.00s)
=== RUN   TestAccServiceQuotasServiceQuota_Value_increaseOnUpdate
    service_quota_test.go:190: Environment variable SERVICEQUOTAS_INCREASE_ON_UPDATE_QUOTA_CODE is not set. WARNING: This test will submit a real service quota increase!
--- SKIP: TestAccServiceQuotasServiceQuota_Value_increaseOnUpdate (0.00s)
=== NAME  TestAccServiceQuotasServiceQuotaDataSource_PermissionError_quotaCode
    acctest.go:1629: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccServiceQuotasServiceQuotaDataSource_PermissionError_quotaCode (0.22s)
=== NAME  TestAccServiceQuotasServiceQuotaDataSource_PermissionError_quotaName
    acctest.go:1629: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccServiceQuotasServiceQuotaDataSource_PermissionError_quotaName (0.23s)
=== NAME  TestAccServiceQuotasServiceQuota_permissionError
    acctest.go:1629: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccServiceQuotasServiceQuota_permissionError (0.23s)
--- PASS: TestAccServiceQuotasServiceQuotaDataSource_quotaCode_Unset (20.21s)
--- PASS: TestAccServiceQuotasServiceQuotaDataSource_quotaCode_hasUsageMetric (20.74s)
--- PASS: TestAccServiceQuotasServiceQuotaDataSource_quotaCode (21.07s)
--- PASS: TestAccServiceQuotasServiceQuotaDataSource_quotaName (21.29s)
--- PASS: TestAccServiceQuotasServiceQuotaDataSource_quotaName_Unset (21.29s)
--- PASS: TestAccServiceQuotasServiceQuotaDataSource_quotaName_hasUsageMetric (21.59s)
--- PASS: TestAccServiceQuotasServiceDataSource_serviceName (22.19s)
--- PASS: TestAccServiceQuotasServiceQuota_basic_Unset (24.54s)
--- PASS: TestAccServiceQuotasServiceQuota_basic (24.57s)
--- PASS: TestAccServiceQuotasServiceQuota_basic_hasUsageMetric (25.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      28.544s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicequotas Issues and PRs that pertain to the servicequotas service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Sep 27, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 27, 2023
@jar-b jar-b force-pushed the td-servicequotas-aws-sdkv2 branch from 44fa5f5 to dd98188 Compare September 27, 2023 20:37
@jar-b jar-b force-pushed the td-servicequotas-aws-sdkv2 branch from dd98188 to 9f1aa87 Compare September 28, 2023 17:34
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit a154e1b into main Sep 29, 2023
41 checks passed
@jar-b jar-b deleted the td-servicequotas-aws-sdkv2 branch September 29, 2023 13:48
@github-actions github-actions bot added this to the v5.20.0 milestone Sep 29, 2023
github-actions bot pushed a commit that referenced this pull request Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/servicequotas Issues and PRs that pertain to the servicequotas service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants