Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with terraform-plugin-framework@v1.4.1 #33865

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 10, 2023

Description

Addresses potential provider initialization errors when using Terraform 1.6.

Relations

Relates hashicorp/terraform-plugin-framework#852.
Relates hashicorp/terraform-plugin-framework#853.
Relates hashicorp/terraform#33990.
Relates #33849.

Output from Acceptance Testing

Terraform v1.0.11

% make testacc TESTARGS='-run=TestAccMetaARNDataSource_' PKG=meta
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20  -run=TestAccMetaARNDataSource_ -timeout 360m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaARNDataSource_basic (17.20s)
--- PASS: TestAccMetaARNDataSource_s3Bucket (17.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	22.366s

Terraform v1.6.0

% make testacc TESTARGS='-run=TestAccMetaARNDataSource_' PKG=meta
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20  -run=TestAccMetaARNDataSource_ -timeout 360m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== RUN   TestAccMetaARNDataSource_s3Bucket
=== PAUSE TestAccMetaARNDataSource_s3Bucket
=== CONT  TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaARNDataSource_s3Bucket
--- PASS: TestAccMetaARNDataSource_basic (51.61s)
--- PASS: TestAccMetaARNDataSource_s3Bucket (51.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	56.865s

dependabot bot and others added 2 commits October 10, 2023 10:52

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
Bumps the terraform-devex group with 1 update: [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework).

- [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-framework@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-framework
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: terraform-devex
...

Signed-off-by: dependabot[bot] <support@github.com>

Verified

This commit was signed with the committer’s verified signature.
ewbankkit Kit Ewbank
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 10, 2023
@ewbankkit ewbankkit added the upstream-terraform Addresses functionality related to the Terraform core binary. label Oct 10, 2023
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Oct 10, 2023
@ewbankkit ewbankkit added this to the v5.20.1 milestone Oct 10, 2023
@ewbankkit ewbankkit merged commit 1e981db into release/5.20.x Oct 10, 2023
89 checks passed
@ewbankkit ewbankkit deleted the td-terraform-plugin-framework-tf1.6 branch October 10, 2023 15:21
@github-actions
Copy link

This functionality has been released in v5.20.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. upstream-terraform Addresses functionality related to the Terraform core binary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant