-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data source cognito_user_group
+ cognito_user_groups
#34046
Conversation
Community NoteVoting for Prioritization
For Submitters
|
cognito_user_group
+ cognito_user_groups
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
|
Sdk-v2 client generation had issues with tests missing a required input, MaxResults. Instead of trying to fix that, I backed out the sdkv2 library change, but left a 🌱 for when it gets migrated over to sdk-v2. It should be as simple as switching the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=cognitoidp TESTS="TestAccCognitoIDPUserGroupDataSource_|TestAccCognitoIDPUserGroupsDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserGroupDataSource_|TestAccCognitoIDPUserGroupsDataSource_' -timeout 360m
--- PASS: TestAccCognitoIDPUserGroupsDataSource_basic (13.79s)
--- PASS: TestAccCognitoIDPUserGroupDataSource_basic (13.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 21.121s
Thanks for your contribution, @danquack! 👍 |
This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Creates data sources to get an individual user group or a list of the user groups.
Relations
Closes #34024
References
Output from Acceptance Testing