Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data source cognito_user_group + cognito_user_groups #34046

Merged
merged 17 commits into from
Feb 22, 2024
Merged

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Oct 21, 2023

Description

Creates data sources to get an individual user group or a list of the user groups.

Relations

Closes #34024

References

Output from Acceptance Testing

# TF_ACC=1 make testacc TESTS=TestAccCognitoIDPUserGroupDataSource_basic PKG=cognitoidp 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserGroupDataSource_basic'  -timeout 360m
=== RUN   TestAccCognitoIDPUserGroupDataSource_basic
=== PAUSE TestAccCognitoIDPUserGroupDataSource_basic
=== CONT  TestAccCognitoIDPUserGroupDataSource_basic
--- PASS: TestAccCognitoIDPUserGroupDataSource_basic (20.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 23.158s

# TF_ACC=1 make testacc TESTS=TestAccCognitoIDPUserGroupsDataSource_basic PKG=cognitoidp   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserGroupsDataSource_basic'  -timeout 360m
=== RUN   TestAccCognitoIDPUserGroupsDataSource_basic
=== PAUSE TestAccCognitoIDPUserGroupsDataSource_basic
=== CONT  TestAccCognitoIDPUserGroupsDataSource_basic
--- PASS: TestAccCognitoIDPUserGroupsDataSource_basic (20.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 22.588s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Oct 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2023
@danquack danquack changed the title Create user group data sources d/cognito_user_group d/cognito_user_groups Oct 21, 2023
@danquack danquack changed the title d/cognito_user_group d/cognito_user_groups data source cognito_user_group + cognito_user_groups Oct 21, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 23, 2023
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added the client-connections Pertains to the AWS Client and service connections. label Feb 21, 2024
@danquack
Copy link
Contributor Author

~ TF_ACC=1 make testacc TESTS=TestAccCognitoIDPUserGroupDataSource_basic PKG=cognitoidp               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserGroupDataSource_basic'  -timeout 360m
=== RUN   TestAccCognitoIDPUserGroupDataSource_basic
=== PAUSE TestAccCognitoIDPUserGroupDataSource_basic
=== CONT  TestAccCognitoIDPUserGroupDataSource_basic
--- PASS: TestAccCognitoIDPUserGroupDataSource_basic (15.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 21.044s
~ TF_ACC=1 make testacc TESTS=TestAccCognitoIDPUserGroupsDataSource_basic PKG=cognitoidp              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserGroupsDataSource_basic'  -timeout 360m
=== RUN   TestAccCognitoIDPUserGroupsDataSource_basic
=== PAUSE TestAccCognitoIDPUserGroupsDataSource_basic
=== CONT  TestAccCognitoIDPUserGroupsDataSource_basic
--- PASS: TestAccCognitoIDPUserGroupsDataSource_basic (15.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 20.517s

@danquack
Copy link
Contributor Author

Sdk-v2 client generation had issues with tests missing a required input, MaxResults. Instead of trying to fix that, I backed out the sdkv2 library change, but left a 🌱 for when it gets migrated over to sdk-v2. It should be as simple as switching the client.

@jar-b jar-b self-assigned this Feb 22, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 22, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=cognitoidp TESTS="TestAccCognitoIDPUserGroupDataSource_|TestAccCognitoIDPUserGroupsDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserGroupDataSource_|TestAccCognitoIDPUserGroupsDataSource_'  -timeout 360m

--- PASS: TestAccCognitoIDPUserGroupsDataSource_basic (13.79s)
--- PASS: TestAccCognitoIDPUserGroupDataSource_basic (13.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 21.121s

@jar-b
Copy link
Member

jar-b commented Feb 22, 2024

Thanks for your contribution, @danquack! 👍

@jar-b jar-b merged commit a672b65 into hashicorp:main Feb 22, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.38.0 milestone Feb 22, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 23, 2024
Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_cognito_user_group
3 participants