Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Udpate EKS to use aws-sdk-go-v2 #34114

Merged
merged 47 commits into from
Nov 8, 2023

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update EKS service to utilize the AWS SDK Go v2

Relations

Relates #32976

References

Output from Acceptance Testing

GOPROXY=direct make testacc TESTARGS='-run=TestAccEKS' PKG=eks ACCTEST_PARALLELISM=6
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 6  -run=TestAccEKS -timeout 360m
=== RUN   TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== RUN   TestAccEKSAddonDataSource_configurationValues
=== PAUSE TestAccEKSAddonDataSource_configurationValues
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN   TestAccEKSAddon_disappears
=== PAUSE TestAccEKSAddon_disappears
=== RUN   TestAccEKSAddon_Disappears_cluster
=== PAUSE TestAccEKSAddon_Disappears_cluster
=== RUN   TestAccEKSAddon_addonVersion
=== PAUSE TestAccEKSAddon_addonVersion
=== RUN   TestAccEKSAddon_preserve
=== PAUSE TestAccEKSAddon_preserve
=== RUN   TestAccEKSAddon_deprecated
=== PAUSE TestAccEKSAddon_deprecated
=== RUN   TestAccEKSAddon_resolveConflicts
=== PAUSE TestAccEKSAddon_resolveConflicts
=== RUN   TestAccEKSAddon_serviceAccountRoleARN
=== PAUSE TestAccEKSAddon_serviceAccountRoleARN
=== RUN   TestAccEKSAddon_configurationValues
=== PAUSE TestAccEKSAddon_configurationValues
=== RUN   TestAccEKSAddon_tags
=== PAUSE TestAccEKSAddon_tags
=== RUN   TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== RUN   TestAccEKSClusterAuthDataSource_basic
=== PAUSE TestAccEKSClusterAuthDataSource_basic
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN   TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN   TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN   TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN   TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN   TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN   TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN   TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN   TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN   TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN   TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN   TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== RUN   TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== RUN   TestAccEKSCluster_Outpost_placement
=== PAUSE TestAccEKSCluster_Outpost_placement
=== RUN   TestAccEKSClustersDataSource_basic
=== PAUSE TestAccEKSClustersDataSource_basic
=== RUN   TestAccEKSFargateProfile_basic
=== PAUSE TestAccEKSFargateProfile_basic
=== RUN   TestAccEKSFargateProfile_disappears
=== PAUSE TestAccEKSFargateProfile_disappears
=== RUN   TestAccEKSFargateProfile_Multi_profile
=== PAUSE TestAccEKSFargateProfile_Multi_profile
=== RUN   TestAccEKSFargateProfile_Selector_labels
=== PAUSE TestAccEKSFargateProfile_Selector_labels
=== RUN   TestAccEKSFargateProfile_tags
=== PAUSE TestAccEKSFargateProfile_tags
=== RUN   TestAccEKSIdentityProviderConfig_basic
=== PAUSE TestAccEKSIdentityProviderConfig_basic
=== RUN   TestAccEKSIdentityProviderConfig_disappears
=== PAUSE TestAccEKSIdentityProviderConfig_disappears
=== RUN   TestAccEKSIdentityProviderConfig_allOIDCOptions
=== PAUSE TestAccEKSIdentityProviderConfig_allOIDCOptions
=== RUN   TestAccEKSIdentityProviderConfig_tags
=== PAUSE TestAccEKSIdentityProviderConfig_tags
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1348.51s)
=== RUN   TestAccEKSNodeGroup_basic
=== PAUSE TestAccEKSNodeGroup_basic
=== RUN   TestAccEKSNodeGroup_Name_generated
=== PAUSE TestAccEKSNodeGroup_Name_generated
=== RUN   TestAccEKSNodeGroup_namePrefix
=== PAUSE TestAccEKSNodeGroup_namePrefix
=== RUN   TestAccEKSNodeGroup_disappears
=== PAUSE TestAccEKSNodeGroup_disappears
=== RUN   TestAccEKSNodeGroup_amiType
=== PAUSE TestAccEKSNodeGroup_amiType
=== RUN   TestAccEKSNodeGroup_CapacityType_spot
=== PAUSE TestAccEKSNodeGroup_CapacityType_spot
=== RUN   TestAccEKSNodeGroup_diskSize
=== PAUSE TestAccEKSNodeGroup_diskSize
=== RUN   TestAccEKSNodeGroup_forceUpdateVersion
=== PAUSE TestAccEKSNodeGroup_forceUpdateVersion
=== RUN   TestAccEKSNodeGroup_InstanceTypes_multiple
=== PAUSE TestAccEKSNodeGroup_InstanceTypes_multiple
=== RUN   TestAccEKSNodeGroup_InstanceTypes_single
=== PAUSE TestAccEKSNodeGroup_InstanceTypes_single
=== RUN   TestAccEKSNodeGroup_labels
=== PAUSE TestAccEKSNodeGroup_labels
=== RUN   TestAccEKSNodeGroup_LaunchTemplate_id
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_id
=== RUN   TestAccEKSNodeGroup_LaunchTemplate_name
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_name
=== RUN   TestAccEKSNodeGroup_LaunchTemplate_version
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_version
=== RUN   TestAccEKSNodeGroup_releaseVersion
=== PAUSE TestAccEKSNodeGroup_releaseVersion
=== RUN   TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
=== PAUSE TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
=== RUN   TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
=== PAUSE TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
=== RUN   TestAccEKSNodeGroup_Scaling_desiredSize
=== PAUSE TestAccEKSNodeGroup_Scaling_desiredSize
=== RUN   TestAccEKSNodeGroup_Scaling_maxSize
=== PAUSE TestAccEKSNodeGroup_Scaling_maxSize
=== RUN   TestAccEKSNodeGroup_Scaling_minSize
=== PAUSE TestAccEKSNodeGroup_Scaling_minSize
=== RUN   TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
=== PAUSE TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
=== RUN   TestAccEKSNodeGroup_tags
=== PAUSE TestAccEKSNodeGroup_tags
=== RUN   TestAccEKSNodeGroup_taints
=== PAUSE TestAccEKSNodeGroup_taints
=== RUN   TestAccEKSNodeGroup_update
=== PAUSE TestAccEKSNodeGroup_update
=== RUN   TestAccEKSNodeGroup_version
=== PAUSE TestAccEKSNodeGroup_version
=== RUN   TestAccEKSNodeGroupsDataSource_basic
--- PASS: TestAccEKSNodeGroupsDataSource_basic (1471.81s)
=== CONT  TestAccEKSAddonDataSource_basic
=== CONT  TestAccEKSFargateProfile_disappears
=== CONT  TestAccEKSNodeGroup_InstanceTypes_single
=== CONT  TestAccEKSFargateProfile_basic
=== CONT  TestAccEKSNodeGroup_InstanceTypes_multiple
=== CONT  TestAccEKSIdentityProviderConfig_tags
--- PASS: TestAccEKSAddonDataSource_basic (717.84s)
=== CONT  TestAccEKSNodeGroup_version
--- PASS: TestAccEKSFargateProfile_basic (1059.10s)
=== CONT  TestAccEKSNodeGroup_update
--- PASS: TestAccEKSNodeGroup_InstanceTypes_single (1124.42s)
=== CONT  TestAccEKSNodeGroup_taints
--- PASS: TestAccEKSNodeGroup_InstanceTypes_multiple (1375.50s)
=== CONT  TestAccEKSNodeGroup_tags
--- PASS: TestAccEKSFargateProfile_disappears (1477.72s)
=== CONT  TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
--- PASS: TestAccEKSIdentityProviderConfig_tags (1679.90s)
=== CONT  TestAccEKSNodeGroup_Scaling_minSize
--- PASS: TestAccEKSNodeGroup_taints (1166.10s)
=== CONT  TestAccEKSNodeGroup_Scaling_maxSize
--- PASS: TestAccEKSNodeGroup_update (1242.23s)
=== CONT  TestAccEKSNodeGroup_Scaling_desiredSize
--- PASS: TestAccEKSNodeGroup_tags (1155.52s)
=== CONT  TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
--- PASS: TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize (1170.65s)
=== CONT  TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
--- PASS: TestAccEKSNodeGroup_version (2368.55s)
=== CONT  TestAccEKSNodeGroup_releaseVersion
--- PASS: TestAccEKSNodeGroup_Scaling_minSize (1438.46s)
=== CONT  TestAccEKSNodeGroup_LaunchTemplate_version
--- PASS: TestAccEKSNodeGroup_Scaling_desiredSize (1385.60s)
=== CONT  TestAccEKSNodeGroup_LaunchTemplate_name
--- PASS: TestAccEKSNodeGroup_Scaling_maxSize (1502.25s)
=== CONT  TestAccEKSNodeGroup_LaunchTemplate_id
--- PASS: TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey (1315.17s)
=== CONT  TestAccEKSNodeGroup_labels
=== NAME  TestAccEKSNodeGroup_releaseVersion
    node_group_test.go:523: Step 3/3 error: Error running apply: exit status 1

        Error: updating EKS Cluster (tf-acc-test-8626296831620681440) version: operation error EKS: UpdateClusterVersion, https response error StatusCode: 409, RequestID: 6a61c486-e7fa-4fd2-bc10-17dcfcbfd4b5, ResourceInUseException: Cannot VersionUpdate because cluster tf-acc-test-8626296831620681440 currently has update cb4264fb-d228-4228-9313-6b2af766b309 in progress

          with aws_eks_cluster.test,
          on terraform_plugin_test.tf line 140, in resource "aws_eks_cluster" "test":
         140: resource "aws_eks_cluster" "test" {

--- PASS: TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs (1581.25s)
=== CONT  TestAccEKSClusterDataSource_basic
--- FAIL: TestAccEKSNodeGroup_releaseVersion (1443.63s)
=== CONT  TestAccEKSClusterAuthDataSource_basic
--- PASS: TestAccEKSClusterAuthDataSource_basic (11.73s)
=== CONT  TestAccEKSAddonVersionDataSource_basic
    addon_version_data_source_test.go:25: Step 2/2 error: Error running apply: exit status 1

        Error: updating EKS Add-On (tf-acc-test-3426220950201579089:vpc-cni): operation error EKS: UpdateAddon, https response error StatusCode: 400, RequestID: 60d82d3e-97c1-4f5d-b92f-e32d42e7a1e5, InvalidParameterException: Updating VPC-CNI can only go up or down 1 minor version at a time

          with aws_eks_addon.test,
          on terraform_plugin_test.tf line 76, in resource "aws_eks_addon" "test":
          76: resource "aws_eks_addon" "test" {

--- PASS: TestAccEKSClusterDataSource_basic (1055.86s)
=== CONT  TestAccEKSAddon_tags
--- FAIL: TestAccEKSAddonVersionDataSource_basic (676.49s)
=== CONT  TestAccEKSAddon_configurationValues
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_version (2272.94s)
=== CONT  TestAccEKSAddon_serviceAccountRoleARN
--- PASS: TestAccEKSNodeGroup_labels (1771.28s)
=== CONT  TestAccEKSAddon_resolveConflicts
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_name (2127.40s)
=== CONT  TestAccEKSAddon_deprecated
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_id (2074.07s)
=== CONT  TestAccEKSAddon_preserve
--- PASS: TestAccEKSAddon_configurationValues (690.93s)
=== CONT  TestAccEKSAddon_addonVersion
--- PASS: TestAccEKSAddon_tags (835.27s)
=== CONT  TestAccEKSAddon_Disappears_cluster
--- PASS: TestAccEKSAddon_serviceAccountRoleARN (843.47s)
=== CONT  TestAccEKSAddon_disappears
--- PASS: TestAccEKSAddon_resolveConflicts (592.36s)
=== CONT  TestAccEKSAddon_basic
--- PASS: TestAccEKSAddon_preserve (640.44s)
=== CONT  TestAccEKSAddonDataSource_configurationValues
--- PASS: TestAccEKSAddon_deprecated (711.01s)
=== CONT  TestAccEKSClusterDataSource_outpost
    acctest.go:1127: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.89s)
=== CONT  TestAccEKSClustersDataSource_basic
--- PASS: TestAccEKSAddon_addonVersion (654.91s)
=== CONT  TestAccEKSCluster_Outpost_placement
    acctest.go:1127: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_placement (0.22s)
=== CONT  TestAccEKSCluster_Outpost_create
    acctest.go:1127: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_create (0.20s)
=== CONT  TestAccEKSCluster_Network_ipFamily
    cluster_test.go:582: Step 1/6, expected an error with pattern, no match on: Error running pre-apply refresh: exit status 1

        Error: expected ip_family to be one of ["ipv4" "ipv6"], got v6

          with aws_eks_cluster.test,
          on terraform_plugin_test.tf line 73, in resource "aws_eks_cluster" "test":
          73:     ip_family = "v6"

--- FAIL: TestAccEKSCluster_Network_ipFamily (1.28s)
=== CONT  TestAccEKSCluster_Network_serviceIPv4CIDR
--- PASS: TestAccEKSAddon_Disappears_cluster (673.13s)
=== CONT  TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSAddon_disappears (674.23s)
=== CONT  TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSClustersDataSource_basic (587.69s)
=== CONT  TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSAddonDataSource_configurationValues (617.07s)
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs
--- PASS: TestAccEKSAddon_basic (855.87s)
=== CONT  TestAccEKSCluster_tags
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (955.80s)
=== CONT  TestAccEKSCluster_logging
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (626.32s)
=== CONT  TestAccEKSCluster_version
=== NAME  TestAccEKSCluster_Network_serviceIPv4CIDR
    cluster_test.go:519: Step 9/9 error: Check failed: Check 2/4 error: EKS Cluster was not recreated
--- PASS: TestAccEKSCluster_tags (698.30s)
=== CONT  TestAccEKSCluster_Encryption_versionUpdate
--- FAIL: TestAccEKSCluster_Network_serviceIPv4CIDR (1383.84s)
=== CONT  TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1301.59s)
=== CONT  TestAccEKSCluster_Encryption_create
--- PASS: TestAccEKSCluster_logging (837.07s)
=== CONT  TestAccEKSCluster_disappears
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1706.00s)
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_Encryption_create (646.03s)
=== CONT  TestAccEKSNodeGroup_amiType
--- PASS: TestAccEKSCluster_version (1231.63s)
=== CONT  TestAccEKSNodeGroup_forceUpdateVersion
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1216.89s)
=== CONT  TestAccEKSNodeGroup_diskSize
--- PASS: TestAccEKSCluster_disappears (891.42s)
=== CONT  TestAccEKSNodeGroup_CapacityType_spot
=== CONT  TestAccEKSNodeGroup_namePrefix
--- PASS: TestAccEKSCluster_basic (721.35s)
=== CONT  TestAccEKSNodeGroup_disappears
--- PASS: TestAccEKSCluster_Encryption_update (1764.51s)
--- PASS: TestAccEKSNodeGroup_diskSize (1315.48s)
=== CONT  TestAccEKSFargateProfile_Selector_labels
--- PASS: TestAccEKSNodeGroup_CapacityType_spot (1335.09s)
=== CONT  TestAccEKSIdentityProviderConfig_allOIDCOptions
--- PASS: TestAccEKSNodeGroup_amiType (1842.36s)
=== CONT  TestAccEKSIdentityProviderConfig_disappears
--- PASS: TestAccEKSNodeGroup_namePrefix (1394.97s)
=== CONT  TestAccEKSIdentityProviderConfig_basic
--- PASS: TestAccEKSNodeGroup_forceUpdateVersion (2135.77s)
=== CONT  TestAccEKSFargateProfile_tags
--- PASS: TestAccEKSNodeGroup_disappears (1486.22s)
=== CONT  TestAccEKSFargateProfile_Multi_profile
--- PASS: TestAccEKSFargateProfile_Selector_labels (1068.15s)
=== CONT  TestAccEKSNodeGroup_Name_generated
--- PASS: TestAccEKSFargateProfile_tags (1099.85s)
=== CONT  TestAccEKSNodeGroup_basic
--- PASS: TestAccEKSIdentityProviderConfig_disappears (1629.81s)
--- PASS: TestAccEKSIdentityProviderConfig_allOIDCOptions (1658.13s)
--- PASS: TestAccEKSFargateProfile_Multi_profile (1183.31s)
--- PASS: TestAccEKSIdentityProviderConfig_basic (1537.19s)
--- PASS: TestAccEKSNodeGroup_Name_generated (1370.64s)
--- PASS: TestAccEKSNodeGroup_basic (1445.47s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/eks	16487.381s
FAIL
make: *** [testacc] Error 1

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. labels Oct 25, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 25, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@bryantbiggs
Copy link
Contributor Author

  • TestAccEKSCluster_Network_ipFamily - not sure why this is failing
  • TestAccEKSNodeGroup_releaseVersion - I started to put a retry in here when resource in use exception was caught, but that seems dangerous since the amount of time that a nodegroup might be updating is unknown (can be quite long if the number of nodes is quite high and take awhile to upgrade). Thoughts?
  • TestAccEKSAddonVersionDataSource_basic - not sure on this one either, the values specified are only 1 minor version apart. This test in general is also at risk of being flaky since an addons default version is not guarnateed to be 1 minor version away from the latest version. The latest version could be +2 or more minor versions greater than the default version, but for 1.28 currently, there is only a 1 minor version difference so this should be passing

@jar-b jar-b added service/eks Issues and PRs that pertain to the eks service. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 6, 2023
@ewbankkit ewbankkit force-pushed the refactor/eks-aws-sdk-go-v2 branch from 2a3cc81 to 9d99201 Compare November 7, 2023 22:10
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSTSCallerIdentityDataSource_' PKG=sts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sts/... -v -count 1 -parallel 20  -run=TestAccSTSCallerIdentityDataSource_ -timeout 360m
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (15.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	20.899s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEKSCluster' PKG=eks ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 4  -run=TestAccEKSCluster -timeout 720m
=== RUN   TestAccEKSClusterAuthDataSource_basic
=== PAUSE TestAccEKSClusterAuthDataSource_basic
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSClusterDataSource_outpost
=== PAUSE TestAccEKSClusterDataSource_outpost
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN   TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN   TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN   TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN   TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN   TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN   TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN   TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
=== RUN   TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN   TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN   TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN   TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN   TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== RUN   TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== RUN   TestAccEKSCluster_Outpost_placement
=== PAUSE TestAccEKSCluster_Outpost_placement
=== RUN   TestAccEKSClustersDataSource_basic
=== PAUSE TestAccEKSClustersDataSource_basic
=== CONT  TestAccEKSClusterAuthDataSource_basic
=== CONT  TestAccEKSClustersDataSource_basic
=== CONT  TestAccEKSCluster_tags
=== CONT  TestAccEKSCluster_Encryption_create
--- PASS: TestAccEKSClusterAuthDataSource_basic (18.57s)
=== CONT  TestAccEKSCluster_logging
--- PASS: TestAccEKSCluster_logging (917.81s)
=== CONT  TestAccEKSCluster_version
--- PASS: TestAccEKSCluster_version (1255.65s)
=== CONT  TestAccEKSCluster_Encryption_versionUpdate
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1258.63s)
=== CONT  TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSClustersDataSource_basic (580.01s)
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_tags (582.66s)
=== CONT  TestAccEKSCluster_disappears
--- PASS: TestAccEKSCluster_Encryption_create (635.32s)
=== CONT  TestAccEKSClusterDataSource_basic
--- PASS: TestAccEKSClusterDataSource_basic (559.13s)
=== CONT  TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSCluster_basic (612.81s)
=== CONT  TestAccEKSCluster_Outpost_placement
    acctest.go:1137: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_placement (0.47s)
=== CONT  TestAccEKSCluster_Outpost_create
    acctest.go:1137: skipping since no Outposts found
--- SKIP: TestAccEKSCluster_Outpost_create (0.19s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1321.66s)
=== CONT  TestAccEKSCluster_Network_serviceIPv4CIDR
--- PASS: TestAccEKSCluster_disappears (799.40s)
=== CONT  TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (965.18s)
=== CONT  TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSCluster_Encryption_update (1507.48s)
=== CONT  TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1145.62s)
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1127.09s)
=== CONT  TestAccEKSClusterDataSource_outpost
    acctest.go:1137: skipping since no Outposts found
--- SKIP: TestAccEKSClusterDataSource_outpost (0.46s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1560.28s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (617.04s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1459.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	3101.992s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEKSAddon\|TestAccEKSFargateProfile_\|TestAccEKSIdentityProviderConfig_' PKG=eks ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 4  -run=TestAccEKSAddon\|TestAccEKSFargateProfile_\|TestAccEKSIdentityProviderConfig_ -timeout 720m
=== RUN   TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== RUN   TestAccEKSAddonDataSource_configurationValues
=== PAUSE TestAccEKSAddonDataSource_configurationValues
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN   TestAccEKSAddon_disappears
=== PAUSE TestAccEKSAddon_disappears
=== RUN   TestAccEKSAddon_Disappears_cluster
=== PAUSE TestAccEKSAddon_Disappears_cluster
=== RUN   TestAccEKSAddon_addonVersion
=== PAUSE TestAccEKSAddon_addonVersion
=== RUN   TestAccEKSAddon_preserve
=== PAUSE TestAccEKSAddon_preserve
=== RUN   TestAccEKSAddon_deprecated
=== PAUSE TestAccEKSAddon_deprecated
=== RUN   TestAccEKSAddon_resolveConflicts
=== PAUSE TestAccEKSAddon_resolveConflicts
=== RUN   TestAccEKSAddon_serviceAccountRoleARN
=== PAUSE TestAccEKSAddon_serviceAccountRoleARN
=== RUN   TestAccEKSAddon_configurationValues
=== PAUSE TestAccEKSAddon_configurationValues
=== RUN   TestAccEKSAddon_tags
=== PAUSE TestAccEKSAddon_tags
=== RUN   TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== RUN   TestAccEKSFargateProfile_basic
=== PAUSE TestAccEKSFargateProfile_basic
=== RUN   TestAccEKSFargateProfile_disappears
=== PAUSE TestAccEKSFargateProfile_disappears
=== RUN   TestAccEKSFargateProfile_Multi_profile
=== PAUSE TestAccEKSFargateProfile_Multi_profile
=== RUN   TestAccEKSFargateProfile_Selector_labels
=== PAUSE TestAccEKSFargateProfile_Selector_labels
=== RUN   TestAccEKSFargateProfile_tags
=== PAUSE TestAccEKSFargateProfile_tags
=== RUN   TestAccEKSIdentityProviderConfig_basic
=== PAUSE TestAccEKSIdentityProviderConfig_basic
=== RUN   TestAccEKSIdentityProviderConfig_disappears
=== PAUSE TestAccEKSIdentityProviderConfig_disappears
=== RUN   TestAccEKSIdentityProviderConfig_allOIDCOptions
=== PAUSE TestAccEKSIdentityProviderConfig_allOIDCOptions
=== RUN   TestAccEKSIdentityProviderConfig_tags
=== PAUSE TestAccEKSIdentityProviderConfig_tags
=== CONT  TestAccEKSAddonDataSource_basic
=== CONT  TestAccEKSAddon_tags
=== CONT  TestAccEKSFargateProfile_tags
=== CONT  TestAccEKSIdentityProviderConfig_allOIDCOptions
--- PASS: TestAccEKSAddon_tags (1020.60s)
=== CONT  TestAccEKSIdentityProviderConfig_tags
--- PASS: TestAccEKSAddonDataSource_basic (1179.69s)
=== CONT  TestAccEKSFargateProfile_basic
--- PASS: TestAccEKSFargateProfile_tags (1358.77s)
=== CONT  TestAccEKSFargateProfile_disappears
--- PASS: TestAccEKSIdentityProviderConfig_allOIDCOptions (1833.59s)
=== CONT  TestAccEKSIdentityProviderConfig_disappears
--- PASS: TestAccEKSFargateProfile_basic (893.77s)
=== CONT  TestAccEKSFargateProfile_Selector_labels
--- PASS: TestAccEKSFargateProfile_disappears (885.65s)
=== CONT  TestAccEKSAddonVersionDataSource_basic
--- PASS: TestAccEKSIdentityProviderConfig_tags (1516.83s)
=== CONT  TestAccEKSAddon_preserve
--- PASS: TestAccEKSAddonVersionDataSource_basic (714.46s)
=== CONT  TestAccEKSAddon_configurationValues
--- PASS: TestAccEKSAddon_preserve (537.79s)
=== CONT  TestAccEKSAddon_serviceAccountRoleARN
--- PASS: TestAccEKSFargateProfile_Selector_labels (1079.02s)
=== CONT  TestAccEKSFargateProfile_Multi_profile
--- PASS: TestAccEKSIdentityProviderConfig_disappears (1446.83s)
=== CONT  TestAccEKSAddon_resolveConflicts
--- PASS: TestAccEKSAddonDataSource_configurationValues (726.61s)
=== CONT  TestAccEKSIdentityProviderConfig_basic
--- PASS: TestAccEKSAddon_serviceAccountRoleARN (694.21s)
=== CONT  TestAccEKSAddon_disappears
--- PASS: TestAccEKSAddon_resolveConflicts (598.74s)
=== CONT  TestAccEKSAddon_addonVersion
--- PASS: TestAccEKSFargateProfile_Multi_profile (1050.35s)
=== CONT  TestAccEKSAddon_deprecated
--- PASS: TestAccEKSAddon_disappears (539.71s)
=== CONT  TestAccEKSAddon_Disappears_cluster
--- PASS: TestAccEKSAddon_addonVersion (765.77s)
=== CONT  TestAccEKSAddon_basic
--- PASS: TestAccEKSAddon_Disappears_cluster (596.31s)
=== CONT  TestAccEKSAddonDataSource_configurationValues
--- PASS: TestAccEKSAddon_deprecated (715.09s)
--- PASS: TestAccEKSAddon_basic (598.22s)
--- PASS: TestAccEKSIdentityProviderConfig_basic (1489.65s)
--- PASS: TestAccEKSAddonDataSource_configurationValues (726.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	5516.796s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEKSNodeGroup' PKG=eks ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 4  -run=TestAccEKSNodeGroup -timeout 720m
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1272.58s)
=== RUN   TestAccEKSNodeGroup_basic
=== PAUSE TestAccEKSNodeGroup_basic
=== RUN   TestAccEKSNodeGroup_Name_generated
=== PAUSE TestAccEKSNodeGroup_Name_generated
=== RUN   TestAccEKSNodeGroup_namePrefix
=== PAUSE TestAccEKSNodeGroup_namePrefix
=== RUN   TestAccEKSNodeGroup_disappears
=== PAUSE TestAccEKSNodeGroup_disappears
=== RUN   TestAccEKSNodeGroup_amiType
=== PAUSE TestAccEKSNodeGroup_amiType
=== RUN   TestAccEKSNodeGroup_CapacityType_spot
=== PAUSE TestAccEKSNodeGroup_CapacityType_spot
=== RUN   TestAccEKSNodeGroup_diskSize
=== PAUSE TestAccEKSNodeGroup_diskSize
=== RUN   TestAccEKSNodeGroup_forceUpdateVersion
=== PAUSE TestAccEKSNodeGroup_forceUpdateVersion
=== RUN   TestAccEKSNodeGroup_InstanceTypes_multiple
=== PAUSE TestAccEKSNodeGroup_InstanceTypes_multiple
=== RUN   TestAccEKSNodeGroup_InstanceTypes_single
=== PAUSE TestAccEKSNodeGroup_InstanceTypes_single
=== RUN   TestAccEKSNodeGroup_labels
=== PAUSE TestAccEKSNodeGroup_labels
=== RUN   TestAccEKSNodeGroup_LaunchTemplate_id
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_id
=== RUN   TestAccEKSNodeGroup_LaunchTemplate_name
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_name
=== RUN   TestAccEKSNodeGroup_LaunchTemplate_version
=== PAUSE TestAccEKSNodeGroup_LaunchTemplate_version
=== RUN   TestAccEKSNodeGroup_releaseVersion
=== PAUSE TestAccEKSNodeGroup_releaseVersion
=== RUN   TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
=== PAUSE TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
=== RUN   TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
=== PAUSE TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
=== RUN   TestAccEKSNodeGroup_Scaling_desiredSize
=== PAUSE TestAccEKSNodeGroup_Scaling_desiredSize
=== RUN   TestAccEKSNodeGroup_Scaling_maxSize
=== PAUSE TestAccEKSNodeGroup_Scaling_maxSize
=== RUN   TestAccEKSNodeGroup_Scaling_minSize
=== PAUSE TestAccEKSNodeGroup_Scaling_minSize
=== RUN   TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
=== PAUSE TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
=== RUN   TestAccEKSNodeGroup_tags
=== PAUSE TestAccEKSNodeGroup_tags
=== RUN   TestAccEKSNodeGroup_taints
=== PAUSE TestAccEKSNodeGroup_taints
=== RUN   TestAccEKSNodeGroup_update
=== PAUSE TestAccEKSNodeGroup_update
=== RUN   TestAccEKSNodeGroup_version
=== PAUSE TestAccEKSNodeGroup_version
=== RUN   TestAccEKSNodeGroupsDataSource_basic
--- PASS: TestAccEKSNodeGroupsDataSource_basic (1011.74s)
=== CONT  TestAccEKSNodeGroup_basic
=== CONT  TestAccEKSNodeGroup_LaunchTemplate_version
=== CONT  TestAccEKSNodeGroup_version
=== CONT  TestAccEKSNodeGroup_update
--- PASS: TestAccEKSNodeGroup_basic (1179.98s)
=== CONT  TestAccEKSNodeGroup_taints
--- PASS: TestAccEKSNodeGroup_update (1339.78s)
=== CONT  TestAccEKSNodeGroup_forceUpdateVersion
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_version (1704.22s)
=== CONT  TestAccEKSNodeGroup_tags
--- PASS: TestAccEKSNodeGroup_version (2019.73s)
=== CONT  TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize
--- PASS: TestAccEKSNodeGroup_taints (984.76s)
=== CONT  TestAccEKSNodeGroup_LaunchTemplate_name
--- PASS: TestAccEKSNodeGroup_ScalingZeroDesiredSize_minSize (790.90s)
=== CONT  TestAccEKSNodeGroup_Scaling_minSize
--- PASS: TestAccEKSNodeGroup_tags (1335.89s)
=== CONT  TestAccEKSNodeGroup_LaunchTemplate_id
--- PASS: TestAccEKSNodeGroup_forceUpdateVersion (2426.18s)
=== CONT  TestAccEKSNodeGroup_Scaling_maxSize
--- PASS: TestAccEKSNodeGroup_Scaling_minSize (1192.74s)
=== CONT  TestAccEKSNodeGroup_labels
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_name (1921.76s)
=== CONT  TestAccEKSNodeGroup_Scaling_desiredSize
--- PASS: TestAccEKSNodeGroup_LaunchTemplate_id (1987.45s)
=== CONT  TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs
--- PASS: TestAccEKSNodeGroup_Scaling_maxSize (1300.81s)
=== CONT  TestAccEKSNodeGroup_InstanceTypes_single
--- PASS: TestAccEKSNodeGroup_Scaling_desiredSize (1336.29s)
=== CONT  TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey
--- PASS: TestAccEKSNodeGroup_labels (1597.44s)
=== CONT  TestAccEKSNodeGroup_InstanceTypes_multiple
--- PASS: TestAccEKSNodeGroup_InstanceTypes_single (1245.15s)
=== CONT  TestAccEKSNodeGroup_releaseVersion
    node_group_test.go:523: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
         <= read (data resources)
        
        Terraform will perform the following actions:
        
          # data.aws_ssm_parameter.test will be read during apply
          # (config refers to values not yet known)
         <= data "aws_ssm_parameter" "test"  {
              ~ arn             = "arn:aws:ssm:us-west-2::parameter/aws/service/eks/optimized-ami/1.27/amazon-linux-2/recommended/release_version" -> (known after apply)
              ~ id              = "/aws/service/eks/optimized-ami/1.27/amazon-linux-2/recommended/release_version" -> (known after apply)
              ~ insecure_value  = "1.27.6-20231027" -> (known after apply)
                name            = "/aws/service/eks/optimized-ami/1.27/amazon-linux-2/recommended/release_version"
              ~ type            = "String" -> (known after apply)
              ~ value           = (sensitive value)
              ~ version         = 11 -> (known after apply)
              - with_decryption = true -> null
            }
        
          # aws_eks_cluster.test will be updated in-place
          ~ resource "aws_eks_cluster" "test" {
                id                    = "tf-acc-test-83368561313263405"
                name                  = "tf-acc-test-83368561313263405"
              ~ tags                  = {
                  - "AWS.SSM.AppManager.EKS.Cluster.ARN" = "arn:aws:eks:us-west-2:123456789012:cluster/tf-acc-test-83368561313263405" -> null
                }
              ~ tags_all              = {
                  - "AWS.SSM.AppManager.EKS.Cluster.ARN" = "arn:aws:eks:us-west-2:123456789012:cluster/tf-acc-test-83368561313263405"
                } -> (known after apply)
                # (9 unchanged attributes hidden)
        
        
              ~ vpc_config {
                  + security_group_ids        = []
                    # (6 unchanged attributes hidden)
                }
                # (1 unchanged block hidden)
            }
        
          # aws_eks_node_group.test will be updated in-place
          ~ resource "aws_eks_node_group" "test" {
                id                     = "tf-acc-test-83368561313263405:tf-acc-test-83368561313263405"
              ~ release_version        = (sensitive) -> (sensitive)
                # (14 unchanged attributes hidden)
        
        
                # (2 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 2 to change, 0 to destroy.
--- FAIL: TestAccEKSNodeGroup_releaseVersion (914.95s)
=== CONT  TestAccEKSNodeGroup_amiType
--- PASS: TestAccEKSNodeGroup_RemoteAccess_sourceSecurityGroupIDs (1322.31s)
=== CONT  TestAccEKSNodeGroup_namePrefix
--- PASS: TestAccEKSNodeGroup_RemoteAccess_ec2SSHKey (1252.59s)
=== CONT  TestAccEKSNodeGroup_diskSize
--- PASS: TestAccEKSNodeGroup_InstanceTypes_multiple (1124.89s)
=== CONT  TestAccEKSNodeGroup_disappears
--- PASS: TestAccEKSNodeGroup_namePrefix (1239.68s)
=== CONT  TestAccEKSNodeGroup_CapacityType_spot
--- PASS: TestAccEKSNodeGroup_diskSize (1183.42s)
=== CONT  TestAccEKSNodeGroup_Name_generated
--- PASS: TestAccEKSNodeGroup_disappears (1296.72s)
--- PASS: TestAccEKSNodeGroup_amiType (1807.20s)
--- PASS: TestAccEKSNodeGroup_CapacityType_spot (1179.87s)
--- PASS: TestAccEKSNodeGroup_Name_generated (1332.48s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/eks	11481.331s

Failure is unrelated to this change.

@ewbankkit
Copy link
Contributor

@bryantbiggs Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a0e3a30 into hashicorp:main Nov 8, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 8, 2023
@bryantbiggs bryantbiggs deleted the refactor/eks-aws-sdk-go-v2 branch November 8, 2023 23:28
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants