-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multi-session support on the appstream_fleet
resource
#34266
Added multi-session support on the appstream_fleet
resource
#34266
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@justinretzolk How can we get this prioritized for the next release? Seems to be sitting stagnant for some time now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using the appstream functionality and this is both desired AND looks good from my perspective!
This is exactly what we need. is there any plan to release this ? Thanks |
Please add this feature. This will greatly reduce my appstream costing. |
Please make this function available. |
I would recommend anyone who wants this prioritized to upvote the PR (👍) as this is one of the ways the maintainers will prioritize the PR to be reviewed. All I can do is keep the branch up to date with main to make it as easy to review as possible. |
During destroy the StopFleet operation was not handling ResourceNotFound exceptions. This change will capture these errors and proceed with removing the resource from state as nothing further is required to delete the resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=appstream TESTS=TestAccAppStreamFleet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_' -timeout 360m
--- PASS: TestAccAppStreamFleet_disappears (815.79s)
--- PASS: TestAccAppStreamFleet_withTags (867.26s)
--- PASS: TestAccAppStreamFleet_completeWithoutStop (929.50s)
--- PASS: TestAccAppStreamFleet_basic (937.94s)
--- PASS: TestAccAppStreamFleet_emptyDomainJoin (1002.42s)
--- PASS: TestAccAppStreamFleet_multiSession (1073.71s)
--- PASS: TestAccAppStreamFleet_completeWithStop (1857.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appstream 1863.426s
Thanks for your contribution, @DanielRieske! 👍 |
This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds support for the multi-session capability on AppStream 2.0 fleets.
https://aws.amazon.com/about-aws/whats-new/2023/10/amazon-appstream-2-0-session-fleets-windows-server-os/
Relations
Closes #34245
References
Output from Acceptance Testing