Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added multi-session support on the appstream_fleet resource #34266

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Added multi-session support on the appstream_fleet resource #34266

merged 9 commits into from
Apr 2, 2024

Conversation

DanielRieske
Copy link
Contributor

Description

This PR adds support for the multi-session capability on AppStream 2.0 fleets.

https://aws.amazon.com/about-aws/whats-new/2023/10/amazon-appstream-2-0-session-fleets-windows-server-os/

Relations

Closes #34245

References

Output from Acceptance Testing

make testacc TESTS=TestAccAppStreamFleet_multiSession PKG=appstream
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_multiSession'  -timeout 360m
=== RUN   TestAccAppStreamFleet_multiSession
=== PAUSE TestAccAppStreamFleet_multiSession
=== CONT  TestAccAppStreamFleet_multiSession
--- PASS: TestAccAppStreamFleet_multiSession (913.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  915.372s
make testacc TESTS=TestAccAppStreamFleet_ PKG=appstream 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_'  -timeout 360m
=== RUN   TestAccAppStreamFleet_basic
=== PAUSE TestAccAppStreamFleet_basic
=== RUN   TestAccAppStreamFleet_disappears
=== PAUSE TestAccAppStreamFleet_disappears
=== RUN   TestAccAppStreamFleet_completeWithStop
=== PAUSE TestAccAppStreamFleet_completeWithStop
=== RUN   TestAccAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAppStreamFleet_completeWithoutStop
=== RUN   TestAccAppStreamFleet_withTags
=== PAUSE TestAccAppStreamFleet_withTags
=== RUN   TestAccAppStreamFleet_emptyDomainJoin
=== PAUSE TestAccAppStreamFleet_emptyDomainJoin
=== RUN   TestAccAppStreamFleet_multiSession
=== PAUSE TestAccAppStreamFleet_multiSession
=== CONT  TestAccAppStreamFleet_basic
=== CONT  TestAccAppStreamFleet_withTags
=== CONT  TestAccAppStreamFleet_multiSession
=== CONT  TestAccAppStreamFleet_emptyDomainJoin
=== CONT  TestAccAppStreamFleet_completeWithStop
=== CONT  TestAccAppStreamFleet_completeWithoutStop
=== CONT  TestAccAppStreamFleet_disappears
--- PASS: TestAccAppStreamFleet_completeWithoutStop (818.88s)
--- PASS: TestAccAppStreamFleet_emptyDomainJoin (862.81s)
--- PASS: TestAccAppStreamFleet_basic (869.92s)
--- PASS: TestAccAppStreamFleet_multiSession (877.00s)
--- PASS: TestAccAppStreamFleet_disappears (919.82s)
--- PASS: TestAccAppStreamFleet_withTags (931.11s)
--- PASS: TestAccAppStreamFleet_completeWithStop (1805.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1808.076s

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appstream Issues and PRs that pertain to the appstream service. size/M Managed by automation to categorize the size of a PR. labels Nov 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 4, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2023
@jackson-theisen
Copy link
Contributor

@justinretzolk How can we get this prioritized for the next release? Seems to be sitting stagnant for some time now.

brianberzins
brianberzins approved these changes Feb 9, 2024
View reviewed changes
Copy link

@brianberzins brianberzins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the appstream functionality and this is both desired AND looks good from my perspective!

@chaithanya1996
Copy link

This is exactly what we need. is there any plan to release this ? Thanks

@sayfeeahmed
Copy link

Please add this feature. This will greatly reduce my appstream costing.

@akramhossanbappy
Copy link

Please make this function available.
This will enable numerous consoles to expire in a single session and drastically reduce the cost.

@DanielRieske
Copy link
Contributor Author

I would recommend anyone who wants this prioritized to upvote the PR (👍) as this is one of the ways the maintainers will prioritize the PR to be reviewed.

All I can do is keep the branch up to date with main to make it as easy to review as possible.

@jar-b jar-b self-assigned this Apr 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 2, 2024
jar-b added 3 commits April 2, 2024 14:52
@jar-b
r/aws_appstream_fleet(docs): adjust compute_capacity descriptions
23c1560
@jar-b
r/aws_appstream_fleet(test): replace deprecated image_arn
674173b
@jar-b
r/aws_appstream_fleet: handle ResourceNotFound during stop fleet
ff09dc6 
During destroy the StopFleet operation was not handling ResourceNotFound exceptions. This change will capture these errors and proceed with removing the resource from state as nothing further is required to delete the resource.
jar-b
jar-b approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=appstream TESTS=TestAccAppStreamFleet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_'  -timeout 360m

--- PASS: TestAccAppStreamFleet_disappears (815.79s)
--- PASS: TestAccAppStreamFleet_withTags (867.26s)
--- PASS: TestAccAppStreamFleet_completeWithoutStop (929.50s)
--- PASS: TestAccAppStreamFleet_basic (937.94s)
--- PASS: TestAccAppStreamFleet_emptyDomainJoin (1002.42s)
--- PASS: TestAccAppStreamFleet_multiSession (1073.71s)
--- PASS: TestAccAppStreamFleet_completeWithStop (1857.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1863.426s

@jar-b
Copy link
Member

jar-b commented Apr 2, 2024

Thanks for your contribution, @DanielRieske! 👍

@jar-b jar-b merged commit a6381d5 into hashicorp:main Apr 2, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.44.0 milestone Apr 2, 2024
@DanielRieske DanielRieske deleted the f/add-appstream-multi-session-support branch April 2, 2024 20:11
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackson-theisen jackson-theisen jackson-theisen approved these changes

@jar-b jar-b jar-b approved these changes

@brianberzins brianberzins brianberzins approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appstream Issues and PRs that pertain to the appstream service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.44.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Multi-Session support to AppStream Fleets
8 participants
@DanielRieske @jackson-theisen @chaithanya1996 @sayfeeahmed @akramhossanbappy @jar-b @brianberzins @justinretzolk