Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove readonly properties within replication_settings for aws_dms_replication_config resource #34356

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Nov 11, 2023

Description

If the replication_settings is set and not computed there will be a perpetual change because certain properties that are returned by the API within this JSON blob cannot be set on creation or modification.

This issue was raised for the same property in the aws_dms_replication_task resource, of which the fix was to remove these properties from the JSON blob.

Relations

Closes #34348.
Closes #31917.
Closes #19801.
Closes #30721.
Closes #30709.
Closes #29765.
Closes #32194.
Closes #31136.

Output from Acceptance Testing

make testacc TESTS=TestAccDMSReplicationConfig_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSReplicationConfig_'  -timeout 360m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN   TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_update
=== CONT  TestAccDMSReplicationConfig_tags
=== CONT  TestAccDMSReplicationConfig_disappears
--- PASS: TestAccDMSReplicationConfig_disappears (1610.38s)
--- PASS: TestAccDMSReplicationConfig_update (1616.40s)
--- PASS: TestAccDMSReplicationConfig_basic (1676.35s)
--- PASS: TestAccDMSReplicationConfig_tags (1721.42s)
--- PASS: TestAccDMSReplicationConfig_startReplication (2460.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        2462.915s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR. labels Nov 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 11, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 13, 2023
@github-actions github-actions bot added service/ds Issues and PRs that pertain to the ds service. service/ce Issues and PRs that pertain to the ce service. service/deploy Issues and PRs that pertain to the deploy service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/evidently Issues and PRs that pertain to the evidently service. service/healthlake Issues and PRs that pertain to the healthlake service. service/finspace Issues and PRs that pertain to the finspace service. service/fis Issues and PRs that pertain to the fis service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. labels Dec 18, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_\|TestAccDMSReplicationTaskDataSource_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_\|TestAccDMSReplicationTaskDataSource_ -timeout 720m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN   TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== RUN   TestAccDMSReplicationTaskDataSource_basic
=== PAUSE TestAccDMSReplicationTaskDataSource_basic
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_update
=== PAUSE TestAccDMSReplicationTask_update
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== RUN   TestAccDMSReplicationTask_s3ToRDS
=== PAUSE TestAccDMSReplicationTask_s3ToRDS
=== RUN   TestAccDMSReplicationTask_disappears
=== PAUSE TestAccDMSReplicationTask_disappears
=== RUN   TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== RUN   TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== RUN   TestAccDMSReplicationTask_move
=== PAUSE TestAccDMSReplicationTask_move
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
=== CONT  TestAccDMSReplicationTask_update
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (976.10s)
=== CONT  TestAccDMSReplicationTask_basic
--- PASS: TestAccDMSReplicationConfig_basic (1492.66s)
=== CONT  TestAccDMSReplicationTaskDataSource_basic
--- PASS: TestAccDMSReplicationTask_update (1558.74s)
=== CONT  TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationTask_basic (1005.02s)
=== CONT  TestAccDMSReplicationConfig_update
--- PASS: TestAccDMSReplicationTaskDataSource_basic (1251.08s)
=== CONT  TestAccDMSReplicationConfig_tags
--- PASS: TestAccDMSReplicationConfig_update (1497.88s)
=== CONT  TestAccDMSReplicationConfig_disappears
--- PASS: TestAccDMSReplicationConfig_tags (1600.72s)
=== CONT  TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
--- PASS: TestAccDMSReplicationConfig_startReplication (3122.58s)
=== CONT  TestAccDMSReplicationTask_move
--- PASS: TestAccDMSReplicationConfig_disappears (1528.89s)
=== CONT  TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (982.45s)
=== CONT  TestAccDMSReplicationTask_s3ToRDS
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (950.45s)
=== CONT  TestAccDMSReplicationTask_disappears
--- PASS: TestAccDMSReplicationTask_move (1617.20s)
=== CONT  TestAccDMSReplicationTask_startReplicationTask
--- PASS: TestAccDMSReplicationTask_disappears (937.26s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1651.91s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1945.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	8249.323s

@ewbankkit
Copy link
Contributor

@DanielRieske @misterjacko @jeremychauvet Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b73f9aa into hashicorp:main Dec 19, 2023
44 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 19, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/athena Issues and PRs that pertain to the athena service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/ce Issues and PRs that pertain to the ce service. service/chime Issues and PRs that pertain to the chime service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/comprehend Issues and PRs that pertain to the comprehend service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. service/finspace Issues and PRs that pertain to the finspace service. service/firehose Issues and PRs that pertain to the firehose service. service/fis Issues and PRs that pertain to the fis service. service/fms Issues and PRs that pertain to the fms service. service/fsx Issues and PRs that pertain to the fsx service. service/gamelift Issues and PRs that pertain to the gamelift service. service/glacier Issues and PRs that pertain to the glacier service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/grafana Issues and PRs that pertain to the grafana service. service/greengrass Issues and PRs that pertain to the greengrass service. service/guardduty Issues and PRs that pertain to the guardduty service. service/healthlake Issues and PRs that pertain to the healthlake service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/inspector Issues and PRs that pertain to the inspector service. size/S Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
6 participants