-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove readonly properties within replication_settings
for aws_dms_replication_config
resource
#34356
Remove readonly properties within replication_settings
for aws_dms_replication_config
resource
#34356
Conversation
…nix-values' of github.com:jeremychauvet/terraform-provider-aws into b-19801-dms-replication-task-cdc-start-time-allow-non-unix-values
Community NoteVoting for Prioritization
For Submitters
|
…ingReadOnlyFieldsDiffs'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_\|TestAccDMSReplicationTaskDataSource_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3 -run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_\|TestAccDMSReplicationTaskDataSource_ -timeout 720m
=== RUN TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== RUN TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== RUN TestAccDMSReplicationTaskDataSource_basic
=== PAUSE TestAccDMSReplicationTaskDataSource_basic
=== RUN TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN TestAccDMSReplicationTask_update
=== PAUSE TestAccDMSReplicationTask_update
=== RUN TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== RUN TestAccDMSReplicationTask_s3ToRDS
=== PAUSE TestAccDMSReplicationTask_s3ToRDS
=== RUN TestAccDMSReplicationTask_disappears
=== PAUSE TestAccDMSReplicationTask_disappears
=== RUN TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== RUN TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== RUN TestAccDMSReplicationTask_move
=== PAUSE TestAccDMSReplicationTask_move
=== CONT TestAccDMSReplicationConfig_basic
=== CONT TestAccDMSReplicationTask_cdcStartPosition
=== CONT TestAccDMSReplicationTask_update
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (976.10s)
=== CONT TestAccDMSReplicationTask_basic
--- PASS: TestAccDMSReplicationConfig_basic (1492.66s)
=== CONT TestAccDMSReplicationTaskDataSource_basic
--- PASS: TestAccDMSReplicationTask_update (1558.74s)
=== CONT TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationTask_basic (1005.02s)
=== CONT TestAccDMSReplicationConfig_update
--- PASS: TestAccDMSReplicationTaskDataSource_basic (1251.08s)
=== CONT TestAccDMSReplicationConfig_tags
--- PASS: TestAccDMSReplicationConfig_update (1497.88s)
=== CONT TestAccDMSReplicationConfig_disappears
--- PASS: TestAccDMSReplicationConfig_tags (1600.72s)
=== CONT TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
--- PASS: TestAccDMSReplicationConfig_startReplication (3122.58s)
=== CONT TestAccDMSReplicationTask_move
--- PASS: TestAccDMSReplicationConfig_disappears (1528.89s)
=== CONT TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (982.45s)
=== CONT TestAccDMSReplicationTask_s3ToRDS
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (950.45s)
=== CONT TestAccDMSReplicationTask_disappears
--- PASS: TestAccDMSReplicationTask_move (1617.20s)
=== CONT TestAccDMSReplicationTask_startReplicationTask
--- PASS: TestAccDMSReplicationTask_disappears (937.26s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1651.91s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1945.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 8249.323s
@DanielRieske @misterjacko @jeremychauvet Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
If the
replication_settings
is set and not computed there will be a perpetual change because certain properties that are returned by the API within this JSON blob cannot be set on creation or modification.This issue was raised for the same property in the
aws_dms_replication_task
resource, of which the fix was to remove these properties from the JSON blob.Relations
Closes #34348.
Closes #31917.
Closes #19801.
Closes #30721.
Closes #30709.
Closes #29765.
Closes #32194.
Closes #31136.
Output from Acceptance Testing