Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lb_target_group: Adds plan- and apply-time validation and corrects documentation #34488

Merged
merged 12 commits into from
Nov 22, 2023
Merged

resource/aws_lb_target_group: Adds plan- and apply-time validation and corrects documentation #34488

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4b71544
Adds health check tests for `instance` targets
gdavison Nov 10, 2023
14cb55f
Adds tests for Lambda target groups
gdavison Nov 10, 2023
e48ce3d
[wip] Updates Lambda target
gdavison Nov 11, 2023
d96a82d
[wip] Adds plan-time validations
gdavison Nov 15, 2023
6543125
Adds migration to remove incorrect values when type is Lambda
gdavison Nov 15, 2023
04c9705
Linting fixes
gdavison Nov 15, 2023
5519f2d
Improves error messages
gdavison Nov 16, 2023
f08ed7e
Removes unneeded migration
gdavison Nov 20, 2023
c304b7f
Adds apply-time warning validations to Read
gdavison Nov 20, 2023
01678d5
Updates documentation
gdavison Nov 21, 2023
b60d6a7
Updates CHANGELOG
gdavison Nov 21, 2023
77a76c4
Removes newline
gdavison Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/34488.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_lb_target_group: Adds plan- and apply-time validation for invalid parameter combinations
```
10 changes: 10 additions & 0 deletions internal/service/elbv2/export_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

package elbv2

// Exports for use in tests only.
var (
HealthCheckProtocolEnumValues = healthCheckProtocolEnumValues
ProtocolVersionEnumValues = protocolVersionEnumValues
)
Loading
Loading