aws_s3_account_public_access_block: Migrate to AWS SDK for Go v2
#34525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
% make testacc TESTARGS='-run=TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic -timeout 360m
=== RUN TestAccS3ControlAccountPublicAccessBlock_serial
=== PAUSE TestAccS3ControlAccountPublicAccessBlock_serial
=== CONT TestAccS3ControlAccountPublicAccessBlock_serial
=== RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock
=== RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic
account_public_access_block_test.go:48: Step 1/2 error: Error running apply: exit status 1
Error: creating S3 Account Public Access Block (346386234494): operation error S3 Control: PutPublicAccessBlock, https response error StatusCode: 400, RequestID: 498MQ67VBD7NDMA7, HostID: tgd9dSvggMaadW7W7WpA8D59bDkXXFn3Z+/oTjP03v69xSFxhv5ODC8rsrktdXqEelq+y/4tBM0=, api error InvalidRequest: Must specify at least one configuration.
with aws_s3_account_public_access_block.test,
on terraform_plugin_test.tf line 1, in resource "aws_s3_account_public_access_block" "test":
1: resource "aws_s3_account_public_access_block" "test" {}
--- FAIL: TestAccS3ControlAccountPublicAccessBlock_serial (8.57s)
--- FAIL: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock (8.57s)
--- FAIL: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic (8.57s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/s3control 14.061s
FAIL
make: *** [testacc] Error 1
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/M
terraform-aws-provider
bot
added
the
prioritized
ewbankkit
added
the
technical-debt
Bumps the aws-sdk-go group with 2 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) and [github.com/aws/aws-sdk-go-v2/service/s3control](https://github.com/aws/aws-sdk-go-v2). Updates `github.com/aws/aws-sdk-go` from 1.48.2 to 1.48.3 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.48.2...v1.48.3) Updates `github.com/aws/aws-sdk-go-v2/service/s3control` from 1.37.1 to 1.38.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.38.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.37.1...service/s3/v1.38.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws-sdk-go - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3control dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk-go ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
github-actions
bot
added
size/L
# Conflicts: # go.mod # go.sum
ewbankkit
changed the title
aws_s3_account_public_access_block: Migrate to AWS SDK for Go v2aws_s3_account_public_access_block: Migrate to AWS SDK for Go v2
|
This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
justinretzolk
added
the
aws-sdk-go-migration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
aws_s3_account_public_access_blockresource and data source to AWS SDK for Go v2.Relations
Relates #33654.
Relates #32976.
Relates aws/aws-sdk-go-v2#2384.
Relates aws/aws-sdk-go-v2#2385.
Closes #34529.
Output from Acceptance Testing